Commit 1e8bc0c6 authored by Alexander Diewald's avatar Alexander Diewald
Browse files

JFX Editors: Implement CR comments

Issue-Ref: 3883
Issue-Url: https://af3-developer.fortiss.org/issues/3883

Signed-off-by: Alexander Diewald's avatarAlexander Diewald <diewald@fortiss.org>
parent fdf1f961
......@@ -2,6 +2,6 @@ PlatformArchitectureControllerFactory.java c49e4fb96ca1cbb796163cf0dcd6da97b650c
PlatformArchitectureFXEditorBinding.java a0d5fae2d2e375ec1c4daf9431a5068fc737f1dc GREEN
PlatformComponentControllerFactory.java b9e09906c0d5428d507d3affd879f30d9ed7d697 GREEN
PlatformComponentFXEditor.java 579bda140d6d490e40c49386957bf63af345f373 GREEN
PlatformComponentFXEditorBinding.java b9618c207a1778b5b47c8baaccc7a8a575fda59a RED
PlatformComponentFXEditorBinding.java 549c4185a92f1edcbbd9f48c885dd240e4795ae1 YELLOW
PlatformComponentModelFactory.java c834311e842c9e7638e70dac6d095ce0c7595637 GREEN
PlatformComponentVisualFactory.java 716c16155a90740e7ed9e28100a2814dc151b46d GREEN
......@@ -26,8 +26,6 @@ import org.fortiss.af3.platform.model.PlatformArchitecture;
import org.fortiss.tooling.kernel.ui.extension.IModelEditorBinding;
import org.fortiss.tooling.kernel.ui.extension.base.ModelEditorBindingBase;
import com.google.common.reflect.TypeToken;
/**
* Generic {@link IModelEditorBinding} for the multiple layers of hierarchical
* {@link PlatformArchitecture}s.
......@@ -37,11 +35,6 @@ import com.google.common.reflect.TypeToken;
public class PlatformComponentFXEditorBinding<T extends IPlatformArchitectureElement>
extends ModelEditorBindingBase<T> {
// TODO (TM): It seems as if this is not accessed anywhere. Remove if not needed.
/** Token of the generic parameter defining the type of the edited element. */
TypeToken<T> token = new TypeToken<>(getClass()) { /**/
};
/** {@inheritDoc} */
@Override
public Class<? extends IEditorPart> getEditorClass() {
......
TaskController.java 77833bf43e637b45c8d03d709eb879c61c757312 GREEN
TaskControllerFactory.java 00570ab13930645cd1d055a851217c41e2ecaab2 GREEN
TaskModelFactory.java 1bdcf252a807991911c2178df8713499a6fa55bd GREEN
TaskPortVisual.java b3fbbd7a27c77ad421dcc608c12ec4a2d8111eab GREEN
TaskStructureFXEditor.java cbae52e6d2f9997c83d173e802561dc7e68b8722 GREEN
TaskStructureFXEditorBinding.java b8a0623846892a80fb65dc4c3f1cf6ae29d87884 GREEN
TaskVisual.java 4f643f708a097d3ca9d7aeb838096dbd4569cac5 RED
TaskVisualFactory.java 476228bcd9dfe70722531b9d7a56f3eac942cb8b GREEN
TaskVisualFactory.java 8df9e7cd92d06b95a4ec92209e035507b5d40599 GREEN
......@@ -27,6 +27,8 @@ import org.eclipse.systemfocus.kernel.common.ui.javafx.lwfxef.visual.IVisualFact
import org.fortiss.af3.task.model.Signal;
import org.fortiss.af3.task.model.Task;
import org.fortiss.af3.task.model.TaskPort;
import org.fortiss.af3.task.ui.editor.fx.visual.TaskPortVisual;
import org.fortiss.af3.task.ui.editor.fx.visual.TaskVisual;
import org.fortiss.tooling.base.ui.editor.fx.visual.LayoutedLineLinkVisual;
/**
......
TaskPortVisual.java 978965bcf7ddad0e0e272cdb36acc61a1eff1c07 YELLOW
TaskVisual.java 09248bf35f08befb86eb21bdd0afaf660a48c455 YELLOW
......@@ -13,7 +13,7 @@
| See the License for the specific language governing permissions and |
| limitations under the License. |
+--------------------------------------------------------------------------*/
package org.fortiss.af3.task.ui.editor.fx;
package org.fortiss.af3.task.ui.editor.fx.visual;
import static javafx.scene.paint.Color.BLACK;
import static javafx.scene.paint.Color.WHITE;
......
......@@ -13,7 +13,7 @@
| See the License for the specific language governing permissions and |
| limitations under the License. |
+--------------------------------------------------------------------------*/
package org.fortiss.af3.task.ui.editor.fx;
package org.fortiss.af3.task.ui.editor.fx.visual;
import static org.fortiss.af3.task.ui.AF3TaskUIActivator.PLUGIN_ID;
import static org.fortiss.af3.task.ui.DefaultStyle.TASK_BACKGROUND;
......@@ -34,8 +34,6 @@ import javafx.scene.paint.Paint;
*
* @author munaro
*/
// TODO (TM): This package structure is inconsistent with other editors as the visuals are not
// contained in their respective package.
public class TaskVisual extends NamedLayoutedRectangularContentVisual<Task> {
/** The icon image. */
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment