Commit 291d573a authored by Sudeep Kanav's avatar Sudeep Kanav
Browse files

RED

refs 2248
parent 502dffe2
......@@ -54,7 +54,7 @@ import org.fortiss.tooling.kernel.utils.EcoreUtils;
* @author eder
* @author $Author$
* @version $Rev$
* @ConQAT.Rating YELLOW Hash: C90CDCDEFB1172722697C11835242BEE
* @ConQAT.Rating RED Hash: 81258176678CFCE066C480961FCA3763
*/
public class EnumPropertySection extends PropertySectionBase {
......@@ -68,12 +68,14 @@ public class EnumPropertySection extends PropertySectionBase {
private Label detachLabel;
/** The detach button. */
private Button detachButton;
// TODO (SK,4) Please rephrase
/** Stores enumeration implement the requirement correctly check button. */
private Button enumerationImplReqButton;
/** Label for the "enumeration implement requirement" text. */
private Label enumerationImplreqLabel;
/** for capturing the external relation specification from the set of specifications */
/** For capturing the external relation specification from the set of specifications */
ExternalRelationSpecification spec;
/** {@inheritDoc} */
......@@ -126,6 +128,7 @@ public class EnumPropertySection extends PropertySectionBase {
@Override
protected void setSectionInput(Object input) {
enumeration = (Enumeration)input;
// TODO (SK,19) following expression should be refactored.
traces =
pickInstanceOf(ExternalRelationSpecification.class, enumeration.getSpecifications())
.stream()
......@@ -143,6 +146,8 @@ public class EnumPropertySection extends PropertySectionBase {
if(pickInstanceOf(ExternalRelationSpecification.class, enumeration.getSpecifications())
.get(0) != null) {
// get(0) is to get the first instance of the externalRelationSpecification
// TODO (SK,20) pickInstanceOf(ExternalRelationSpecification.class,
// member.getSpecifications()) is used 3 times. Please make a local variable for it.
spec =
pickInstanceOf(ExternalRelationSpecification.class,
enumeration.getSpecifications()).get(0);
......
......@@ -63,6 +63,8 @@ public final class StructureMemberPropertySection extends PropertySectionBase {
/** Member type widget. */
private Text memberTypeText;
// TODO (SK,4) Please rephrase
/** Stores structure member implement the requirement correctly flag button. */
private Button structureMemberImplReqButton;
/** Label for the "structure member implement requirement" text. */
......@@ -89,6 +91,9 @@ public final class StructureMemberPropertySection extends PropertySectionBase {
@Override
protected void setSectionInput(Object input) {
member = (StructureMember)input;
// TODO (SK,19) following expression should be refactored.
// TODO (SK,20) pickInstanceOf(ExternalRelationSpecification.class,
// member.getSpecifications()) is used 3 times. Please make a local variable for it.
traces =
pickInstanceOf(ExternalRelationSpecification.class, member.getSpecifications())
.stream()
......
......@@ -126,6 +126,9 @@ public class StructurePropertySection extends PropertySectionBase {
@Override
protected void setSectionInput(Object input) {
structure = (Structure)input;
// TODO (SK,20) pickInstanceOf(ExternalRelationSpecification.class,
// member.getSpecifications()) is used 3 times. Please make a local variable for it.
// TODO (SK,19) following expression should be refactored.
traces =
pickInstanceOf(ExternalRelationSpecification.class, structure.getSpecifications())
.stream()
......@@ -154,6 +157,9 @@ public class StructurePropertySection extends PropertySectionBase {
public void refresh() {
super.refresh();
if(spec != null) {
// TODO (SK,?) Why is 1 appended? This also exists in StructureMemberPropertySection,
// and EnumPropertySectio. Please fix there also. Please have a look at the change I
// have made in EnumerationMemberPropertySection for this issue.
IObservableValue modelObservable1 =
observeValue(spec,
EXTERNAL_RELATION_SPECIFICATION__REQUIREMENT_IMPLEMENTED_CORRECTLY);
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment