Commit 379cdac5 authored by Klaus Becker's avatar Klaus Becker
Browse files

review

refs 304
parent c6da34ac
......@@ -33,7 +33,7 @@ import org.fortiss.tooling.kernel.extension.data.IConstraintViolation;
* @author hoelzl
* @author $Author$
* @version $Rev$
* @ConQAT.Rating YELLOW Hash: F343920205E73C9B5C1CEE72DDAEA682
* @ConQAT.Rating GREEN Hash: 8E0013E64FFE1B6213AA2EF74B92C37B
*/
public class ActionConstraintChecker extends
TypeCheckConstraintCheckerBase<Action, Component> {
......
......@@ -34,7 +34,7 @@ import org.fortiss.tooling.kernel.extension.data.IConstraintViolation;
* @author hoelzl
* @author $Author$
* @version $Rev$
* @ConQAT.Rating YELLOW Hash: 9267BCF45083EB7BA7AC4A7A5BE3AA0F
* @ConQAT.Rating GREEN Hash: 9D0C31EEC31F34607E7D4F57151D25ED
*/
public class ChannelConstraintChecker extends
MultiViolationConstraintCheckerBase<Channel, Component> {
......@@ -46,7 +46,11 @@ public class ChannelConstraintChecker extends
&& modelElement.getTarget() != null;
}
/** {@inheritDoc} */
/**
* {@inheritDoc}
*
* Check, if connected ports have same type and same initial value.
* */
@Override
public void collectViolations(Channel modelElement,
List<IConstraintViolation<Component>> results) {
......
......@@ -32,7 +32,7 @@ import org.fortiss.tooling.kernel.extension.data.IConstraintViolation;
* @author hoelzl
* @author $Author$
* @version $Rev$
* @ConQAT.Rating YELLOW Hash: AE57B0BE6C1853698E99A89738D88BBF
* @ConQAT.Rating GREEN Hash: D20E89E4286B13B8D767C8673074D6D3
*/
public class CodeSpecificationConstraintChecker extends
TypeCheckConstraintCheckerBase<CodeSpecification, Component> {
......
......@@ -41,7 +41,7 @@ import org.fortiss.tooling.kernel.extension.data.IConstraintViolation;
* @author hoelzl
* @author $Author$
* @version $Rev$
* @ConQAT.Rating YELLOW Hash: 40589ADF7CF91B7077811FA3095A2E86
* @ConQAT.Rating GREEN Hash: 1B09F856502BA1EBB89350E90A2EA39D
*/
public class ComponentConstraintChecker extends
MultiViolationConstraintCheckerBase<Component, Component> {
......
......@@ -30,7 +30,7 @@ import org.fortiss.tooling.kernel.extension.data.IConstraintViolation;
* @author hoelzl
* @author $Author$
* @version $Rev$
* @ConQAT.Rating YELLOW Hash: 440000E367CE0693F834D99447C88DD3
* @ConQAT.Rating GREEN Hash: 9E8722D43131AE7AE45877BF92055194
*/
final class ConstraintMessage {
......
......@@ -32,7 +32,7 @@ import org.fortiss.tooling.kernel.extension.data.IConstraintViolation;
* @author hoelzl
* @author $Author$
* @version $Rev$
* @ConQAT.Rating YELLOW Hash: 2991040D56B60AB9E6F579CEDF72DFDA
* @ConQAT.Rating GREEN Hash: A97915B6A575835C9F86900A00D427A4
*/
public class DataStateVariableConstraintChecker extends
TypeCheckConstraintCheckerBase<DataStateVariable, Component> {
......
......@@ -32,7 +32,7 @@ import org.fortiss.tooling.kernel.extension.data.IConstraintViolation;
* @author hoelzl
* @author $Author$
* @version $Rev$
* @ConQAT.Rating YELLOW Hash: E9089EFC19419482D09FAE81432B4A1E
* @ConQAT.Rating GREEN Hash: B4DD11B852DB33897853001432F768A7
*/
public class GuardConstraintChecker extends
TypeCheckConstraintCheckerBase<Guard, Component> {
......
......@@ -34,7 +34,7 @@ import org.fortiss.tooling.kernel.extension.data.IConstraintViolation;
* @author hoelzl
* @author $Author$
* @version $Rev$
* @ConQAT.Rating YELLOW Hash: B50B9681FFEE09F41D5E8936DAD1E957
* @ConQAT.Rating RED Hash: 95C7ABFF5094F435D4FB36ED78BC703E
*/
abstract class TypeCheckConstraintCheckerBase<T extends EObject, V extends EObject>
extends MultiViolationConstraintCheckerBase<T, V> {
......@@ -43,6 +43,7 @@ abstract class TypeCheckConstraintCheckerBase<T extends EObject, V extends EObje
@Override
protected final void collectViolations(T modelElement,
List<IConstraintViolation<V>> results) {
// TODO(Review): write short comment about what is checked here
collectOtherViolations(modelElement, results);
if (getTargetType(modelElement) instanceof TDefinedType) {
if (TypeSystemHandler.INSTANCE.getTypeProvider(modelElement)
......
......@@ -40,7 +40,7 @@ import org.fortiss.tooling.kernel.extension.data.IConstraintViolation;
* @author hoelzl
* @author $Author$
* @version $Rev$
* @ConQAT.Rating YELLOW Hash: 20BF1681A01CB1EDB3BA891757837FD5
* @ConQAT.Rating RED Hash: A25DC4B8368E2E583858CCD68DE9032F
*/
public class WeakCausalityCycleConstraintChecker extends
MultiViolationConstraintCheckerBase<ComponentArchitecture, Component> {
......@@ -49,6 +49,8 @@ public class WeakCausalityCycleConstraintChecker extends
@Override
public void collectViolations(ComponentArchitecture modelElement,
List<IConstraintViolation<Component>> results) {
// TODO(Review): write short comment about what is checked here (also for other
// methods)
List<Component> weaklyCausal = findWeaklyCausalComponents((Component) modelElement
.getContainedElements(0));
Map<Component, Set<Component>> predMap = new HashMap<Component, Set<Component>>();
......
<!--
$Id$
@version $Rev$
@ConQAT.Rating GREEN Hash: 9A7E574D5C89702EF8CE89C25037264A
-->
<body>
This package contains constraint-checkers.
</body>
<!--
$Id$
@version $Rev$
@ConQAT.Rating YELLOW Hash: 1E6E3D66674144EFC10936F09B587172
-->
<body>
This package contains the c-code generator.
</body>
......@@ -27,11 +27,12 @@ import org.fortiss.af3.project.model.typesystem.IType;
* @author hoelzl
* @author $Author$
* @version $Rev$
* @ConQAT.Rating YELLOW Hash: 11201012BFB9823797C2B62B8E837981
* @ConQAT.Rating RED Hash: 1D431B68E92B060F9EF3B9DDC55B2B39
*/
public class DataStateVariableStaticImpl {
/** Returns the data state variable's type. */
// TODO(Review): since getType() and getVariable() are public, why do we need these methods?
public static IType getVariableType(DataStateVariable dsv) {
return dsv.getType();
}
......
<!--
$Id$
@version $Rev$
@ConQAT.Rating RED Hash: 0C967C5592FDA2EB7A8AE74016BD06EB
-->
<body>
This package contains ...
</body>
......@@ -29,7 +29,7 @@ import org.fortiss.af3.project.typesystem.evaluation.Term;
* @author hoelzl
* @author $Author$
* @version $Rev$
* @ConQAT.Rating YELLOW Hash: DCF6D7BF05D9581CC17E59D4A05318C2
* @ConQAT.Rating GREEN Hash: D63B15F6E11516DDA005C6EEF90380D8
*/
public class ExecutableCodeSpecification extends
ExecutableAtomicComponentBase<CodeSpecification> {
......
<!--
$Id$
@version $Rev$
@ConQAT.Rating GREEN Hash: 15068ABC4DC794FDC9B30B438E48F8C4
-->
<body>
This package contains handling for simulation of components.
</body>
......@@ -36,7 +36,7 @@ import org.fortiss.tooling.kernel.extension.exception.TransformationFailedExcept
* @author hoelzl
* @author $Author$
* @version $Rev$
* @ConQAT.Rating YELLOW Hash: 00CD4AB4A84FEED0397058EEBC918849
* @ConQAT.Rating GREEN Hash: 2ED8F6B2FBE45C156112FBE9730C9815
*/
public class ExecutableCompositeComponentTransformation extends
ExecutableComponentTransformationBase {
......
......@@ -34,10 +34,13 @@ import org.fortiss.af3.project.model.typesystem.IType;
* @author hoelzl
* @author $Author$
* @version $Rev$
* @ConQAT.Rating GREEN Hash: BC605FB8D281480600414C7D57356506
* @ConQAT.Rating RED Hash: 7A8ECCEB1CD06F348CFE5512F1C3CDA6
*/
public class BehaviorModelElementFactory {
// TODO(Review): This class violates Review-Guideline: 'public methods must have
// their parameters and return value documented with @param and @return.'
/**
* Creates a {@link DataStateVariable} with the given name, type and initial
* value.
......
<!--
$Id$
@version $Rev$
@ConQAT.Rating GREEN Hash: 408C63B031170163AFE459120960E874
-->
<body>
This package contains utility functions for components.
</body>
......@@ -40,7 +40,7 @@ import org.fortiss.af3.expression.model.types.impl.TIntStaticImpl;
* @author ratiu
* @author $Author$
* @version $Rev$
* @ConQAT.Rating YELLOW Hash: AC595296A4367C4BBFAE5171EBE228F5
* @ConQAT.Rating GREEN Hash: 98A7FC63F8FCF8845B0AF3E459F26BD8
*/
public class CounterTestModel extends ComponentTestModelBase {
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment