Commit 44ecb60a authored by Ludwig Dickmanns's avatar Ludwig Dickmanns
Browse files

MCDC: Feedback Implementation

* TestingModelElementFactory
* TestingUtils: The last TODO (//TODO(HP): this doesn't have any effect.
Can't just be removed?): With the implemented feedback it can't be
removed.

Issue-Ref: 3464
Issue-Url: https://af3-developer.fortiss.org/issues/3464

Signed-off-by: Ludwig Dickmanns's avatarLudwig Dickmanns <dickmanns@fortiss.org>
parent e691f5a0
GenerateStateAutomatonUtils.java 81645f6c18da5bcc920f8671da4eeb622f8f69d4 GREEN
StatisticUtils.java d2ea1b26fc14f0b19d18604d330205b8aae3352e GREEN
TestingConstraintUtils.java 7c423db9009862b16a96c05ab7ef9a59d4af6c81 GREEN
TestingModelElementFactory.java cf4f08f841b81ce3044d7eba0d8520c6fd33a3c6 RED
TestingUtils.java 20cca57a6f425fa794846aa6e5738604ddf307e1 RED
TestingModelElementFactory.java 40440414d98fb8f1e0fa97bf42065af029099263 YELLOW
TestingUtils.java 274b7a65eb14c78b8daf47f4131dcfe303de19da YELLOW
......@@ -332,14 +332,9 @@ public class TestingModelElementFactory {
EList<Var> outputs, IExpressionTerm guard, StatementSequence thenBlock,
StatementSequence elseBlock) {
for(Var var : getChildrenWithType(guard, Var.class)) {
//TODO(HP): can't this be simplified by
//if(!inputs.contains(rhs)) {
// return null;
//}
if(inputs.contains(var)) {
continue;
if(!inputs.contains(var)) {
return null;
}
return null;
}
boolean valid = true;
......
......@@ -296,26 +296,15 @@ public class TestingUtils {
// an empty array.
IExpressionTerm rhs = ((Assignment)statement).getValue();
if(rhs instanceof Var) {
//TODO(HP): can't this be simplified by
//if(!inputs.contains(rhs)) {
// return false;
//}
if(inputs.contains(rhs)) {
continue;
if(!inputs.contains(rhs)) {
return false;
}
return false;
}
for(Var var : getChildrenWithType(rhs, Var.class)) {
//TODO(HP): can't this be simplified by
//if(!inputs.contains(rhs)) {
// return false;
//}
if(inputs.contains(var)) {
continue;
if(!inputs.contains(var)) {
return false;
}
return false;
}
//TODO(HP): this doesn't have any effect. Can't just be removed?
continue;
}
return false;
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment