Commit 66de63cc authored by Alexander Diewald's avatar Alexander Diewald
Browse files

YELLOW: Fix forgotten TODOs & clean dependencies

Issue-Ref: 3791
Issue-Url: https://af3-developer.fortiss.org/issues/3791

Signed-off-by: Alexander Diewald's avatarAlexander Diewald <diewald@fortiss.org>
parent 3fd1ed58
ComponentToPartitionArchitectureTransformation.java f27c895bd14377cec457bf33c4bfa7de88c73d72 GREEN
PartitionModelElementFactory.java ff80fd260146ca827871fe45ab16f8917a260bb1 RED
PartitionModelElementFactory.java 421e96d49d7fb66299e64128b0e3473f3268ddfc YELLOW
......@@ -88,25 +88,23 @@ public class PartitionModelElementFactory {
return pChan;
}
// TODO (SB, change 2nd parameter to Class<? extends IPortSemantic>)
/** Creates a {@link PartitionInputPort} with the given semantics. */
public static PartitionInputPort createPartitionInputPort(String name,
IPortSemantics semantic) {
if(semantic instanceof ISamplingPort) {
Class<? extends IPortSemantics> semantic) {
if(ISamplingPort.class.isAssignableFrom(semantic)) {
return createPartitionSamplingInputPort(name);
} else if(semantic instanceof IQueuingPort) {
} else if(IQueuingPort.class.isAssignableFrom(semantic)) {
return createPartitionQueuingInputPort(name);
}
return null;
}
// TODO (SB, change 2nd parameter to Class<? extends IPortSemantic>)
/** Creates a {@link PartitionOutputPort} with the given semantics. */
public static PartitionOutputPort createPartitionOutputPort(String name,
IPortSemantics semantic) {
if(semantic instanceof ISamplingPort) {
Class<? extends IPortSemantics> semantic) {
if(ISamplingPort.class.isAssignableFrom(semantic)) {
return createPartitionSamplingOutputPort(name);
} else if(semantic instanceof IQueuingPort) {
} else if(IQueuingPort.class.isAssignableFrom(semantic)) {
return createPartitionQueuingOutputPort(name);
}
return null;
......
......@@ -13,7 +13,9 @@ Bundle-Activator: org.fortiss.af3.schedule.AF3ScheduleActivator
Require-Bundle: org.fortiss.af3.platform;visibility:=reexport,
org.fortiss.af3.allocation;visibility:=reexport
Export-Package: org.fortiss.af3.schedule,
org.fortiss.af3.schedule.compositor,
org.fortiss.af3.schedule.model,
org.fortiss.af3.schedule.model.impl,
org.fortiss.af3.schedule.model.util,
org.fortiss.af3.schedule.prototypes,
org.fortiss.af3.schedule.utils
......@@ -27,7 +27,4 @@ Export-Package: org.fortiss.af3.task,
Bundle-ActivationPolicy: lazy
Bundle-Activator: org.fortiss.af3.task.AF3TaskActivator
Require-Bundle: org.fortiss.af3.allocation;visibility:=reexport,
org.fortiss.af3.component;visibility:=reexport,
org.fortiss.af3.timing;visibility:=reexport,
org.fortiss.af3.platform,
org.fortiss.af3.schedule;visibility:=reexport
ComponentToTaskArchitectureTransformation.java 08b738ccce02094f65aef08b9ca18c629621ccca GREEN
TaskArchitectureUtils.java d2f78c9f4b30863fb63210a128fecef0f14d56ce GREEN
TaskModelElementFactory.java 9b9514b8df373dcdf7067123d952dd252b183216 RED
TaskModelElementFactory.java 8377f5e124fd623dc2181024d27c6e988f0060c4 YELLOW
......@@ -83,12 +83,12 @@ public class TaskModelElementFactory {
return message;
}
// TODO (SB, change 2nd parameter to Class<? extends IPortSemantic>)
/** Creates a {@link TaskOutputPort} with the given semantics. */
public static TaskOutputPort createTaskOutputPort(String name, IPortSemantics semantic) {
if(semantic instanceof ISamplingPort) {
public static TaskOutputPort createTaskOutputPort(String name,
Class<? extends IPortSemantics> semantic) {
if(ISamplingPort.class.isAssignableFrom(semantic)) {
return createTaskSamplingOutputPort(name);
} else if(semantic instanceof IQueuingPort) {
} else if(IQueuingPort.class.isAssignableFrom(semantic)) {
return createTaskQueuingOutputPort(name);
}
return null;
......@@ -110,12 +110,12 @@ public class TaskModelElementFactory {
return pOutPort;
}
// TODO (SB, change 2nd parameter to Class<? extends IPortSemantic>)
/** Creates a {@link TaskInputPort} with the given semantics. */
public static TaskInputPort createTaskInputPort(String name, IPortSemantics semantic) {
if(semantic instanceof ISamplingPort) {
public static TaskInputPort createTaskInputPort(String name,
Class<? extends IPortSemantics> semantic) {
if(ISamplingPort.class.isAssignableFrom(semantic)) {
return createTaskSamplingInputPort(name);
} else if(semantic instanceof IQueuingPort) {
} else if(IQueuingPort.class.isAssignableFrom(semantic)) {
return createTaskQueuingInputPort(name);
}
return null;
......
......@@ -10,7 +10,7 @@ Bundle-Localization: plugin
Bundle-RequiredExecutionEnvironment: JavaSE-11
Bundle-ActivationPolicy: lazy
Bundle-Activator: org.fortiss.af3.timing.AF3TimingActivator
Require-Bundle: org.fortiss.af3.component;bundle-version="2.16.0";visibility:=reexport
Require-Bundle: org.fortiss.af3.component;visibility:=reexport
Export-Package: org.fortiss.af3.timing,
org.fortiss.af3.timing.annotation.valueprovider,
org.fortiss.af3.timing.approximation,
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment