Commit c2ea566e authored by Alexander Diewald's avatar Alexander Diewald
Browse files

CR: GREEN / RED

Issue-Ref: 3735
Issue-Url: https://af3-developer.fortiss.org/issues/3735

Signed-off-by: Alexander Diewald's avatarAlexander Diewald <diewald@fortiss.org>
parent e74ab50f
AllocationTableEditor.java babff48c09090a77d65a20d1c712b67abe8b5df3 YELLOW
ArchitectureParameterEditorBase.java c9e9a721f5b8aee62c39ae3307c9ad32a78bce4a YELLOW
ArchitectureParameterTableEditorBase.java c5af213271a7a4e9d7d3bc18ab82879ef4030213 YELLOW
ModelListenerEditorBase.java 0d0b5bc9c4385061cc69d30f7d9bcd19d5837324 YELLOW
AllocationTableEditor.java 36fbfaab7031e4f9483583eefcd707cbad69e2bc RED
ArchitectureParameterEditorBase.java c9e9a721f5b8aee62c39ae3307c9ad32a78bce4a GREEN
ArchitectureParameterTableEditorBase.java c5af213271a7a4e9d7d3bc18ab82879ef4030213 GREEN
ModelListenerEditorBase.java 0d0b5bc9c4385061cc69d30f7d9bcd19d5837324 GREEN
ParameterTableEditor.java 435231b3020dca1e20189a132439cc666cc72eb6 GREEN
......@@ -554,6 +554,7 @@ public abstract class AllocationTableEditor<T extends AllocationTable>
// This must be performed before setting the source view, in order to make the
// special case for the available source view elements in getModels() work
// correctly.
// TODO(AD): LambdaUtils.getFirst() should be preferred. It returns an Optional type.
targetView = targetModels.iterator().next();
final IProjectRootElement view = targetView;
runAsCommand(getEditedObject(), () -> {
......@@ -564,6 +565,7 @@ public abstract class AllocationTableEditor<T extends AllocationTable>
sourceModels = getModels(getSourceModelTypes());
if(sourceView == null && !sourceModels.isEmpty()) {
// Set source view if there is none yet, and the at is at least one available.
// TODO(AD): LambdaUtils.getFirst() should be preferred. It returns an Optional type.
sourceView = sourceModels.iterator().next();
final IProjectRootElement view = sourceView;
runAsCommand(getEditedObject(), () -> {
......
ParameterEntryTreeViewerEditingSupport.java 4ee444241e97e5988d8c6f2f3437aa0e89a83501 YELLOW
ParameterEntryTreeViewerEditingSupport.java 4ee444241e97e5988d8c6f2f3437aa0e89a83501 GREEN
ParameterEntryTreeViewerLabelProvider.java 46098593c7438473ce67f60dbbdc5d69afddc077 GREEN
ParameterSourceElementTreeViewerEditingSupport.java 9e30e6e0df10beaaf3231c9ff06a0c5ab1df9b34 GREEN
ParameterSourceElementTreeViewerLabelProvider.java 6dbb656b23bf79aedbfd31d14c248fbe8f32ebad GREEN
ParameterTableTreeViewerManager.java 497ae92bb11d8adbc1059636e632267f4fd035fd YELLOW
ParameterTableTreeViewerManager.java 497ae92bb11d8adbc1059636e632267f4fd035fd GREEN
TreeViewerCheckBoxEditingSupport.java e74087115ffcc255c9e7604f567f2c51478eac1b GREEN
TreeViewerCheckBoxLabelProvider.java a3f517284f52310b06f16d37fe351f44eb8e48ff GREEN
TreeViewerContentProvider.java 0dc2d65d875be474ca8e03782be031829879a052 GREEN
TreeViewerFirstColumnLabelProvider.java 41af5aeea1c94de2deb2a024b5d0c589302b0c15 GREEN
TreeViewerManager.java 48e4b94e4d5682fa5f37327f0184b82022ff531e YELLOW
TreeViewerManager.java 48e4b94e4d5682fa5f37327f0184b82022ff531e GREEN
AF3AllocationActivator.java fa98bbdbd34d9d3c76f7f2827f2f456105c90fa6 GREEN
IAllocationService.java d937da9be337e0fe063c18faa9a598b6c0ee5d00 YELLOW
IAllocationService.java d937da9be337e0fe063c18faa9a598b6c0ee5d00 GREEN
AllocationTableCollectionCompositorBase.java 6630ee4a803e13e7707013120f856c3b49c6a845 YELLOW
AllocationTableCollectionCompositorBase.java 03ad5e0c2e788d46ecf55c7a7dab45501e3f9277 RED
AllocationTableCollectionFileProjectCompositor.java acae4d3f3f3b07d4c1d235dfc224c83a50b8e3d8 GREEN
ParameterTableCompositorBase.java 7164f1e3be098024652f8df7515984021d914062 YELLOW
ParameterTableCompositorBase.java 7164f1e3be098024652f8df7515984021d914062 GREEN
......@@ -152,6 +152,9 @@ public abstract class AllocationTableCollectionCompositorBase
}
// Check for overlaps due to model types that are additionally covered
// TODO(AD): Please add an example what "additionally covered model types" are (ports)?
// TODO(AD): Please indicate the difference between the following 6 LoC and the next
// ones. They look quite similar.
Collection<Class<? extends IProjectRootElement>> atTypeCoveredModelTypes =
as.getCoveredModelTypes(atType);
if(isAnyRootElementAssignable(atTypeCoveredModelTypes, sourceModelTypes) ||
......
AllocationService.java 5ed08b5841d625a7e5f2da2eb559d21aa6913ceb YELLOW
AllocationService.java 5ed08b5841d625a7e5f2da2eb559d21aa6913ceb GREEN
AF3PartitionUIActivator.java b50e0e736acece40b219c0c7ca80b068ae4bda53 GREEN
DefaultStyle.java d1ca8acfc5481faf934709edd6ce5016a00c0735 YELLOW
PartitionRectangle.java 1da226f9b3d4ce058f639f8f8688b08768247af2 YELLOW
DefaultStyle.java d1ca8acfc5481faf934709edd6ce5016a00c0735 GREEN
PartitionRectangle.java 1da226f9b3d4ce058f639f8f8688b08768247af2 GREEN
......@@ -2,13 +2,13 @@ ComponentToPartitionAllocationTableEditor.java dbb3abb28aab24dd7172c9a355cb34988
ComponentToPartitionAllocationTableEditorBinding.java b6aff2074fe84fd0026fbe3a9fef3f69f6eff906 GREEN
InputPortToPartitionInputPortAllocationTableEditor.java ac635ad629721582f2e7f69549b6e1f80e60f559 GREEN
InputPortToPartitionInputPortAllocationTableEditorBinding.java 91d01ce53ecd14e0ca7341633bc45b7eff8a86d6 GREEN
MemoryAreaAllocationTableEditor.java 49e4adbc58488f4bda52e247cc6301359bd16e0f YELLOW
MemoryAreaAllocationTableEditor.java 49e4adbc58488f4bda52e247cc6301359bd16e0f GREEN
OutputPortToPartitionOutputPortAllocationTableEditor.java 88b81039f34f3eb3d7843940a1aa5af2c706f17b GREEN
OutputPortToPartitionOutputPortAllocationTableEditorBinding.java 9c410f9b3a2bdf7712ebec2b5083349a9c3b4c09 GREEN
PartitionArchitectureMemoryAreaAllocationEditor.java 24f188fe32dae679e58a61b289c957c010188ece YELLOW
PartitionArchitectureMemoryAreaAllocationEditorBinding.java e26ebc43af436215adf34f842d8328706b7fae2d YELLOW
PartitionEditor.java d308f21c6b965023a9a9298c76ae3b977088ea96 YELLOW
PartitionEditorBinding.java 4f622bf064145b157d4f12bdb3665f19a2a36416 YELLOW
PartitionArchitectureMemoryAreaAllocationEditor.java 24f188fe32dae679e58a61b289c957c010188ece GREEN
PartitionArchitectureMemoryAreaAllocationEditorBinding.java e26ebc43af436215adf34f842d8328706b7fae2d GREEN
PartitionEditor.java d308f21c6b965023a9a9298c76ae3b977088ea96 GREEN
PartitionEditorBinding.java 4f622bf064145b157d4f12bdb3665f19a2a36416 GREEN
PartitionInputPortToReceiverAllocationTableEditor.java cf904ac9be00edccbb9082b0611a2660966ea75b GREEN
PartitionInputPortToReceiverAllocationTableEditorBinding.java a69df4d0a4c8737a9a19d270d30f6661d9a0aade GREEN
PartitionOutputPortToTransmitterAllocationTableEditor.java aa00f185e339d3556411a3ff701de09726f8322b GREEN
......
MemoryAreaChannelEditPart.java 90f18c5cb1becb163b24a06fe186e25b68bcc8cf YELLOW
MemoryAreaEditPart.java 457e4123c4fbc79d099117b2886d7b8452fc56f2 YELLOW
MemoryAreaInputPortEditPart.java ad93a5f73ae3d717e318b2999872ac9e8fec4730 YELLOW
MemoryAreaOutputPortEditPart.java d33b0f5ab351c55ee66f918641026ac89b6f23bb YELLOW
PartitionArchitectureDiagramEditPart.java 9539e0a0aec08d8c19b4252e6dfdd5c872490046 YELLOW
MemoryAreaChannelEditPart.java 90f18c5cb1becb163b24a06fe186e25b68bcc8cf GREEN
MemoryAreaEditPart.java 457e4123c4fbc79d099117b2886d7b8452fc56f2 GREEN
MemoryAreaInputPortEditPart.java ad93a5f73ae3d717e318b2999872ac9e8fec4730 GREEN
MemoryAreaOutputPortEditPart.java d33b0f5ab351c55ee66f918641026ac89b6f23bb GREEN
PartitionArchitectureDiagramEditPart.java 9539e0a0aec08d8c19b4252e6dfdd5c872490046 GREEN
PartitionChannelEditPart.java 8768f18a0bcc58e4b4ea138399fe0652a34cc539 GREEN
PartitionEditPart.java 2fc04c017d17b66f8a9c31a46357e06087ec1d9c GREEN
PartitionEditPartFactory.java 8883e5a2dec3f51b99ad34d33257eb242a7dfcdc YELLOW
PartitionEditPartFactory.java 8883e5a2dec3f51b99ad34d33257eb242a7dfcdc GREEN
PartitionInputPortEditPart.java 66cbefe2819ef148755ecc0d80cf7a17a3f21889 GREEN
PartitionOutputPortEditPart.java 10cf7dcf1107d90bf6c1b679f789784a03df8c11 GREEN
ComponentToPartitionAllocationTableHandler.java 3db169c6fe33df5fc6b865dcb9ad7212ca851164 GREEN
MemoryAreaChannelHandler.java c230241d9f445e861b05afa3d1a466b804de7b98 YELLOW
MemoryAreaHandler.java f77f598235b9aa2fc53ceeb6b80ca057fe43b551 YELLOW
MemoryAreaInputPortHandler.java 849572edc08a7918b610036ba455bc619db62543 YELLOW
MemoryAreaOutputPortHandler.java d707db7de4f5c69617ceb68d48c5175d0a2d2325 YELLOW
PartitionArchitectureHandler.java cd0ada6e0a19d99524401296d4f1e541587ae871 YELLOW
MemoryAreaChannelHandler.java c230241d9f445e861b05afa3d1a466b804de7b98 GREEN
MemoryAreaHandler.java f77f598235b9aa2fc53ceeb6b80ca057fe43b551 GREEN
MemoryAreaInputPortHandler.java 849572edc08a7918b610036ba455bc619db62543 GREEN
MemoryAreaOutputPortHandler.java d707db7de4f5c69617ceb68d48c5175d0a2d2325 GREEN
PartitionArchitectureHandler.java cd0ada6e0a19d99524401296d4f1e541587ae871 GREEN
PartitionChannelHandler.java 0cc716342b8d7345f026b25104b637cfb911f6ac GREEN
PartitionHandler.java 194f6a9650deecd6a5071f87f8e0d3c90b5d7074 GREEN
PartitionQueuingInputPortHandler.java 14601c912f3d517f746b724c7e74d1c52b1a22a3 GREEN
......
PrototypeProvider.java 2b895137413fb36b97cf277814cd91f75aa10169 YELLOW
PrototypeProvider.java 2b895137413fb36b97cf277814cd91f75aa10169 GREEN
documentation.html ae11452eb1a3bb91f173a8643a415e49ffbec7be YELLOW
documentation.html ae11452eb1a3bb91f173a8643a415e49ffbec7be GREEN
partition.ecore 9d5f673b950baaa69c92c62d408afeb7574286c2 YELLOW
partition.ecore 9d5f673b950baaa69c92c62d408afeb7574286c2 GREEN
AF3PartitionActivator.java eee94da3d43ded643839233523d653acf33f36c0 YELLOW
AF3PartitionActivator.java eee94da3d43ded643839233523d653acf33f36c0 GREEN
ComponentToPartitionAllocationTableCollectionCompositor.java 9898197cab2b19dc6cfdc4d145507e99e2a3df06 GREEN
MemoryAreaAllocationTableCompositor.java 22e95b2ed2b5f7d29559eb49327a25f6f507a27a YELLOW
MemoryAreaConnectionCompositor.java 8889c5571b59cb46fd47b9176fb89b3feaa6312b YELLOW
MemoryAreaPortCompositor.java bf86b3479ed6d582888cf9c8cd503fe9dec3d7e9 YELLOW
PartitionArchitectureCompositor.java 131fff07f8678d712fc35dc41832c5eb64aac6fb YELLOW
MemoryAreaAllocationTableCompositor.java 22e95b2ed2b5f7d29559eb49327a25f6f507a27a GREEN
MemoryAreaConnectionCompositor.java 8889c5571b59cb46fd47b9176fb89b3feaa6312b GREEN
MemoryAreaPortCompositor.java bf86b3479ed6d582888cf9c8cd503fe9dec3d7e9 GREEN
PartitionArchitectureCompositor.java 131fff07f8678d712fc35dc41832c5eb64aac6fb GREEN
PartitionArchitectureFileProjectCompositor.java e3b4479fabbb7eba3cb269bede656c921d4a0f8a GREEN
PartitionConnectionCompositor.java 49f3f3e4423d67db1adf3997750fd6cd868529cb GREEN
PartitionPortCompositor.java 574d1bb9d9733f23830437ac56cd19b1d36dc7e7 YELLOW
PartitionPortCompositor.java 574d1bb9d9733f23830437ac56cd19b1d36dc7e7 GREEN
PartitionToExecutionUnitAllocationTableCollectionCompositor.java 3a2e468c847c91859ef19b88119c09e2b344c908 GREEN
PortCompositorBase.java 719527d62000454c81d0078e2b358fd0cfb3eb8f YELLOW
PortCompositorBase.java 877b2b6dac018f3068e0ea7db49e5ef31c178c2e RED
TaskToPartitionAllocationTableCollectionCompositor.java 098939da5b43572e89c4fcfc20fac94eb4b59616 GREEN
......@@ -32,6 +32,7 @@ import org.fortiss.tooling.kernel.extension.data.Prototype;
*
* @author zverlov
*/
// TODO(AD): Move to kernel.base.
public abstract class PortCompositorBase<T extends IHierarchicElement & ILayoutedModelElement>
extends HierarchicElementCompositorBase<T> {
......
ComponentToPartitionAllocationTableStaticImpl.java 507c845cdae49b97cce4742cc86479fd6c24ceec GREEN
MemoryAreaAllocationTableStaticImpl.java 32ac68062bb82cb820daf27f87bf797b5729688c YELLOW
MemoryAreaAllocationTableStaticImpl.java 32ac68062bb82cb820daf27f87bf797b5729688c GREEN
PartitionInputPortToReceiverAllocationEntryStaticImpl.java 4f515cb9dd15bcf91ff1a31aa718ff34e804958e GREEN
PartitionOutputPortToTransmitterAllocationEntryStaticImpl.java f74c7ec08a37fc269f6992e8e86d8af2de9fedd3 GREEN
PartitionPortToTransceiverAllocationEntryStaticImpl.java 222732027fb6167ac0b2debe6f01242b41888378 GREEN
......
MemoryAreaChannelStaticImpl.java f7ab03af7af14ec79d77f4c30cf80c1069447549 YELLOW
MemoryAreaStaticImpl.java 75f98643f191c5a16a9011bb9b46a881698c3e12 YELLOW
PartitionArchitectureStaticImpl.java c2d4f4217f69ec45fae5e9a8155e688077a4c9a2 YELLOW
MemoryAreaChannelStaticImpl.java f7ab03af7af14ec79d77f4c30cf80c1069447549 GREEN
MemoryAreaStaticImpl.java 75f98643f191c5a16a9011bb9b46a881698c3e12 GREEN
PartitionArchitectureStaticImpl.java c2d4f4217f69ec45fae5e9a8155e688077a4c9a2 GREEN
PartitionChannelStaticImpl.java 648cd4264917634f2a249e836d435789f36f6922 GREEN
PartitionSamplingInputPortStaticImpl.java 64168705cea07fc5b1283985799fb07efd4c121a GREEN
PartitionSamplingOutputPortStaticImpl.java 24e77e17ad6a77ef7483ec28902d89bfade89490 GREEN
PartitionStaticImpl.java 5b3ad305e43a1b7b7d8592f6293792d67cc0d38c YELLOW
PartitionStaticImpl.java 5b3ad305e43a1b7b7d8592f6293792d67cc0d38c GREEN
ComponentToPartitionArchitectureTransformation.java f27c895bd14377cec457bf33c4bfa7de88c73d72 GREEN
PartitionModelElementFactory.java 15387afa35cd0084eb9d9fad04501e0960455da9 YELLOW
PartitionModelElementFactory.java 15387afa35cd0084eb9d9fad04501e0960455da9 GREEN
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment