RED

Issue-Ref:3465
Signed-off-by: Hernan Ponce de Leon <ponce@fortiss.org>

org.fortiss.af3.testing/src/org/fortiss/af3/testing/mcdc/.ratings

-MCDCUtils.java d05720e66f3a86e7a17e185692e60a0f5abac85d YELLOW
-TestMCDCUtils.java a95770841e189f2c39b3455aa9c82d059da53d36 YELLOW
+MCDCUtils.java 40b6abf3ddd94ef5a3b0ebe69a369b842b41e1a6 RED

org.fortiss.af3.testing/src/org/fortiss/af3/testing/mcdc/MCDCUtils.java

@@ -64,6 +64,11 @@ public final class MCDCUtils {
 	 * @param context
 	 * @return the {@link Expr} for an {@link ITerm} or <code>null</code> for invalid inputs.
 	 */
+	// TODO(HP): Remove the println
+	// TODO(HP): Way to many nested ifs. maybe use pattern matching.
+	// Also, it would be better to just check "instance of X" for the Xs in the lowest level of the type hierarchy (BoolConst, Var, FunctionCall, 
+	// instead of IStatementTerm or IExpressionTerm) and just return null if not of the cases match that.
+	
 	public static Expr toZ3(String prefix, Context ctx, ITerm term, EObject context) {
 		if(term instanceof IStatementTerm) {
 			if(term instanceof IExpressionTerm) {
@@ -119,6 +124,7 @@ public final class MCDCUtils {
 						}
 						System.out.println("Arguments of PredefinedFunction < 1: " +
 								term.toString());
+						// TODO(HP): This is dead code. If the first 2 ifs were false, the 2rd will be true and return.
 						return null;
 					}
 					System.out.println("Unmatched FunctionCall: " + term.toString());