Commit e677269a authored by Alexander Diewald's avatar Alexander Diewald
Browse files

CommAlloc: GREEN

* Minor typo fixes in comments & newlines.
* Add todo for #3556 (https://af3-developer.fortiss.org/issues/3556)

Issue-Ref: 3223
Issue-Url: https://af3-developer.fortiss.org/issues/3223

Signed-off-by: Alexander Diewald's avatarAlexander Diewald <diewald@fortiss.org>
parent 2691a213
AllocationTableEditor.java 7f211105c086109d58e572f1180eb78cf63ce16e YELLOW
ModelListenerEditorBase.java 0393577edf52d2cf97e060df93e2d79ea71d9481 YELLOW
ParameterTableEditor.java d7ef21b22206c9d0a3473dfcad355ecea1acca1a YELLOW
AllocationTableEditor.java 7f211105c086109d58e572f1180eb78cf63ce16e GREEN
ModelListenerEditorBase.java 0393577edf52d2cf97e060df93e2d79ea71d9481 GREEN
ParameterTableEditor.java d7ef21b22206c9d0a3473dfcad355ecea1acca1a GREEN
ParameterEntryTreeViewerEditingSupport.java aedc9b5729911b42bf752d7edbe507ff4f447420 YELLOW
ParameterEntryTreeViewerEditingSupport.java aedc9b5729911b42bf752d7edbe507ff4f447420 GREEN
ParameterEntryTreeViewerLabelProvider.java 6306b45b4ca5da3776ffb706d6c5eb961f0b78ed GREEN
ParameterSourceElementTreeViewerEditingSupport.java 9e30e6e0df10beaaf3231c9ff06a0c5ab1df9b34 GREEN
ParameterSourceElementTreeViewerLabelProvider.java cb886708a180db20dee0411b37fa32185b9a95f5 GREEN
ParameterTableTreeViewerManager.java 573ee577f13178299b5abb5ca3978d7c61eeb47e YELLOW
TreeViewerCheckBoxEditingSupport.java 00d09fbe4950453c0272c6b497b994ffeec38023 YELLOW
TreeViewerCheckBoxLabelProvider.java 97fe6771fbe09ccd16c1fe1ade862d2f95093ed1 YELLOW
ParameterTableTreeViewerManager.java 573ee577f13178299b5abb5ca3978d7c61eeb47e GREEN
TreeViewerCheckBoxEditingSupport.java 00d09fbe4950453c0272c6b497b994ffeec38023 GREEN
TreeViewerCheckBoxLabelProvider.java 97fe6771fbe09ccd16c1fe1ade862d2f95093ed1 GREEN
TreeViewerContentProvider.java e19b353b4f7624fd38db782524fed5cdf66dff55 GREEN
TreeViewerFirstColumnLabelProvider.java 41af5aeea1c94de2deb2a024b5d0c589302b0c15 GREEN
TreeViewerManager.java cb6d6629e8b1a612b2e0f73f00231d545348a013 YELLOW
TreeViewerManager.java 2d62069504d24a11787165e893fca0625ad3bc26 GREEN
......@@ -381,7 +381,7 @@ public class TreeViewerManager<T extends AllocationTable> {
if(d2 == null) {
return 1;
}
// The order of the first columns are specified as ints
// The order of the first columns are specified as ints.
if(d1 instanceof Integer) {
if(d2 instanceof Integer) {
return ((Integer)d1).compareTo((Integer)d2);
......
AF3AllocationActivator.java fa98bbdbd34d9d3c76f7f2827f2f456105c90fa6 GREEN
IAllocationService.java 09de51c417e5cb184ab1092274204878967786ac YELLOW
IAllocationService.java 09de51c417e5cb184ab1092274204878967786ac GREEN
AllocationService.java b196524b59b1baa064aeb7b76480be2b96b7477c YELLOW
AllocationService.java b196524b59b1baa064aeb7b76480be2b96b7477c GREEN
AllocationModelElementFactory.java 1790fc35d560cdf74ac1900c0d289e58900a0c32 GREEN
AllocationUtils.java 77ac33c6dc7db4b456606d97c8f9409acc97da75 YELLOW
AllocationUtils.java 9132f51f04358b5ab8b2a403b5c47fd10d44da2d GREEN
......@@ -273,7 +273,7 @@ public class AllocationUtils {
Class<? extends AllocationEntry> entryType, IModelElement sourceElement,
IModelElement targetElement, Class<? extends AllocationEntry> parentEntryType,
boolean hasSourceViewHiddenRootElement) {
// It is possible to remove a current allocation (sourceElement, targetElement)
// It is possible to remove a current allocation (sourceElement, targetElement).
if(isAllocated(allocationTable, entryType, sourceElement, targetElement)) {
return true;
}
......@@ -295,7 +295,7 @@ public class AllocationUtils {
}
}
} else {
// Check if any of the current source element's parents have already been allocated
// Check if any of the current source element's parents have already been allocated.
IAllocationService as = IAllocationService.getInstance();
Collection<? extends IModelElement> relatedTargetElements =
getRelatedModelElements(targetElement, as.getTargetEntityTypes(entryType));
......@@ -319,9 +319,7 @@ public class AllocationUtils {
// the existing entry is extended with the additional targetElement.
// - n:1: If no entry exists for the given targetElement, a new entry is created. Otherwise,
// the existing entry is extended with the additional sourceElement.
if(IUnidirectional.class.isAssignableFrom(entryType))
{
if(IUnidirectional.class.isAssignableFrom(entryType)) {
return true;
}
......
ComponentToPartitionAllocationTableEditor.java dbb3abb28aab24dd7172c9a355cb34988b2e550e YELLOW
ComponentToPartitionAllocationTableEditorBinding.java a13c88d1b99a78c90af4825774440a4c1581c4ca YELLOW
InputPortToPartitionInputPortAllocationTableEditor.java ac635ad629721582f2e7f69549b6e1f80e60f559 YELLOW
InputPortToPartitionInputPortAllocationTableEditorBinding.java 521daafa50ee06ea000ea253259d88c529055530 YELLOW
OutputPortToPartitionOutputPortAllocationTableEditor.java 88b81039f34f3eb3d7843940a1aa5af2c706f17b YELLOW
OutputPortToPartitionOutputPortAllocationTableEditorBinding.java 91db0ed8652e3332e28c3466868b57037d6dd9ae YELLOW
PartitionEditor.java 4fed91e0c230d97f3640feba61eee9f155fb81b7 YELLOW
PartitionEditorBinding.java 35a60f371793d5e449e383f8e15dfeb7e4c291ba YELLOW
PartitionInputPortToReceiverAllocationTableEditor.java cf904ac9be00edccbb9082b0611a2660966ea75b YELLOW
PartitionInputPortToReceiverAllocationTableEditorBinding.java cd30128b2c781585b5fde8fd5c37367172d8fd15 YELLOW
PartitionOutputPortToTransmitterAllocationTableEditor.java aa00f185e339d3556411a3ff701de09726f8322b YELLOW
PartitionOutputPortToTransmitterAllocationTableEditorBinding.java 113b06acaafc8f4a436981e3c7a180fa58ac05bc YELLOW
PartitionPortToTransceiverAllocationTableEditor.java 4c3b3cdc9e4fa769387a691f18b9d4083e7af281 YELLOW
PartitionPortToTransceiverAllocationTableEditorBinding.java f9035312ca5b655af523da5e79aee6e1a08fca5a YELLOW
PartitionToExecutionUnitAllocationTableEditor.java abdeb488238df6f9eee80d4aa00ce1931856f65c YELLOW
PartitionToExecutionUnitAllocationTableEditorBinding.java b726b66d2bcb46533af6888f8536e16cea10bcce YELLOW
TaskInputPortToPartitionInputPortAllocationTableEditor.java 087b26f37b29318ab6282926cb4696a29ae52fd9 YELLOW
TaskInputPortToPartitionInputPortAllocationTableEditorBinding.java 3db3df737e3006d45fab3c84408e1cd70e4a4800 YELLOW
TaskOutputPortToPartitionOutputPortAllocationTableEditor.java e17d7aa4733ed0d1e5780a44d59b54f99c1e11ca YELLOW
TaskOutputPortToPartitionOutputPortAllocationTableEditorBinding.java 8cc685fdae016bd4d5b3c876bf3dfb9349d22bef YELLOW
TaskToPartitionAllocationTableEditor.java ebae374f3846b4f55df64abfd09ae6d320ed941b YELLOW
TaskToPartitionAllocationTableEditorBinding.java 72b7148bdf0ca8467105d796ad65671e2c34c6ec YELLOW
ComponentToPartitionAllocationTableEditor.java dbb3abb28aab24dd7172c9a355cb34988b2e550e GREEN
ComponentToPartitionAllocationTableEditorBinding.java a13c88d1b99a78c90af4825774440a4c1581c4ca GREEN
InputPortToPartitionInputPortAllocationTableEditor.java ac635ad629721582f2e7f69549b6e1f80e60f559 GREEN
InputPortToPartitionInputPortAllocationTableEditorBinding.java 521daafa50ee06ea000ea253259d88c529055530 GREEN
OutputPortToPartitionOutputPortAllocationTableEditor.java 88b81039f34f3eb3d7843940a1aa5af2c706f17b GREEN
OutputPortToPartitionOutputPortAllocationTableEditorBinding.java 91db0ed8652e3332e28c3466868b57037d6dd9ae GREEN
PartitionEditor.java 4fed91e0c230d97f3640feba61eee9f155fb81b7 GREEN
PartitionEditorBinding.java 35a60f371793d5e449e383f8e15dfeb7e4c291ba GREEN
PartitionInputPortToReceiverAllocationTableEditor.java cf904ac9be00edccbb9082b0611a2660966ea75b GREEN
PartitionInputPortToReceiverAllocationTableEditorBinding.java cd30128b2c781585b5fde8fd5c37367172d8fd15 GREEN
PartitionOutputPortToTransmitterAllocationTableEditor.java aa00f185e339d3556411a3ff701de09726f8322b GREEN
PartitionOutputPortToTransmitterAllocationTableEditorBinding.java 113b06acaafc8f4a436981e3c7a180fa58ac05bc GREEN
PartitionPortToTransceiverAllocationTableEditor.java 4c3b3cdc9e4fa769387a691f18b9d4083e7af281 GREEN
PartitionPortToTransceiverAllocationTableEditorBinding.java f9035312ca5b655af523da5e79aee6e1a08fca5a GREEN
PartitionToExecutionUnitAllocationTableEditor.java abdeb488238df6f9eee80d4aa00ce1931856f65c GREEN
PartitionToExecutionUnitAllocationTableEditorBinding.java b726b66d2bcb46533af6888f8536e16cea10bcce GREEN
TaskInputPortToPartitionInputPortAllocationTableEditor.java 087b26f37b29318ab6282926cb4696a29ae52fd9 GREEN
TaskInputPortToPartitionInputPortAllocationTableEditorBinding.java 3db3df737e3006d45fab3c84408e1cd70e4a4800 GREEN
TaskOutputPortToPartitionOutputPortAllocationTableEditor.java e17d7aa4733ed0d1e5780a44d59b54f99c1e11ca GREEN
TaskOutputPortToPartitionOutputPortAllocationTableEditorBinding.java 8cc685fdae016bd4d5b3c876bf3dfb9349d22bef GREEN
TaskToPartitionAllocationTableEditor.java ebae374f3846b4f55df64abfd09ae6d320ed941b GREEN
TaskToPartitionAllocationTableEditorBinding.java 72b7148bdf0ca8467105d796ad65671e2c34c6ec GREEN
partition.ecore 99d4573523a20e9f387ab0c04dcd97af13bb5711 YELLOW
partition.ecore 99d4573523a20e9f387ab0c04dcd97af13bb5711 GREEN
AF3PartitionActivator.java fdc163026308e65ec9dae764a96b0263bbc61053 YELLOW
AF3PartitionActivator.java cfea5c321536eb8895b3da894e364ad8d028cb26 GREEN
......@@ -77,6 +77,7 @@ public class AF3PartitionActivator extends Plugin {
super.start(context);
plugin = this;
// TODO(#3556): Add more structure to allocation service registrations.
final IAllocationService as = IAllocationService.getInstance();
as.addAllocationEntryType(ComponentToPartitionAllocationTable.class,
ComponentToPartitionAllocationEntry.class);
......
ComponentToPartitionAllocationTableStaticImpl.java e13769c38fddf5d945d1371945b8f7e00c4640c9 GREEN
PartitionInputPortToReceiverAllocationEntryStaticImpl.java 4f515cb9dd15bcf91ff1a31aa718ff34e804958e YELLOW
PartitionOutputPortToTransmitterAllocationEntryStaticImpl.java f74c7ec08a37fc269f6992e8e86d8af2de9fedd3 YELLOW
PartitionPortToTransceiverAllocationEntryStaticImpl.java 222732027fb6167ac0b2debe6f01242b41888378 YELLOW
PartitionInputPortToReceiverAllocationEntryStaticImpl.java 4f515cb9dd15bcf91ff1a31aa718ff34e804958e GREEN
PartitionOutputPortToTransmitterAllocationEntryStaticImpl.java f74c7ec08a37fc269f6992e8e86d8af2de9fedd3 GREEN
PartitionPortToTransceiverAllocationEntryStaticImpl.java 222732027fb6167ac0b2debe6f01242b41888378 GREEN
PartitionToExecutionUnitAllocationTableStaticImpl.java f8af5519bc6d787813c75df272f50415aa2dd710 GREEN
TaskToPartitionAllocationTableStaticImpl.java ab73e3abf3667a9080b006f99b6ef75164743e8f GREEN
ComponentToExecutionUnitTableEditor.java 989c935c33719327c4393783252e48dbd750709c YELLOW
ComponentToExecutionUnitTableEditor.java 989c935c33719327c4393783252e48dbd750709c GREEN
ComponentToExecutionUnitTableEditorBinding.java e57cacc5663a8d5dfa9ebccfb22a6149d9fcd203 GREEN
InputPortToReceiverTableEditor.java d4308f3a3a90356d7fc95eeb4a3226022b417b94 YELLOW
InputPortToReceiverTableEditorBinding.java 5189cfa6d29a467775a8128e0fde80401aa95582 YELLOW
OutputPortToTransmitterTableEditor.java fd4ad61258d602a0ba9a386db88d881ff604e49d YELLOW
OutputPortToTransmitterTableEditorBinding.java 0bd19cceb8d307ae94f111a3b6d491fb37bf6067 YELLOW
PlatformArchitectureEditor.java 741a2ff586c9503db0687a3ff9eb23620b50eca0 YELLOW
InputPortToReceiverTableEditor.java d4308f3a3a90356d7fc95eeb4a3226022b417b94 GREEN
InputPortToReceiverTableEditorBinding.java 5189cfa6d29a467775a8128e0fde80401aa95582 GREEN
OutputPortToTransmitterTableEditor.java fd4ad61258d602a0ba9a386db88d881ff604e49d GREEN
OutputPortToTransmitterTableEditorBinding.java 0bd19cceb8d307ae94f111a3b6d491fb37bf6067 GREEN
PlatformArchitectureEditor.java 741a2ff586c9503db0687a3ff9eb23620b50eca0 GREEN
PlatformArchitectureEditorBinding.java 2e52757dcff1d9bed9b34a804a4c77b37c283f02 GREEN
PortToTransceiverTableEditor.java 6b20290163e466da5e6222a70d0cd075a1b08260 YELLOW
PortToTransceiverTableEditorBinding.java f8697fac115e13887ab2cfa790aad9f1bf8bc685 YELLOW
PortToTransceiverTableEditor.java 6b20290163e466da5e6222a70d0cd075a1b08260 GREEN
PortToTransceiverTableEditorBinding.java f8697fac115e13887ab2cfa790aad9f1bf8bc685 GREEN
AF3PlatformActivator.java 417ea0de27113f70e143bfbc4382fb362359a05e YELLOW
AF3PlatformActivator.java dfb8917bfabd989d42093c98ee98d34fa5ad8ee7 GREEN
......@@ -53,6 +53,7 @@ public class AF3PlatformActivator extends Plugin {
super.start(context);
plugin = this;
// TODO(#3556): Add more structure to allocation service registrations.
final IAllocationService as = IAllocationService.getInstance();
as.addAllocationEntryType(ComponentToExecutionUnitAllocationTable.class,
ComponentToExecutionUnitAllocationEntry.class);
......
ComponentToExecutionUnitAllocationEntryStaticImpl.java 20bf3ac771e912073760e1432b027aa45d784538 YELLOW
ComponentToExecutionUnitAllocationTableStaticImpl.java e2ff8f73a5be66e231eca39c3bf90e4691d4602c YELLOW
InputPortToReceiverAllocationEntryStaticImpl.java d9336ab748c14d65f0f408dfe0c33bc174476a10 YELLOW
OutputPortToTransmitterAllocationEntryStaticImpl.java 51d055719cf24d1c8a3a84d7cf3090e8c36e914d YELLOW
PortToTransceiverAllocationEntryStaticImpl.java 35465cfae8b44ff065e3c1893e4bbfb22f7e9858 YELLOW
ComponentToExecutionUnitAllocationEntryStaticImpl.java 4d05cdc8a5f89b314914d7495bc834dcd528e661 GREEN
ComponentToExecutionUnitAllocationTableStaticImpl.java 3b3af83a1de77cfb2b57c2be1f9ec83ed3f37ecd GREEN
InputPortToReceiverAllocationEntryStaticImpl.java d9336ab748c14d65f0f408dfe0c33bc174476a10 GREEN
OutputPortToTransmitterAllocationEntryStaticImpl.java 51d055719cf24d1c8a3a84d7cf3090e8c36e914d GREEN
PortToTransceiverAllocationEntryStaticImpl.java 35465cfae8b44ff065e3c1893e4bbfb22f7e9858 GREEN
......@@ -40,7 +40,6 @@ public class ComponentToExecutionUnitAllocationEntryStaticImpl {
* {@link ComponentToExecutionUnitAllocationEntry}.
*/
public static EList<Component> getComponents(ComponentToExecutionUnitAllocationEntry entry) {
return convertList(Component.class, entry.getSourceElements());
}
......
......@@ -55,7 +55,6 @@ public class ComponentToExecutionUnitAllocationTableStaticImpl {
*/
public static EList<Component> getComponents(ComponentToExecutionUnitAllocationTable ca2pa,
ExecutionUnit executionUnit) {
return convertList(Component.class, ca2pa.getSourceElements(executionUnit,
ComponentToExecutionUnitAllocationEntry.class));
}
......
TransformAllocationToDeploymentMenu.java 0cd6ff4215d9b886ec86e3c06d1eaf9b5abeae67 YELLOW
TransformAllocationToDeploymentMenu.java 27c9e3da77302b32d008facc446a20f8f3f860b6 GREEN
TransformComponentToTaskArchitectureMenu.java ad942277323f1e75cba315af31827c351e475434 GREEN
......@@ -51,12 +51,12 @@ public class TransformAllocationToDeploymentMenu implements IContextMenuContribu
/**
* {@link Action} to execute the {@link ComponentToExecutionUnitAllocationTable} to
* {@link Deployment} transformation. .
* {@link Deployment} transformation.
*/
protected class LaunchTransformComponentToExecutionUnitAllocationTableToDeploymentAction
extends Action {
/** {@link ComponentToExecutionUnitAllocationTable} selected by user */
/** {@link ComponentToExecutionUnitAllocationTable} selected by user. */
private final ComponentToExecutionUnitAllocationTable ca2hw;
/** Constructor. */
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment