From 165b21b44f039ea3cfed050666a9014b6b40ba17 Mon Sep 17 00:00:00 2001
From: Florian Hoelzl <hoelzl@fortiss.org>
Date: Wed, 4 Jan 2012 15:05:17 +0000
Subject: [PATCH] RED refs 311
---
.../base/ContextMenuSubMenuContributorBase.java | 11 ++++++++---
.../kernel/ui/extension/base/EObjectActionBase.java | 8 +-------
2 files changed, 9 insertions(+), 10 deletions(-)
diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/base/ContextMenuSubMenuContributorBase.java b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/base/ContextMenuSubMenuContributorBase.java
index 23d44a7d6..ab5722a2b 100644
--- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/base/ContextMenuSubMenuContributorBase.java
+++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/base/ContextMenuSubMenuContributorBase.java
@@ -36,8 +36,9 @@ import org.fortiss.tooling.kernel.ui.service.IContextMenuService;
/**
* Base class for context menu contributors creating a sub-menu
- * {@link IMenuManager} with actions provided by actions factories
- * {@link ActionFactory} returned by {@link #getActionFactories()}.
+ * {@link IMenuManager} with actions provided by actions factories TODO: @review
+ * this link is wrong => {@link ActionFactory} returned by
+ * {@link #getActionFactories()}.
*
* The class implements interface methods {@link #getMenuIcon()} and
* {@link #getMenuId()} returning {@code null} by default. Classes providing an
@@ -46,6 +47,9 @@ import org.fortiss.tooling.kernel.ui.service.IContextMenuService;
* The generic type parameter {@code T} indicated the type of selection
* elements.
*
+ * @param <T>
+ * TODO document T here
+ *
* @author trachtenherz
* @author $Author: hoelzl $
* @version $Rev: 18709 $
@@ -53,7 +57,8 @@ import org.fortiss.tooling.kernel.ui.service.IContextMenuService;
*/
public abstract class ContextMenuSubMenuContributorBase<T extends EObject>
implements IContextMenuContributor {
-
+ // TODO reorder methods: implemented before abstract before default
+ // implementations
/** The name of the sub-menu */
protected abstract String getMenuName();
diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/base/EObjectActionBase.java b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/base/EObjectActionBase.java
index aaf4f4c5a..aef527fd5 100644
--- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/base/EObjectActionBase.java
+++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/base/EObjectActionBase.java
@@ -24,7 +24,7 @@ import org.eclipse.jface.resource.ImageDescriptor;
/**
* JFace {@link Action}, which uses an {@link EObject} as target.
*
- * @author hoelzlf
+ * @author hoelzl
* @author $Author$
* @version $Rev$
* @ConQAT.Rating YELLOW Hash: 4C545F6468D6051419AA91C0E3774061
@@ -72,12 +72,6 @@ public abstract class EObjectActionBase<T extends EObject> extends Action {
}
/** Refreshes the action's target and enabled state. */
- // TODO @review DT: should a user take setTarget or refresh for a new
- // element?
- // Should a constructor take setTarget or refresh? should there be a refresh
- // method for the currently set element, i. e. refresh(). Possibility:
- // refresh() for current element and refresh(element){setTarget(element);
- // refresh()}.
public final void refresh(T element) {
setTarget(element);
if (element == null) {
--
GitLab