From 25dd9531a9ccc0ec244380f14d23b35bd79d9696 Mon Sep 17 00:00:00 2001 From: Alexander Diewald <diewald@fortiss.org> Date: Tue, 6 Nov 2018 17:52:03 +0100 Subject: [PATCH] Code Review: GREEN * Intermediate review: Issue is open for the correct solution. * Improved documentation such that developers unfamiliar with the bug can understand the problem more easily. Issue-Ref: 3517 Issue-Url: https://af3-developer.fortiss.org/issues/3517 Signed-off-by: Alexander Diewald <diewald@fortiss.org> --- .../src/org/fortiss/tooling/base/ui/layout/.ratings | 2 +- .../layout/EllipseCurveLayoutDiagramConfiguration.java | 9 +++++---- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/org.fortiss.tooling.base.ui/src/org/fortiss/tooling/base/ui/layout/.ratings b/org.fortiss.tooling.base.ui/src/org/fortiss/tooling/base/ui/layout/.ratings index 2da31de76..4f558ed8b 100644 --- a/org.fortiss.tooling.base.ui/src/org/fortiss/tooling/base/ui/layout/.ratings +++ b/org.fortiss.tooling.base.ui/src/org/fortiss/tooling/base/ui/layout/.ratings @@ -1,4 +1,4 @@ DiagramLayoutConfigurationBase.java a2fdf000358081429b80706bf29ad6eeda056c2b GREEN -EllipseCurveLayoutDiagramConfiguration.java a7525b252cd5b92549952a81dbb84e646550ebee YELLOW +EllipseCurveLayoutDiagramConfiguration.java c829b7b82c062a96f8e0c76f78b49ff05b4ddaa2 GREEN IDiagramLayoutConfiguration.java 2c05b73b104fcea91ad3505ae255e014c314685c GREEN RectangleGridLayoutDiagramConfiguration.java 23ddf57d202057181c150bd8c8b6df972b762522 GREEN diff --git a/org.fortiss.tooling.base.ui/src/org/fortiss/tooling/base/ui/layout/EllipseCurveLayoutDiagramConfiguration.java b/org.fortiss.tooling.base.ui/src/org/fortiss/tooling/base/ui/layout/EllipseCurveLayoutDiagramConfiguration.java index a7525b252..c829b7b82 100644 --- a/org.fortiss.tooling.base.ui/src/org/fortiss/tooling/base/ui/layout/EllipseCurveLayoutDiagramConfiguration.java +++ b/org.fortiss.tooling.base.ui/src/org/fortiss/tooling/base/ui/layout/EllipseCurveLayoutDiagramConfiguration.java @@ -125,10 +125,11 @@ public class EllipseCurveLayoutDiagramConfiguration extends DiagramLayoutConfigu // update move delta with new position newPosition.translate(newPosition.getDifference(oldPosition)); - // TODO FR (see #3517). The moveData seems not to be correctly calculated and one - // could not found a solution for its calculation yet. The "ghost" cursor should - // move on the ellipse border, the same as on a rectangular border. It can be used - // like this till a solution will be found. + // TODO FR (see #3517). The moveData is not correctly calculated. The projected location + // should move on the ellipse border, the same as on a rectangular border. As of now the + // projection is also placed outside and inside the ellipse. + // Until the calculation code is fixed, do not apply the result such that these connectors + // are at least moveable all around the ellipse. // request.setMoveDelta(new Point(newPosition.getX(), newPosition.getY())); } -- GitLab