diff --git a/org.fortiss.tooling.base/trunk/model/base.ecore b/org.fortiss.tooling.base/trunk/model/base.ecore index 067e000061c5240a5284d5c209e1ef847a27a65b..115d1e23994b4856fd63941a0949892855544287 100644 --- a/org.fortiss.tooling.base/trunk/model/base.ecore +++ b/org.fortiss.tooling.base/trunk/model/base.ecore @@ -27,7 +27,6 @@ <eAnnotations source="http://www.eclipse.org/emf/2002/GenModel"> <details key="documentation" value="Super class of model element specifications. Such specifications provide additional plugable properties."/> </eAnnotations> - <eOperations name="specificationDescription" eType="ecore:EDataType http://www.eclipse.org/emf/2002/Ecore#//EString"/> </eClassifiers> <eClassifiers xsi:type="ecore:EClass" name="IModelElementReference" abstract="true" interface="true"> diff --git a/org.fortiss.tooling.base/trunk/model/base.genmodel b/org.fortiss.tooling.base/trunk/model/base.genmodel index ce92a6c0823eae4ee16ecc8e806a0f77f3c99a20..39ca72659b9e3e5b7c18eadb27f773222f74f10f 100644 --- a/org.fortiss.tooling.base/trunk/model/base.genmodel +++ b/org.fortiss.tooling.base/trunk/model/base.genmodel @@ -15,9 +15,7 @@ <genFeatures notify="false" createChild="false" propertySortChoices="true" ecoreFeature="ecore:EReference base.ecore#//element/IModelElement/referencedBy"/> </genClasses> - <genClasses image="false" ecoreClass="base.ecore#//element/IModelElementSpecification"> - <genOperations ecoreOperation="base.ecore#//element/IModelElementSpecification/specificationDescription"/> - </genClasses> + <genClasses image="false" ecoreClass="base.ecore#//element/IModelElementSpecification"/> <genClasses image="false" ecoreClass="base.ecore#//element/IModelElementReference"> <genFeatures notify="false" createChild="false" propertySortChoices="true" ecoreFeature="ecore:EReference base.ecore#//element/IModelElementReference/reference"/> diff --git a/org.fortiss.tooling.base/trunk/src/org/fortiss/tooling/base/utils/ModelElementUtils.java b/org.fortiss.tooling.base/trunk/src/org/fortiss/tooling/base/utils/ModelElementUtils.java index 0929055ef3f4d116031dacaaf251be143fb9601a..2a56ff910a87d4a9e9682f8a53202cd7af4c8aea 100644 --- a/org.fortiss.tooling.base/trunk/src/org/fortiss/tooling/base/utils/ModelElementUtils.java +++ b/org.fortiss.tooling.base/trunk/src/org/fortiss/tooling/base/utils/ModelElementUtils.java @@ -51,27 +51,4 @@ public class ModelElementUtils { } return res; } - - /** - * Returns the {@link IModelElementSpecification#specificationDescription()} - * result for {@code spec}. - * <p> - * If the specification is hidden (instance of {@link IHiddenSpecification}) - * or does not support this operation ( - * {@link IModelElementSpecification#specificationDescription()} throws - * {@link UnsupportedOperationException}) then empty string is returned. - * - */ - public static String specificationDescription( - IModelElementSpecification spec) { - if (spec instanceof IHiddenSpecification) { - // Empty representation for hidden specifications - return ""; - } - try { - return spec.specificationDescription(); - } catch (UnsupportedOperationException e) { - return ""; - } - } } diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/databinding/ObservableUtil.java b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/databinding/ObservableUtil.java index 21ad4547d536569caed05cfb378f4487c9ca9b5f..698f050d3f633cb9be32c14a388b54ff2c0bd62b 100644 --- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/databinding/ObservableUtil.java +++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/databinding/ObservableUtil.java @@ -29,7 +29,7 @@ import org.eclipse.emf.ecore.EStructuralFeature; * @author hummel * @author $Author$ * @version $Rev$ - * @ConQAT.Rating GREEN Hash: 714FEC022718BEA0D783DC7A39A08742 + * @ConQAT.Rating YELLOW Hash: 956DA9605D6EA606250B2B642A1DC34B */ public class ObservableUtil { diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/dnd/ConnectionCompositionDropTargetAdapter.java b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/dnd/ConnectionCompositionDropTargetAdapter.java index 83379ff4f9c35457bf3e0fd8658bf5a522ffbbc7..b9b312e42aa22cb061de4175008c7bd48c5484d7 100644 --- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/dnd/ConnectionCompositionDropTargetAdapter.java +++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/dnd/ConnectionCompositionDropTargetAdapter.java @@ -26,12 +26,13 @@ import org.fortiss.tooling.kernel.service.IConnectionCompositorService; /** * {@link DropTargetAdapter} for completing an EObject connection via a drop - * gesture. + * gesture. If the {@link IConnectionCompositorService} allows the composition + * the {@link DND#DROP_LINK} detail is set as user feedback. * * @author hoelzl * @author $Author$ * @version $Rev$ - * @ConQAT.Rating RED Hash: + * @ConQAT.Rating YELLOW Hash: 25D176E4F450234660A5B6D8C1054832 */ public abstract class ConnectionCompositionDropTargetAdapter extends DropTargetAdapter { diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/dnd/ElementCompositionDropTargetAdapter.java b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/dnd/ElementCompositionDropTargetAdapter.java index 5e1cf2fccf265a6f78fd910623e01d1283b9abe8..6fe4260c5a5f4b085bbf4719c3fa8de790e792e5 100644 --- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/dnd/ElementCompositionDropTargetAdapter.java +++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/dnd/ElementCompositionDropTargetAdapter.java @@ -17,18 +17,57 @@ $Id$ +--------------------------------------------------------------------------*/ package org.fortiss.tooling.kernel.ui.dnd; +import org.eclipse.emf.ecore.EObject; +import org.eclipse.swt.dnd.DND; import org.eclipse.swt.dnd.DropTargetAdapter; +import org.eclipse.swt.dnd.DropTargetEvent; +import org.eclipse.swt.widgets.Widget; +import org.fortiss.tooling.kernel.service.IElementCompositorService; /** * {@link DropTargetAdapter} for completing an EObject composition via a drop - * gesture. + * gesture. If the {@link IElementCompositorService} allows the composition the + * {@link DND#DROP_COPY} detail is set as user feedback. * * @author hoelzl * @author $Author$ * @version $Rev$ - * @ConQAT.Rating RED Hash: + * @ConQAT.Rating YELLOW Hash: 3020F65D1AB62A04863249B2EB016773 */ public abstract class ElementCompositionDropTargetAdapter extends DropTargetAdapter { - // TODO: implement + /** {@inheritDoc} */ + @Override + public void drop(DropTargetEvent event) { + ElementCompositionSource dragSource = getDragSourceFromTransfer(); + EObject target = getTargetModel(event.item); + IElementCompositorService.INSTANCE.compose(target, + dragSource.getDesignatedElement(), null); + } + + /** {@inheritDoc} */ + @Override + public void dragOver(DropTargetEvent event) { + ElementCompositionSource dragSource = getDragSourceFromTransfer(); + EObject target = getTargetModel(event.item); + if (target == null || dragSource.getDesignatedElement() == null) { + event.detail = DND.DROP_NONE; + return; + } + if (IElementCompositorService.INSTANCE.canCompose(target, + dragSource.getDesignatedElement(), null)) { + event.detail = DND.DROP_NONE; + return; + } + event.detail = DND.DROP_COPY; + } + + /** Returns the current target element. */ + protected abstract EObject getTargetModel(Widget dropTarget); + + /** Returns the transfered object. */ + private ElementCompositionSource getDragSourceFromTransfer() { + return (ElementCompositionSource) CompositionServiceLocalTransfer + .getInstance().getObject(); + } } diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/IEditPartFactory.java b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/IEditPartFactory.java index 00884ac2e94c18ec41710e636cc7cfffb0674662..4dc50ab1d2ed1b53563c381fdd64ba50fbdce38c 100644 --- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/IEditPartFactory.java +++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/IEditPartFactory.java @@ -30,14 +30,12 @@ import org.fortiss.tooling.kernel.ui.service.IEditPartFactoryService; * * @see IEditPartFactoryService * - * TODO please document what does T mean ... - * * @author hoelzlf * @author $Author$ * @version $Rev$ - * @ConQAT.Rating RED Hash: 477C29FFFB814DA59E7C475C1ED14CB2 + * @ConQAT.Rating YELLOW Hash: E21D51F62B0AD223BF62913A4E00ED78 */ -public interface IEditPartFactory<T extends EObject> extends IEObjectAware<T>, +public interface IEditPartFactory extends IEObjectAware<EObject>, EditPartFactory { // no special content, inheritance of IEObjectAware and EditPartFactory only } diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/IModelElementHandler.java b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/IModelElementHandler.java index a4305a51f70a928bff450a4da11c9e54a6082ee3..c64127c9cc9fea5d4605b3c55330412585037567 100644 --- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/IModelElementHandler.java +++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/IModelElementHandler.java @@ -38,7 +38,7 @@ import org.fortiss.tooling.kernel.ui.service.IModelElementHandlerService; * @author hoelzl * @author $Author$ * @version $Rev$ - * @ConQAT.Rating GREEN Hash: AF3A9645A41E4DE128D0037D47CF1116 + * @ConQAT.Rating YELLOW Hash: 991B6E327C707A1BB7046234807F5D06 */ public interface IModelElementHandler<T extends EObject> extends IEObjectAware<T> { diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/base/EObjectActionBase.java b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/base/EObjectActionBase.java index 2adc46df502bbb34a1c23fff369a7081263a6f96..815e13f4aeffb17d6d7210c5314fa27487771b66 100644 --- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/base/EObjectActionBase.java +++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/base/EObjectActionBase.java @@ -27,7 +27,7 @@ import org.eclipse.jface.resource.ImageDescriptor; * @author hoelzlf * @author $Author$ * @version $Rev$ - * @ConQAT.Rating GREEN Hash: 827FFC915A61A58BA1E8D6A70D51D197 + * @ConQAT.Rating YELLOW Hash: 05CFD4FE53BA46507F5619DDD7BD47B5 */ public abstract class EObjectActionBase extends Action { diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/base/EditorBase.java b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/base/EditorBase.java index 855e0ad98aaacb1a0f0b81a39e35752d5a7e0433..b0640c158de44f0a3a90be78cb9c16619f1d7642 100644 --- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/base/EditorBase.java +++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/base/EditorBase.java @@ -39,7 +39,7 @@ import org.fortiss.tooling.kernel.ui.internal.editor.ModelElementEditorInput; * @author hoelzlf * @author $Author$ * @version $Rev$ - * @ConQAT.Rating RED Hash: 1F16F778F300E3605E648ABFB4EE1589 + * @ConQAT.Rating YELLOW Hash: 69ECBCA616C4201AF71EB5DAB02705C1 */ public abstract class EditorBase<T extends EObject> extends EditorPart implements IActionContributingEditor, IModelEditor<T> { diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/base/FormsEditorBase.java b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/base/FormsEditorBase.java index fb0a231ca0cd502561a25b44e4750f82a34e35ec..f2083296c7d3a713b79d416b7a5390ac3066e7e7 100644 --- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/base/FormsEditorBase.java +++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/base/FormsEditorBase.java @@ -35,6 +35,8 @@ import org.eclipse.ui.forms.widgets.Section; * @version $Rev: 18709 $ * @ConQAT.Rating RED Hash: */ +// TODO (FH): why is this class here? It does not implement any of the extension +// interfaces. I suggest moving to tooling.base.ui.editor. public abstract class FormsEditorBase<T extends EObject> extends EditorBase<T> { /** Our toolkit. */ diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/base/ModelElementHandlerBase.java b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/base/ModelElementHandlerBase.java index bb279339fef0115e65543da742d9f6364f54691b..c3ac4c698033600dee98a0e231903edd15a76e84 100644 --- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/base/ModelElementHandlerBase.java +++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/base/ModelElementHandlerBase.java @@ -32,10 +32,10 @@ import org.fortiss.tooling.kernel.ui.extension.IModelElementHandler; * the other methods of {@link IModelElementHandler}. By default the base * implementation returns empty lists for the respective methods. * - * @author hoelzlf + * @author hoelzl * @author $Author$ * @version $Rev$ - * @ConQAT.Rating GREEN Hash: C9E97023FA9B79AD5388E3986B4EADFB + * @ConQAT.Rating YELLOW Hash: D840BECB0A8B2398C01EBF945CF2EA0B */ public abstract class ModelElementHandlerBase<T extends EObject> implements IModelElementHandler<T> { diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/base/PropertySectionBase.java b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/base/PropertySectionBase.java index 45f53d68ca03faa09099fdf99cdc4e8d42f5fe67..a46f78abd082cee2865d929a3d4e7fa8916b27a7 100644 --- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/base/PropertySectionBase.java +++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/base/PropertySectionBase.java @@ -49,7 +49,7 @@ import org.fortiss.tooling.kernel.ui.util.DataBindingUtils; * @author hoelzl * @author $Author$ * @version $Rev$ - * @ConQAT.Rating GREEN Hash: B0BDB66957F0952332543C419C83D83A + * @ConQAT.Rating YELLOW Hash: C933211F21A9E76CBE2281807031C684 */ public abstract class PropertySectionBase extends AbstractPropertySection { diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/base/TableViewerBase.java b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/base/TableViewerBase.java index c1a218be08739d8843a26ff9fa44acc2a5789b13..c382a8660f5470400da37af7485c8d85c8274fb1 100644 --- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/base/TableViewerBase.java +++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/base/TableViewerBase.java @@ -37,6 +37,8 @@ import org.eclipse.swt.widgets.Table; * @version $Rev: 18709 $ * @ConQAT.Rating RED Hash: */ +// TODO (FH): why is this class here? It does not implement any of the extension +// interfaces. I suggest moving to tooling.base.ui.editor. public abstract class TableViewerBase implements IStructuredContentProvider { /** Compares content objects. */ diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/editingsupport/AbstractDecoratedTextCellDatabindingEditingSupport.java b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/editingsupport/AbstractDecoratedTextCellDatabindingEditingSupport.java index 5cc67979fdc06291c2395ab5d6b146397267881f..2c89c70ddaa31e2242e09bc76ffb3ff294a7c69b 100644 --- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/editingsupport/AbstractDecoratedTextCellDatabindingEditingSupport.java +++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/editingsupport/AbstractDecoratedTextCellDatabindingEditingSupport.java @@ -42,6 +42,8 @@ import org.fortiss.tooling.kernel.ui.util.DataBindingUtils; * @version $Rev: 1670 $ * @levd.rating RED Rev: */ +// TODO (FH): why is this class here? It is not used by the kernel. I suggest +// moving to tooling.base.ui. somewhere. public abstract class AbstractDecoratedTextCellDatabindingEditingSupport extends AbstractTextCellDatabindingEditingSupport { diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/editingsupport/AbstractTextCellDatabindingEditingSupport.java b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/editingsupport/AbstractTextCellDatabindingEditingSupport.java index 20c2615bcb70903cd826e879f87642808c7c3ed0..9c3a081d36fbf3605c87ce1a0c0ea290b5c1eddf 100644 --- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/editingsupport/AbstractTextCellDatabindingEditingSupport.java +++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/editingsupport/AbstractTextCellDatabindingEditingSupport.java @@ -40,6 +40,8 @@ import org.fortiss.tooling.kernel.ui.util.DataBindingUtils; * @version $Rev: 5848 $ * @levd.rating RED Rev: */ +// TODO (FH): why is this class here? It is not used by the kernel. I suggest +// moving to tooling.base.ui. somewhere. public abstract class AbstractTextCellDatabindingEditingSupport extends EditingSupport { diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/EditPartFactoryService.java b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/EditPartFactoryService.java index 211e11af157be0bd2c08eb9d291f4aac17bce6fc..fdc4f6f40d705c7adb0cd6d764dafeff247571c5 100644 --- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/EditPartFactoryService.java +++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/EditPartFactoryService.java @@ -33,10 +33,10 @@ import org.fortiss.tooling.kernel.utils.LoggingUtils; * @author hoelzl * @author $Author$ * @version $Rev$ - * @ConQAT.Rating GREEN Hash: 17D10EA950086B85B549633CA53C083A + * @ConQAT.Rating YELLOW Hash: 55C10AF733339903A2B44E37978F6236 */ public class EditPartFactoryService extends - EObjectAwareServiceBase<IEditPartFactory<EObject>> implements + EObjectAwareServiceBase<IEditPartFactory> implements IEditPartFactoryService { /** The prototype provider extension point ID. */ @@ -60,14 +60,14 @@ public class EditPartFactoryService extends } Class<? extends EObject> clazz = ((EObject) modelElement).getClass(); - List<IEditPartFactory<EObject>> factories = getRegisteredHandlers(clazz); + List<IEditPartFactory> factories = getRegisteredHandlers(clazz); if (factories == null || factories.isEmpty()) { LoggingUtils.error(ToolingKernelUIActivator.getDefault(), "No editpart factory registered for " + clazz.getName()); return null; } - for (IEditPartFactory<EObject> factory : factories) { + for (IEditPartFactory factory : factories) { EditPart part = factory.createEditPart(context, modelElement); if (part != null) { return part; diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/NavigatorService.java b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/NavigatorService.java index 70f481b9917aad6574f03e731fae9099e990e604..ebb6705e2d0a0354ef960d04459212c1760d13e7 100644 --- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/NavigatorService.java +++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/NavigatorService.java @@ -51,7 +51,7 @@ import org.fortiss.tooling.kernel.ui.service.INavigatorService; * @author hoelzl * @author $Author$ * @version $Rev$ - * @ConQAT.Rating YELLOW Hash: DD2F69B5A93CC7141A35F54A7DFEE24C + * @ConQAT.Rating YELLOW Hash: 4F5F0E2A4F15CF1D73C839739FEB2B40 */ public class NavigatorService implements INavigatorService, IPersistencyServiceListener, CommandStackListener { diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/editor/ExtendableMultiPageEditor.java b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/editor/ExtendableMultiPageEditor.java index 5d099560bafb77b8088ca627d4db09ee6374b7a6..f782257050939f60e6ff14e1ec26ef026e84e71e 100644 --- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/editor/ExtendableMultiPageEditor.java +++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/editor/ExtendableMultiPageEditor.java @@ -22,7 +22,6 @@ import java.util.EventObject; import org.conqat.ide.commons.ui.logging.LoggingUtils; import org.conqat.lib.commons.collections.IdentityHashSet; -import org.eclipse.core.resources.IMarker; import org.eclipse.core.runtime.IProgressMonitor; import org.eclipse.emf.common.command.CommandStackListener; import org.eclipse.emf.common.notify.Adapter; @@ -54,10 +53,10 @@ import org.fortiss.tooling.kernel.ui.util.PropertiesConstantUtils; * This editor is used for displaying multiple editors provided by editor * bindings for a given model element. * - * @author hoelzlf + * @author hoelzl * @author $Author$ * @version $Rev$ - * @ConQAT.Rating YELLOW Hash: E679E55F39BBC5B00B721E3DF7CC40F3 + * @ConQAT.Rating YELLOW Hash: 0B57445422EF2CD24F6E8B877E3E938B */ public class ExtendableMultiPageEditor extends MultiPageEditorPart implements ITabbedPropertySheetPageContributor, CommandStackListener, @@ -248,13 +247,6 @@ public class ExtendableMultiPageEditor extends MultiPageEditorPart implements return super.getAdapter(adapter); } - /** - * TODO: COMMENT ME - */ - public void gotoMarker(@SuppressWarnings("unused") IMarker marker) { - // TODO (FH): implement marker goto - } - /** {@inheritDoc} */ @Override public void commandStackChanged(EventObject event) { diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/views/LibraryView.java b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/views/LibraryView.java index e3a4a40477ce581c2e8460b780e05ee737ac5e10..8b0fb53bee9efdc74655bbacfc2c073b4f7616e1 100644 --- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/views/LibraryView.java +++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/views/LibraryView.java @@ -47,10 +47,11 @@ import org.fortiss.tooling.kernel.ui.service.IModelElementHandlerService; /** * {@link ViewPart} for the model element library view. * + * @author hoelzl * @author eder * @author $Author: hoelzl $ * @version $Rev: 18709 $ - * @ConQAT.Rating YELLOW Hash: 0587D3490BC7C280A72CDC1D642FB53D + * @ConQAT.Rating YELLOW Hash: B8AFFA79B7361802ADF8DBD293D2D33C */ public class LibraryView extends ViewPart { diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/views/NavigatorTreeContentProvider.java b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/views/NavigatorTreeContentProvider.java index e12e42891b54f158602e4bda1474b17d93d7fa96..6b90845a09f5d2ec5436174663732b73debf44cc 100644 --- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/views/NavigatorTreeContentProvider.java +++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/views/NavigatorTreeContentProvider.java @@ -35,7 +35,7 @@ import org.fortiss.tooling.kernel.ui.service.IModelElementHandlerService; * @author hoelzlf * @author $Author$ * @version $Rev$ - * @ConQAT.Rating GREEN Hash: A7B15797EF2C608B1405E9CECA4E4B02 + * @ConQAT.Rating YELLOW Hash: CDDE2896CE2940FA7D5F6B401754457F */ public class NavigatorTreeContentProvider implements ITreeContentProvider { diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/views/NavigatorViewPart.java b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/views/NavigatorViewPart.java index 35ac297c8179a6a846703e84604ecad603f2ed30..963980e307328023e1a263d4b0502b69e266acc3 100644 --- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/views/NavigatorViewPart.java +++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/views/NavigatorViewPart.java @@ -72,7 +72,7 @@ import org.fortiss.tooling.kernel.ui.util.PropertiesConstantUtils; * @author hoelzlf * @author $Author$ * @version $Rev$ - * @ConQAT.Rating RED Hash: 07C7E317D08A33F1390AA582B92EA185 + * @ConQAT.Rating YELLOW Hash: DF0FC35AF4CAD5F2A6D39582A83C92CB */ public final class NavigatorViewPart extends ViewPart implements ISelectionListener, ISelectionChangedListener, IDoubleClickListener, @@ -246,7 +246,6 @@ public final class NavigatorViewPart extends ViewPart implements @Override public void selectionChanged(IWorkbenchPart part, ISelection selection) { IActionService.INSTANCE.refresh(); - // TODO (FH): implement link with editor feature here } /** {@inheritDoc} */