From 2cc9b70175b2813733b37126d5fec0002cf70a10 Mon Sep 17 00:00:00 2001
From: Daniel Ratiu <ratiu@fortiss.org>
Date: Wed, 6 Jul 2011 11:00:49 +0000
Subject: [PATCH] another code review iteration is performed
---
.../tooling/kernel/ui/ToolingKernelUIActivator.java | 2 +-
.../src/org/fortiss/tooling/kernel/ui/base/package.html | 2 +-
.../kernel/ui/interfaces/IActionContributingEditor.java | 2 +-
.../ui/interfaces/IBindingEditorPageChangeListener.java | 2 +-
.../kernel/ui/interfaces/ICustomMenuContributor.java | 2 +-
.../tooling/kernel/ui/interfaces/IEditPartFactory.java | 2 +-
.../org/fortiss/tooling/kernel/ui/interfaces/package.html | 1 +
.../tooling/kernel/ui/internal/EditPartFactoryService.java | 2 +-
.../tooling/kernel/ui/internal/ModelElementService.java | 2 +-
.../tooling/kernel/ui/internal/NavigatorService.java | 2 +-
.../tooling/kernel/ui/internal/PropertiesService.java | 2 +-
.../kernel/ui/internal/editor/BindingContributor.java | 4 +++-
.../tooling/kernel/ui/internal/editor/BindingEditor.java | 3 +++
.../kernel/ui/internal/editor/ModelElementEditorInput.java | 2 +-
.../fortiss/tooling/kernel/ui/internal/editor/package.html | 2 +-
.../org/fortiss/tooling/kernel/ui/internal/package.html | 2 +-
.../ui/internal/properties/IdLabeledPropertySection.java | 2 +-
.../internal/properties/NamedCommentedPropertySection.java | 2 +-
.../ui/internal/properties/PropertiesAdapterFactory.java | 2 +-
.../tooling/kernel/ui/internal/properties/package.html | 2 +-
.../ui/internal/views/EObjectDragSourceListener.java | 2 +-
.../tooling/kernel/ui/internal/views/LibraryView.java | 2 +-
.../ui/internal/views/NavigatorTreeContentProvider.java | 2 +-
.../ui/internal/views/NavigatorTreeLabelProvider.java | 2 +-
.../kernel/ui/internal/views/NavigatorViewPart.java | 3 +++
.../fortiss/tooling/kernel/ui/internal/views/NewMenu.java | 7 +++++--
.../fortiss/tooling/kernel/ui/internal/views/package.html | 2 +-
.../trunk/src/org/fortiss/tooling/kernel/ui/package.html | 2 +-
.../fortiss/tooling/kernel/ui/services/IActionService.java | 2 +-
.../kernel/ui/services/IEditPartFactoryService.java | 2 +-
.../fortiss/tooling/kernel/ui/services/IEditorService.java | 2 +-
.../tooling/kernel/ui/services/IModelElementService.java | 3 +++
.../tooling/kernel/ui/services/INavigatorService.java | 2 +-
.../tooling/kernel/ui/services/IPropertiesService.java | 2 +-
.../org/fortiss/tooling/kernel/ui/services/package.html | 4 ++--
.../fortiss/tooling/kernel/ui/util/DataBindingUtils.java | 2 +-
.../fortiss/tooling/kernel/ui/util/DragAndDropUtils.java | 2 +-
.../tooling/kernel/ui/util/EObjectSelectionUtils.java | 2 +-
.../src/org/fortiss/tooling/kernel/ui/util/package.html | 2 +-
39 files changed, 52 insertions(+), 37 deletions(-)
diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/ToolingKernelUIActivator.java b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/ToolingKernelUIActivator.java
index fe25e4a2f..c546de5c5 100644
--- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/ToolingKernelUIActivator.java
+++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/ToolingKernelUIActivator.java
@@ -27,7 +27,7 @@ import org.osgi.framework.BundleContext;
* @author hoelzl
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: 1BDD065B5C8C0E977D45B5BB2D6AD704
+ * @ConQAT.Rating GREEN Hash: 5821A4A0D157C68F2D26739DAD86CA9A
*/
public class ToolingKernelUIActivator extends AbstractUIPlugin {
diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/base/package.html b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/base/package.html
index f4bff6e1a..96c9ae870 100644
--- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/base/package.html
+++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/base/package.html
@@ -1,7 +1,7 @@
<!--
$Id$
@version $Rev$
- @ConQAT.Rating YELLOW Hash: 8DA8330C731AF1130EEDFAF1CAE4CE2E
+ @ConQAT.Rating GREEN Hash: B7912AFB4649A41D402C92E20A4A7412
-->
<body>
Abstract base implementations for the kernel UI extensions.
diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/interfaces/IActionContributingEditor.java b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/interfaces/IActionContributingEditor.java
index 21419cc6c..79e70d666 100644
--- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/interfaces/IActionContributingEditor.java
+++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/interfaces/IActionContributingEditor.java
@@ -27,7 +27,7 @@ import org.fortiss.tooling.kernel.ui.internal.editor.BindingContributor;
* @author hoelzl
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: 4644FCF70CA34FD1D20CFB174FD4E4A4
+ * @ConQAT.Rating GREEN Hash: E446C6AAF3BA8D6D004F10F3936EAD75
*/
public interface IActionContributingEditor {
/**
diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/interfaces/IBindingEditorPageChangeListener.java b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/interfaces/IBindingEditorPageChangeListener.java
index 41062a938..549640eaa 100644
--- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/interfaces/IBindingEditorPageChangeListener.java
+++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/interfaces/IBindingEditorPageChangeListener.java
@@ -25,7 +25,7 @@ import org.fortiss.tooling.kernel.ui.internal.editor.BindingEditor;
* @author hoelzl
* @author $Author: hoelzl $
* @version $Rev: 18709 $
- * @ConQAT.Rating YELLOW Hash: 31B6B4FCCD19160ADF8A9ACBD31B3E9B
+ * @ConQAT.Rating GREEN Hash: 912F8EC4536E910BB229CF9867FA0A63
*/
public interface IBindingEditorPageChangeListener {
diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/interfaces/ICustomMenuContributor.java b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/interfaces/ICustomMenuContributor.java
index 873d480d9..bb8ceec79 100644
--- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/interfaces/ICustomMenuContributor.java
+++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/interfaces/ICustomMenuContributor.java
@@ -29,7 +29,7 @@ import org.fortiss.tooling.kernel.ui.services.IContextMenuService;
* @author hoelzlf
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: 08A60D2BBA490E7EBB63F2F6B02983C9
+ * @ConQAT.Rating GREEN Hash: 38606F3B8E5D282EEB2669C7C458110B
*/
public interface ICustomMenuContributor {
diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/interfaces/IEditPartFactory.java b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/interfaces/IEditPartFactory.java
index 2e32d5db3..1406c29f1 100644
--- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/interfaces/IEditPartFactory.java
+++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/interfaces/IEditPartFactory.java
@@ -30,7 +30,7 @@ import org.fortiss.tooling.kernel.interfaces.IEObjectAware;
* @author hoelzlf
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: E20E3FBA08256173AF0B9538151BB880
+ * @ConQAT.Rating GREEN Hash: 92C6AEF3682C444DF19067D99C1071F0
*/
public interface IEditPartFactory<T extends EObject> extends IEObjectAware<T>,
EditPartFactory {
diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/interfaces/package.html b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/interfaces/package.html
index 20cfa27d2..67ec20388 100644
--- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/interfaces/package.html
+++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/interfaces/package.html
@@ -5,4 +5,5 @@
-->
<body>
Interface definitions for extension classes of kernel UI extension points.
+@TODO: are all these interfaces corresponding to an extension point?
</body>
diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/EditPartFactoryService.java b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/EditPartFactoryService.java
index 88f5ac52c..7a5d8dd84 100644
--- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/EditPartFactoryService.java
+++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/EditPartFactoryService.java
@@ -34,7 +34,7 @@ import org.fortiss.tooling.kernel.util.LoggingUtils;
* @author hoelzl
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: F3AF21797C779669598761DD4854D145
+ * @ConQAT.Rating GREEN Hash: 8779DDD08371F49DCFB04FF0515A5349
*/
public class EditPartFactoryService extends
EObjectAwareServiceBase<IEditPartFactory<EObject>> implements
diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/ModelElementService.java b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/ModelElementService.java
index a11d78054..6db19ee70 100644
--- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/ModelElementService.java
+++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/ModelElementService.java
@@ -33,7 +33,7 @@ import org.fortiss.tooling.kernel.ui.services.IModelElementService;
* @author hoelzl
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: 9D99C615FF981BE0831593DC3600D498
+ * @ConQAT.Rating GREEN Hash: F9743B1AB08AF0404BB9B421F8103BC3
*/
public class ModelElementService extends
EObjectAwareServiceBase<IModelElementHandler<EObject>> implements
diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/NavigatorService.java b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/NavigatorService.java
index e2e6ab6b5..de3f0496f 100644
--- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/NavigatorService.java
+++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/NavigatorService.java
@@ -46,7 +46,7 @@ import org.fortiss.tooling.kernel.ui.util.EObjectSelectionUtils;
* @author hoelzl
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: FB5662C65C21DF94B8E8D3C1F25DC679
+ * @ConQAT.Rating GREEN Hash: 49F7CC4408BA44565132406035534C8A
*/
public class NavigatorService implements INavigatorService,
ITopLevelElementChangeListener, CommandStackListener {
diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/PropertiesService.java b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/PropertiesService.java
index 6480e05a1..ac9f11ded 100644
--- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/PropertiesService.java
+++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/PropertiesService.java
@@ -25,7 +25,7 @@ import org.fortiss.tooling.kernel.ui.services.IPropertiesService;
* @author hoelzl
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: 37CDABB5D03E1D2F534D83EB55855351
+ * @ConQAT.Rating GREEN Hash: F8F54E850FEB15FACC2A9CE2CF8354AB
*
*/
public class PropertiesService implements IPropertiesService {
diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/editor/BindingContributor.java b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/editor/BindingContributor.java
index 643933338..e1937dc1e 100644
--- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/editor/BindingContributor.java
+++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/editor/BindingContributor.java
@@ -31,7 +31,7 @@ import org.fortiss.tooling.kernel.ui.services.IActionService;
* @author hoelzl
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: C7051BC810281AFB5BA9B19154724151
+ * @ConQAT.Rating GREEN Hash: B6C60CD2A8A605CD9533DBF968D06721
*/
public final class BindingContributor extends
MultiPageEditorActionBarContributor {
@@ -46,6 +46,8 @@ public final class BindingContributor extends
*/
@Override
public void setActiveEditor(IEditorPart part) {
+ // TODO: the text message from below is false - we do not have CCTS
+ // anymore
CCSMPre.isTrue(part instanceof BindingEditor,
"This contributor may only be used for CCTSBindingEditors!");
IActionService.INSTANCE.registerGlobalActions(getActionBars());
diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/editor/BindingEditor.java b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/editor/BindingEditor.java
index 7a73db432..f755ed1c8 100644
--- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/editor/BindingEditor.java
+++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/editor/BindingEditor.java
@@ -46,6 +46,9 @@ import org.fortiss.tooling.kernel.ui.services.IPropertiesService;
* This editor is used for displaying multiple editors provided by editor
* bindings for a given model element.
*
+ * TODO: the name "Binding" is unintuitive to me. + is there a link to
+ * IEditorBinding?
+ *
* @author hoelzlf
* @author $Author$
* @version $Rev$
diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/editor/ModelElementEditorInput.java b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/editor/ModelElementEditorInput.java
index 3d2fe1f97..1bf2c9983 100644
--- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/editor/ModelElementEditorInput.java
+++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/editor/ModelElementEditorInput.java
@@ -30,7 +30,7 @@ import org.fortiss.tooling.kernel.ui.services.IModelElementService;
* @author hoelzlf
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: 97D91D2A7C2890305CC4A990F1A5FBC1
+ * @ConQAT.Rating GREEN Hash: 5F6A0DEC72D481619982ECF12E160595
*/
public final class ModelElementEditorInput implements IEditorInput {
diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/editor/package.html b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/editor/package.html
index 37b28f82c..507726715 100644
--- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/editor/package.html
+++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/editor/package.html
@@ -1,7 +1,7 @@
<!--
$Id$
@version $Rev$
- @ConQAT.Rating YELLOW Hash: 99E18C3CEA9C878B34F6AE4CC04AD9DE
+ @ConQAT.Rating GREEN Hash: F14CE26F84629DFAA80E133DBE28A5E8
-->
<body>
Implementations of the multi-page binding editor provided by the kernel user-interface.
diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/package.html b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/package.html
index 15d6b0148..c3048844f 100644
--- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/package.html
+++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/package.html
@@ -1,7 +1,7 @@
<!--
$Id$
@version $Rev$
- @ConQAT.Rating YELLOW Hash: DEE82E65C55976C18489848C51FF6CCB
+ @ConQAT.Rating GREEN Hash: F83081A294B439073D0B6C695C634349
-->
<body>
Implementations of the user-interface kernel services defined in the <code>kernel.ui.services</code> package.
diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/properties/IdLabeledPropertySection.java b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/properties/IdLabeledPropertySection.java
index c81631d28..663a90a9b 100644
--- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/properties/IdLabeledPropertySection.java
+++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/properties/IdLabeledPropertySection.java
@@ -34,7 +34,7 @@ import org.fortiss.tooling.kernel.ui.databinding.Observables;
* @author hoelzl
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: AAF40E2ED1B53B1E58814F6BB5A710D4
+ * @ConQAT.Rating GREEN Hash: 73C7C020F3B07C168D20AB9711428AB2
*/
public class IdLabeledPropertySection extends PropertySectionBase {
diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/properties/NamedCommentedPropertySection.java b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/properties/NamedCommentedPropertySection.java
index 7b96eb915..7d00ab29a 100644
--- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/properties/NamedCommentedPropertySection.java
+++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/properties/NamedCommentedPropertySection.java
@@ -34,7 +34,7 @@ import org.fortiss.tooling.kernel.ui.databinding.Observables;
* @author ratiu
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: 94D36327BAB4EA717EA2163D820B9194
+ * @ConQAT.Rating GREEN Hash: 5390821E87E9BDA0439B8B19B33AB08F
*/
public class NamedCommentedPropertySection extends PropertySectionBase {
diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/properties/PropertiesAdapterFactory.java b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/properties/PropertiesAdapterFactory.java
index 78bc8c041..6f457dc97 100644
--- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/properties/PropertiesAdapterFactory.java
+++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/properties/PropertiesAdapterFactory.java
@@ -29,7 +29,7 @@ import org.fortiss.tooling.kernel.ui.services.IPropertiesService;
* @author hoelzl
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: 0CB9AF7EAB134DF256A41CEDF2C4FE44
+ * @ConQAT.Rating GREEN Hash: 25908F042E789FA56F43A853A8B1973B
*/
@SuppressWarnings("rawtypes")
public final class PropertiesAdapterFactory implements IAdapterFactory {
diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/properties/package.html b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/properties/package.html
index f2b670618..0a48d5dd6 100644
--- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/properties/package.html
+++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/properties/package.html
@@ -1,7 +1,7 @@
<!--
$Id$
@version $Rev$
- @ConQAT.Rating YELLOW Hash: 931E710E39C8E7200A075D99678564FF
+ @ConQAT.Rating GREEN Hash: 5D4ABF80310EC18886A1F3E311843798
-->
<body>
Implementations of the default property sections provided by the kernel.
diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/views/EObjectDragSourceListener.java b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/views/EObjectDragSourceListener.java
index 2f343ebb9..832a06f67 100644
--- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/views/EObjectDragSourceListener.java
+++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/views/EObjectDragSourceListener.java
@@ -29,7 +29,7 @@ import org.eclipse.swt.dnd.DragSourceEvent;
* @author eder
* @author $Author: hoelzl $
* @version $Rev: 18709 $
- * @ConQAT.Rating YELLOW Hash: 7274445CF4D8976F98D2261373206375
+ * @ConQAT.Rating GREEN Hash: E21E2799DA5A521B7B102FCF933556F5
*/
public class EObjectDragSourceListener extends DragSourceAdapter {
diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/views/LibraryView.java b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/views/LibraryView.java
index 9abb49749..0cea91afc 100644
--- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/views/LibraryView.java
+++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/views/LibraryView.java
@@ -53,7 +53,7 @@ import org.fortiss.tooling.kernel.ui.services.IModelElementService;
* @author eder
* @author $Author: hoelzl $
* @version $Rev: 18709 $
- * @ConQAT.Rating YELLOW Hash: D385105D51E1CFDED0B8FF4E855A2B94
+ * @ConQAT.Rating GREEN Hash: BE7BE3DF4D235818552B6BAD3CED5CB0
*/
public class LibraryView extends ViewPart {
diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/views/NavigatorTreeContentProvider.java b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/views/NavigatorTreeContentProvider.java
index 68dca8dff..74437c1e4 100644
--- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/views/NavigatorTreeContentProvider.java
+++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/views/NavigatorTreeContentProvider.java
@@ -34,7 +34,7 @@ import org.fortiss.tooling.kernel.ui.services.IModelElementService;
* @author hoelzlf
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: B99F9C3252CFF2333B31E7075D035057
+ * @ConQAT.Rating GREEN Hash: 153C112080D4CC28DFB6D64190846CEA
*/
public class NavigatorTreeContentProvider implements ITreeContentProvider {
diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/views/NavigatorTreeLabelProvider.java b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/views/NavigatorTreeLabelProvider.java
index 0fbbed6b2..b6f85f829 100644
--- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/views/NavigatorTreeLabelProvider.java
+++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/views/NavigatorTreeLabelProvider.java
@@ -30,7 +30,7 @@ import org.fortiss.tooling.kernel.ui.services.IModelElementService;
* @author hoelzlf
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: 576FB18EB32B79705C9E03CB910F68CB
+ * @ConQAT.Rating GREEN Hash: ADCF367C35F16C4D1ECB25BC16DE088E
*/
public final class NavigatorTreeLabelProvider extends BaseLabelProvider
implements ILabelProvider {
diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/views/NavigatorViewPart.java b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/views/NavigatorViewPart.java
index acdd22a25..b35e73ae4 100644
--- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/views/NavigatorViewPart.java
+++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/views/NavigatorViewPart.java
@@ -147,6 +147,9 @@ public final class NavigatorViewPart extends ViewPart implements
.getActionBars());
createLinkWithEditorAction();
+ // TODO: the "magic chains" like
+ // "PlatformUI.getWorkbench().getActiveWorkbenchWindow()"
+ // are good candidates to be part of utility classes
PlatformUI.getWorkbench().getActiveWorkbenchWindow()
.getSelectionService().addSelectionListener(this);
diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/views/NewMenu.java b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/views/NewMenu.java
index 66b1f956a..77cc8bf2d 100644
--- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/views/NewMenu.java
+++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/views/NewMenu.java
@@ -35,6 +35,9 @@ import org.fortiss.tooling.kernel.ui.util.EObjectSelectionUtils;
/**
* The contributor for the dynamic new menu based on composition.
*
+ * TODO: package name from the copyright comment "edu.tum.cs.ccts.model.base" is
+ * outdated.
+ *
* @author hoelzlf
* @author $Author$
* @version $Rev$
@@ -105,8 +108,8 @@ public class NewMenu extends CompoundContributionItem {
@Override
public void run() {
EObject newObject = prototype.getPrototypeCopy();
- if (IElementCompositorService.INSTANCE.compose(container,
- newObject, null)) {
+ if (IElementCompositorService.INSTANCE.compose(
+ container, newObject, null)) {
IEditorService.INSTANCE.openInEditor(newObject);
}
}
diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/views/package.html b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/views/package.html
index 88708632e..0420eb008 100644
--- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/views/package.html
+++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/views/package.html
@@ -1,7 +1,7 @@
<!--
$Id$
@version $Rev$
- @ConQAT.Rating YELLOW Hash: 527D9BF51495443E95F62CF8C27B4AA8
+ @ConQAT.Rating GREEN Hash: 198A5F9B0AFF625D7F74C572F760E0B0
-->
<body>
Implementations of the navigator and model element library view.
diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/package.html b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/package.html
index 83b720084..ab19c9f92 100644
--- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/package.html
+++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/package.html
@@ -1,7 +1,7 @@
<!--
$Id$
@version $Rev$
- @ConQAT.Rating YELLOW Hash: 0105A489AFAD9D13B3E1D45D150E7818
+ @ConQAT.Rating GREEN Hash: 0DE01A78A3A55B1500DEA7D846AED2BB
-->
<body>
Main plugin package for fortiss tooling kernel user-interface.
diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/services/IActionService.java b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/services/IActionService.java
index ae6a8d302..39b4066ec 100644
--- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/services/IActionService.java
+++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/services/IActionService.java
@@ -28,7 +28,7 @@ import org.fortiss.tooling.kernel.ui.internal.ActionService;
* @author hoelzl
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: 2B3895F36532E6A497B12746C07D91D8
+ * @ConQAT.Rating GREEN Hash: D76C66B8F522789D7C16221291D8D389
*/
public interface IActionService {
diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/services/IEditPartFactoryService.java b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/services/IEditPartFactoryService.java
index 26399f0dd..df1b184a5 100644
--- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/services/IEditPartFactoryService.java
+++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/services/IEditPartFactoryService.java
@@ -29,7 +29,7 @@ import org.fortiss.tooling.kernel.ui.internal.EditPartFactoryService;
* @author hoelzl
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: 465A71657359ABBCD0BE5F70815436B1
+ * @ConQAT.Rating GREEN Hash: 2E7D6A7BEE050894ABDAE02CD4BC95FD
*/
public interface IEditPartFactoryService extends EditPartFactory {
diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/services/IEditorService.java b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/services/IEditorService.java
index 562f6893a..5f0d44252 100644
--- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/services/IEditorService.java
+++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/services/IEditorService.java
@@ -32,7 +32,7 @@ import org.fortiss.tooling.kernel.ui.internal.EditorService;
* @author hoelzl
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: ECCFA2C956D54381EC206F79876D8BC1
+ * @ConQAT.Rating GREEN Hash: 9A727CA1B177F99AD5448AF5223713CE
*/
public interface IEditorService {
diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/services/IModelElementService.java b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/services/IModelElementService.java
index c178e91d0..0652fbff0 100644
--- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/services/IModelElementService.java
+++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/services/IModelElementService.java
@@ -25,6 +25,9 @@ import org.fortiss.tooling.kernel.ui.internal.ModelElementService;
* The model context service provides information about registered model
* elements.
*
+ * TODO is the above line ok? "The model context service" ->
+ * "The model element service"? TODO where are the elements registered?
+ *
* @see IModelElementHandler
*
* @author hoelzl
diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/services/INavigatorService.java b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/services/INavigatorService.java
index 92092efbe..863c266f1 100644
--- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/services/INavigatorService.java
+++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/services/INavigatorService.java
@@ -35,7 +35,7 @@ import org.fortiss.tooling.kernel.ui.internal.NavigatorService;
* @author hoelzl
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: 66B5DD3650C883C2E70023247D11A811
+ * @ConQAT.Rating GREEN Hash: 42753D9AF5F66074E37F6F1C9A5587F6
*/
public interface INavigatorService {
/** Returns the singleton instance of the service. */
diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/services/IPropertiesService.java b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/services/IPropertiesService.java
index c33f17c28..5964a66c6 100644
--- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/services/IPropertiesService.java
+++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/services/IPropertiesService.java
@@ -41,7 +41,7 @@ import org.fortiss.tooling.kernel.ui.internal.PropertiesService;
* @author hoelzl
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: 2A09E8B8BA89FFD035F4D9AE28DCE6AA
+ * @ConQAT.Rating GREEN Hash: 8844965F80E0B2B5EC5E652DCA614246
*/
public interface IPropertiesService {
diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/services/package.html b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/services/package.html
index b9a3c3bc4..118c7997a 100644
--- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/services/package.html
+++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/services/package.html
@@ -1,10 +1,10 @@
<!--
$Id$
@version $Rev$
- @ConQAT.Rating YELLOW Hash: 3B94D166F87E14036D796F029CBD8668
+ @ConQAT.Rating GREEN Hash: D0AEC7D22C9850BA730348BFF845F594
-->
<body>
Interface definitions of the kernel UI services. Each interface corresponds to a certain functionality of the user-interface part of the kernel.
Some of the services provide extension points. Extension implementors should refer to the <code>kernel.ui.interfaces</code>
-and <code>kernel.ui.base</code>m packages. Kernel services are implemented by classes from the <code>kernel.ui.internal.services</code> package.
+and <code>kernel.ui.base</code> packages. Kernel services are implemented by classes from the <code>kernel.ui.internal.services</code> package.
</body>
diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/util/DataBindingUtils.java b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/util/DataBindingUtils.java
index a02ae72f9..4e928820e 100644
--- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/util/DataBindingUtils.java
+++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/util/DataBindingUtils.java
@@ -35,7 +35,7 @@ import org.eclipse.swt.widgets.Control;
* @author hoelzl
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: 646DA3B438CB4A6FCF6D7740388C0373
+ * @ConQAT.Rating GREEN Hash: 1AA4C5FB4C31B3AEDFC4627BFCA48F02
*/
public final class DataBindingUtils {
diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/util/DragAndDropUtils.java b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/util/DragAndDropUtils.java
index 2678dcc63..47d520ccf 100644
--- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/util/DragAndDropUtils.java
+++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/util/DragAndDropUtils.java
@@ -27,7 +27,7 @@ import org.fortiss.tooling.kernel.services.IPrototypeService.Prototype;
* @author hoelzl
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: 338194B154464E27FA65CDCD72CE7439
+ * @ConQAT.Rating GREEN Hash: DC84E260F9545A3D493A8A732C131495
*/
public final class DragAndDropUtils {
diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/util/EObjectSelectionUtils.java b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/util/EObjectSelectionUtils.java
index 112b75cb7..3c8890166 100644
--- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/util/EObjectSelectionUtils.java
+++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/util/EObjectSelectionUtils.java
@@ -33,7 +33,7 @@ import org.eclipse.ui.PlatformUI;
* @author hoelzl
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: C89BCA60DC06B35E1946C57DD21D8769
+ * @ConQAT.Rating GREEN Hash: A8D571A5DA7E4057916EA1DD96006069
*/
public final class EObjectSelectionUtils {
diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/util/package.html b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/util/package.html
index c58dcfa66..938ba0107 100644
--- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/util/package.html
+++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/util/package.html
@@ -1,7 +1,7 @@
<!--
$Id$
@version $Rev$
- @ConQAT.Rating YELLOW Hash: E4E985E2A87DF1B3EEA0438D26921D62
+ @ConQAT.Rating GREEN Hash: DEFFB68B2947CAE93354983FBBF37AD5
-->
<body>
Utility methods provided by the user-interface part of the kernel.
--
GitLab