From 2d266ba2a052a7d048b670bb1d88c1959c8b8ae7 Mon Sep 17 00:00:00 2001
From: Simon Barner <barner@fortiss.org>
Date: Tue, 13 Mar 2018 16:20:06 +0000
Subject: [PATCH] RED
---
.../org/fortiss/tooling/kernel/ui/extension/base/.ratings | 2 +-
.../kernel/ui/extension/base/ModelElementHandlerBase.java | 5 +++--
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/base/.ratings b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/base/.ratings
index d6e82f8ab..ee78daa6f 100644
--- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/base/.ratings
+++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/base/.ratings
@@ -4,7 +4,7 @@ EObjectActionBase.java 67c307ac15d7f45ad970ab1df42f4729fee09518 GREEN
EReferencePropertySectionBase.java d4cce5af54efc59b33415a34d5130ab8952d60ce GREEN
EditorBase.java 3af0350a488adf676d5b5e5ccad2087fb97c3d5b GREEN
ModelEditorBindingBase.java 12f6323750cde28cefa99c1ec9d45191c8779109 GREEN
-ModelElementHandlerBase.java 56590eab74170f91e2760ec5d44d2653667f1f94 YELLOW
+ModelElementHandlerBase.java 8892ae7b43495a2c7bc1dde16cb433860f5214bc RED
MultiEObjectActionBase.java ab9170f3918a069fa2a3aabae0436618317fa7b8 GREEN
NamedCommentedModelElementHandlerBase.java 8f9cb1e750afb577f528d330165a9f377e23aa8b GREEN
PropertySectionBase.java f8e2cf4444ab4808ac8c45b65840619b367ba112 GREEN
diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/base/ModelElementHandlerBase.java b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/base/ModelElementHandlerBase.java
index 078edad97..bec5b7675 100644
--- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/base/ModelElementHandlerBase.java
+++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/base/ModelElementHandlerBase.java
@@ -64,8 +64,8 @@ public abstract class ModelElementHandlerBase<T extends EObject> implements IMod
ImageDescriptor overlay = getIconOverlay(element);
if(overlay != null) {
Point resultImgSize = new Point(16, 16);
- ImageDescriptor[] overlaysArray = new ImageDescriptor[] {null, null, null,
- overlay, null};
+ ImageDescriptor[] overlaysArray =
+ new ImageDescriptor[] {null, null, null, overlay, null};
DecorationOverlayIcon decorated =
new DecorationOverlayIcon(iconImage, overlaysArray, resultImgSize);
return decorated.createImage();
@@ -141,6 +141,7 @@ public abstract class ModelElementHandlerBase<T extends EObject> implements IMod
return element;
}
+ // TODO(SB): Please improve documentation to explain difference to / interplay with getIcon()
/**
* Retrieves the overlay, that is applied to the icon of the given element.
*
--
GitLab