diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/base/EditorBase.java b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/base/EditorBase.java index 5c10c0b452be8c0d2f2822c4fae3e4c332e1833a..152231a546dd80016175d86ddc0108ace7a40ce9 100644 --- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/base/EditorBase.java +++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/base/EditorBase.java @@ -41,7 +41,7 @@ import org.fortiss.tooling.kernel.ui.internal.editor.ModelElementEditorInput; * @author hoelzlf * @author $Author$ * @version $Rev$ - * @ConQAT.Rating RED Hash: DF6DB4EFA6BC29413748BFF39E53C654 + * @ConQAT.Rating YELLOW Hash: 8E78A5604AD81E0BA5E5124F58512E6A */ public abstract class EditorBase<T extends EObject> extends EditorPart implements IActionContributingEditor, IModelEditor<T> { @@ -50,13 +50,9 @@ public abstract class EditorBase<T extends EObject> extends EditorPart * The object shown in this editor. This is valid as soon as * {@link #init(IEditorSite, IEditorInput)} has been called. */ - // TODO @Review CD:possibly final? - // moreover: field often called directly instead of using getter. reduce - // visibility? protected T editedObject; /** The model element handler to be used with the {@link #editedObject}. */ - // TODO @Review CD: as far as I can see this can be made final protected IModelElementHandler<T> handler; /** Databinding context used for model changes. */ diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/MarkerService.java b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/MarkerService.java index 1aeb56c6187fe5be7fcb1d2c426c875c3c399592..99ad34e4a268cb378f3d946e75108ea548e6366a 100644 --- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/MarkerService.java +++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/MarkerService.java @@ -53,7 +53,7 @@ import org.fortiss.tooling.kernel.ui.service.IMarkerService; * @author hoelzl * @author $Author$ * @version $Rev$ - * @ConQAT.Rating RED Hash: 14D6FBDEDFCCB59B545EEF873D46DAC9 + * @ConQAT.Rating YELLOW Hash: A7423A2812630B2E50752906688D3A1C */ public class MarkerService implements IMarkerService, IPersistencyServiceListener, ILightweightLabelDecorator { @@ -214,7 +214,7 @@ public class MarkerService implements IMarkerService, // use preferences settings here switch (highest) { case FATAL: - // TODO @Review CD: missing break and default behavior. + // fatal uses error icon case ERROR: decoration.addOverlay(ESharedImages.ERROR_OVERLAY .getImageDescriptor()); @@ -223,7 +223,8 @@ public class MarkerService implements IMarkerService, decoration.addOverlay(ESharedImages.WARNING_OVERLAY .getImageDescriptor()); break; - // ignore others + default: + // ignore info and debug } } }