From 2d7c0741136ae7d78c4c014f3cd339f50939cdf7 Mon Sep 17 00:00:00 2001
From: Florian Hoelzl <hoelzl@fortiss.org>
Date: Wed, 4 Jan 2012 15:05:27 +0000
Subject: [PATCH] YELLOW refs 311
---
.../tooling/kernel/ui/extension/base/EditorBase.java | 6 +-----
.../fortiss/tooling/kernel/ui/internal/MarkerService.java | 7 ++++---
2 files changed, 5 insertions(+), 8 deletions(-)
diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/base/EditorBase.java b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/base/EditorBase.java
index 5c10c0b45..152231a54 100644
--- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/base/EditorBase.java
+++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/base/EditorBase.java
@@ -41,7 +41,7 @@ import org.fortiss.tooling.kernel.ui.internal.editor.ModelElementEditorInput;
* @author hoelzlf
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating RED Hash: DF6DB4EFA6BC29413748BFF39E53C654
+ * @ConQAT.Rating YELLOW Hash: 8E78A5604AD81E0BA5E5124F58512E6A
*/
public abstract class EditorBase<T extends EObject> extends EditorPart
implements IActionContributingEditor, IModelEditor<T> {
@@ -50,13 +50,9 @@ public abstract class EditorBase<T extends EObject> extends EditorPart
* The object shown in this editor. This is valid as soon as
* {@link #init(IEditorSite, IEditorInput)} has been called.
*/
- // TODO @Review CD:possibly final?
- // moreover: field often called directly instead of using getter. reduce
- // visibility?
protected T editedObject;
/** The model element handler to be used with the {@link #editedObject}. */
- // TODO @Review CD: as far as I can see this can be made final
protected IModelElementHandler<T> handler;
/** Databinding context used for model changes. */
diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/MarkerService.java b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/MarkerService.java
index 1aeb56c61..99ad34e4a 100644
--- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/MarkerService.java
+++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/MarkerService.java
@@ -53,7 +53,7 @@ import org.fortiss.tooling.kernel.ui.service.IMarkerService;
* @author hoelzl
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating RED Hash: 14D6FBDEDFCCB59B545EEF873D46DAC9
+ * @ConQAT.Rating YELLOW Hash: A7423A2812630B2E50752906688D3A1C
*/
public class MarkerService implements IMarkerService,
IPersistencyServiceListener, ILightweightLabelDecorator {
@@ -214,7 +214,7 @@ public class MarkerService implements IMarkerService,
// use preferences settings here
switch (highest) {
case FATAL:
- // TODO @Review CD: missing break and default behavior.
+ // fatal uses error icon
case ERROR:
decoration.addOverlay(ESharedImages.ERROR_OVERLAY
.getImageDescriptor());
@@ -223,7 +223,8 @@ public class MarkerService implements IMarkerService,
decoration.addOverlay(ESharedImages.WARNING_OVERLAY
.getImageDescriptor());
break;
- // ignore others
+ default:
+ // ignore info and debug
}
}
}
--
GitLab