From 34ec3f75632f162be135bb2a8a31a8ad84122b4c Mon Sep 17 00:00:00 2001
From: Simon Barner <barner@fortiss.org>
Date: Wed, 6 Dec 2017 09:23:45 +0000
Subject: [PATCH] Rename LogMessageHandler -> ILogMessageHandler
---
.../src/org/fortiss/tooling/base/ui/dialog/.ratings | 6 +-----
.../ModelElementWithRefCopyMessageHandler.java | 6 +++---
.../org/fortiss/tooling/kernel/extension/.ratings | 2 +-
...ogMessageHandler.java => ILogMessageHandler.java} | 6 ++----
.../fortiss/tooling/kernel/extension/data/.ratings | 3 +--
.../kernel/extension/data/ILogMessageContext.java | 4 ++--
.../src/org/fortiss/tooling/kernel/internal/.ratings | 3 +--
.../tooling/kernel/internal/LoggingService.java | 12 ++++++------
.../src/org/fortiss/tooling/kernel/service/.ratings | 3 +--
.../tooling/kernel/service/ILoggingService.java | 8 ++++----
10 files changed, 22 insertions(+), 31 deletions(-)
rename org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/extension/{LogMessageHandler.java => ILogMessageHandler.java} (87%)
diff --git a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/dialog/.ratings b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/dialog/.ratings
index 7916a1108..588bd3ab4 100644
--- a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/dialog/.ratings
+++ b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/dialog/.ratings
@@ -1,14 +1,10 @@
-
ButtonDialog.java 1ac5f7842d52ea384c8a73c2d59a685e516ce4a5 GREEN
-ButtonDialogGUI.java b6f110079b99e2339732c0c0aa4e9ad257045e6b GREEN
CheckBoxTreeDialog.java bdddcf60b63598d5517fc860ab02da7ab3f56ef5 GREEN
ElementTreeMultiSelectDialog.java 4dd9ed281145f9f58f9827d66f05b13733068df3 GREEN
-ElementTreeMultiSelectDialogGUI.java d24ff75991d59d3d53fafa4c0440dd5e47b90e80 GREEN
ElementTreeSingleSelectDialog.java 563b61edd516acbe6dfc4e8d8e5dc2bea76edc87 GREEN
-ElementTreeSingleSelectDialogGUI.java 8845adf26663ea21e084f600a76f3efaa64e8344 GREEN
IDialogEditSupport.java f4128d109c23470544bbe47c9b3321180c6d24ed GREEN
MessageUtilsExtended.java b107e70f15965c563ff1e804fdf2cfc5252853ff GREEN
ModelElementTreeContentProvider.java dc5b51728333ddbc3a79034dbe2f8b5c79b49f34 GREEN
-ModelElementWithRefCopyMessageHandler.java 8c73ac5577c3122350799b844f9c16c237c16f6f GREEN
+ModelElementWithRefCopyMessageHandler.java e334cda33829f30996f41d0b3e7c881c6f8b71a4 GREEN
MultiFieldInputDialog.java ea831811ed66d82b900a68eaa72ec9f1d4949932 GREEN
MultiRootTreeContentProvider.java 977d6a4551d2f8cc401d382316cfe88bf90e1365 GREEN
diff --git a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/dialog/ModelElementWithRefCopyMessageHandler.java b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/dialog/ModelElementWithRefCopyMessageHandler.java
index 54b7150bc..12d77e083 100644
--- a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/dialog/ModelElementWithRefCopyMessageHandler.java
+++ b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/dialog/ModelElementWithRefCopyMessageHandler.java
@@ -19,18 +19,18 @@ import static org.fortiss.tooling.base.ui.dialog.MessageUtilsExtended.showWarnin
import org.fortiss.tooling.base.compose.ModelElementWithRefCopyMessage;
import org.fortiss.tooling.base.model.element.IModelElementSpecification;
-import org.fortiss.tooling.kernel.extension.LogMessageHandler;
+import org.fortiss.tooling.kernel.extension.ILogMessageHandler;
import org.fortiss.tooling.kernel.extension.data.ILogMessageContext;
/**
- * {@link LogMessageHandler} that displays warning dialogs of {@link ModelElementWithRefCopyMessage}
+ * {@link ILogMessageHandler} that displays warning dialogs of {@link ModelElementWithRefCopyMessage}
* s which are emitted when a user copies elements which reference
* {@link IModelElementSpecification}s.
*
* @author diewald
*/
public class ModelElementWithRefCopyMessageHandler implements
- LogMessageHandler<ModelElementWithRefCopyMessage> {
+ ILogMessageHandler<ModelElementWithRefCopyMessage> {
/** Title of the dialog. */
private static final String TITLE = "References to external model elements.";
diff --git a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/extension/.ratings b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/extension/.ratings
index afafb417d..05e6fa0c6 100644
--- a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/extension/.ratings
+++ b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/extension/.ratings
@@ -1,4 +1,3 @@
-
IConnectionCompositor.java 8580af5f102e01b7399107a6fb746796675b10c1 GREEN
IConstraint.java 86dbd10cbb64a3e562d342e000b376b628d2ff33 RED
IConstraintChecker.java 2c85ad00914327d7a614be7de837a31a504bc723 GREEN
@@ -6,6 +5,7 @@ IEclipseResourcePostLoadProvider.java 8a8cd579a66be5f474e54b3146dd7be9c9736b53 G
IEclipseResourceStorageLocationProvider.java 75cccba8507cdad430e7ec9acc2edf88671dde1e GREEN
IElementCompositor.java 1c2044b4b94b7e4aa8f5d7a1b13ab2b7ccac4701 GREEN
ILibraryElementHandler.java 43ddeb8dd2ed480b5159f632fbee1e493fdfe84d GREEN
+ILogMessageHandler.java 029e142a471418c70e574e62da820f2ecc2f718a YELLOW
IMigrationProvider.java a9f0d25e0fbf7228909e1c335b7059913c19ff81 GREEN
IPrototypeProvider.java fe72164651b48888bc69f47962bcaa256de9097f GREEN
IStorageProvider.java 2afca7f09e782b83bd342a9c32afc319a5c182ab GREEN
diff --git a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/extension/LogMessageHandler.java b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/extension/ILogMessageHandler.java
similarity index 87%
rename from org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/extension/LogMessageHandler.java
rename to org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/extension/ILogMessageHandler.java
index 05e8f8a77..9ab53e836 100644
--- a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/extension/LogMessageHandler.java
+++ b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/extension/ILogMessageHandler.java
@@ -23,14 +23,12 @@ import org.fortiss.tooling.kernel.service.base.IObjectAware;
/**
* The {@link LoggingService} provides registration and access to MessageHandlers that are used to
* display messages emitted from non-UI, i.e. model, plugins to the user.
- * A {@link LogMessageHandler} knows how to present the given message to the user, e.g., the layout
+ * A {@link ILogMessageHandler} knows how to present the given message to the user, e.g., the layout
* or dialog style.
*
- * TODO(VA) Shouldn't this interface be called *I*LogMessageHandler?
- *
* @author diewald
*/
-public interface LogMessageHandler<LM extends LogMessage> extends IObjectAware<LM> {
+public interface ILogMessageHandler<LM extends LogMessage> extends IObjectAware<LM> {
/** Processes the {@link LogMessage} by the handler. */
void showMessage(LM message, ILogMessageContext context);
}
diff --git a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/extension/data/.ratings b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/extension/data/.ratings
index 8c33cecbe..baaf4a2e4 100644
--- a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/extension/data/.ratings
+++ b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/extension/data/.ratings
@@ -1,8 +1,7 @@
-
IConnectionCompositionContext.java cf43a61c89c489089cd8d34f5137034ded0b2672 GREEN
IConstraintViolation.java df6889fcf5834f9488d2023f885e15070bf46d3e GREEN
IElementCompositionContext.java 9f929de12ebd84ef1910dab25798281abbd4fd31 GREEN
-ILogMessageContext.java 4c7628e1f9fdc3609be44295f7c77e0787a00630 GREEN
+ILogMessageContext.java d760367a573a8022f2c230a149074269ebbaf7c4 GREEN
ITopLevelElement.java cd47687ba1b18ae4d5ad01a07b799ed0833a0979 GREEN
ITransformationContext.java ed846c5a8c4e96716e9c4c1f52dd10afd42a2df9 GREEN
LibraryPrototype.java 669b97c5cc045a4b308bb0bef1f1ed3d77b9adf4 GREEN
diff --git a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/extension/data/ILogMessageContext.java b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/extension/data/ILogMessageContext.java
index baf3d6f98..46c9a8875 100644
--- a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/extension/data/ILogMessageContext.java
+++ b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/extension/data/ILogMessageContext.java
@@ -15,10 +15,10 @@
+--------------------------------------------------------------------------*/
package org.fortiss.tooling.kernel.extension.data;
-import org.fortiss.tooling.kernel.extension.LogMessageHandler;
+import org.fortiss.tooling.kernel.extension.ILogMessageHandler;
/**
- * Marker interface to provide additional information to a {@link LogMessageHandler}.
+ * Marker interface to provide additional information to a {@link ILogMessageHandler}.
* For instance, it can be marked whether a {@link ILogMessageContext} is triggered from a user
* interaction.
*
diff --git a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/.ratings b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/.ratings
index f382b95a7..445d00571 100644
--- a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/.ratings
+++ b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/.ratings
@@ -1,4 +1,3 @@
-
CommandStackService.java 34792bb7069917c9436b895e3a4e211197d5c026 RED
ConnectionCompositorService.java eb2dcfa82e3dd9174e2c7b0fb496afc8ae8b9216 GREEN
ConstraintCheckerService.java 036808df8d173a994842bae370b557f54a196733 GREEN
@@ -7,7 +6,7 @@ DummyTopLevelElement.java 634dc9c9e205ab4b7bb7c7794565d927d4648a49 GREEN
ElementCompositorService.java feab3d996d7c61e4cb17bd9e990a8d944e52180d GREEN
LibraryPrototypeProvider.java 039d75d5d972e1fd304577e29f82f95e2081255e GREEN
LibraryService.java 9942eb2b7c72f8be705bb979f02de45e55175ba5 GREEN
-LoggingService.java 4928f732b8b41ed858f5386d80f8fdcfc6a6128b GREEN
+LoggingService.java ef00b8767f3426ef9568fb5009193034f2967dd4 GREEN
MigrationService.java c542f63a382ab42f36ca82b4d4d32ef6a825aad2 GREEN
PersistencyService.java 1f06159177e6247083a4ea5baaf8476ea38bc213 GREEN
PrototypeService.java 8f40bc1b1a6d597dbc3ac01c96d9e4fb1e829a58 GREEN
diff --git a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/LoggingService.java b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/LoggingService.java
index 658a86e10..c77e48deb 100644
--- a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/LoggingService.java
+++ b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/LoggingService.java
@@ -17,7 +17,7 @@ package org.fortiss.tooling.kernel.internal;
import java.util.List;
-import org.fortiss.tooling.kernel.extension.LogMessageHandler;
+import org.fortiss.tooling.kernel.extension.ILogMessageHandler;
import org.fortiss.tooling.kernel.extension.data.ILogMessageContext;
import org.fortiss.tooling.kernel.extension.data.LogMessage;
import org.fortiss.tooling.kernel.service.IKernelIntrospectionSystemService;
@@ -29,7 +29,7 @@ import org.fortiss.tooling.kernel.service.base.ObjectAwareServiceBase;
*
* @author diewald
*/
-public class LoggingService extends ObjectAwareServiceBase<LogMessageHandler<LogMessage>> implements
+public class LoggingService extends ObjectAwareServiceBase<ILogMessageHandler<LogMessage>> implements
ILoggingService {
/** The singleton instance. */
private static final LoggingService INSTANCE = new LoggingService();
@@ -64,9 +64,9 @@ public class LoggingService extends ObjectAwareServiceBase<LogMessageHandler<Log
/** Registers a handler for the given class of {@link LogMessage}s. */
@Override
@SuppressWarnings("unchecked")
- public <LM extends LogMessage> void registerLogMessageHandler(LogMessageHandler<LM> handler,
+ public <LM extends LogMessage> void registerLogMessageHandler(ILogMessageHandler<LM> handler,
Class<LM> logMessageClass) {
- addHandler(logMessageClass, (LogMessageHandler<LogMessage>)handler);
+ addHandler(logMessageClass, (ILogMessageHandler<LogMessage>)handler);
}
/** {@inheritDoc} */
@@ -84,8 +84,8 @@ public class LoggingService extends ObjectAwareServiceBase<LogMessageHandler<Log
/** {@inheritDoc} */
@Override
public void processMessage(LogMessage message, ILogMessageContext context) {
- List<LogMessageHandler<LogMessage>> handlerList = getRegisteredHandlers(message.getClass());
- for(LogMessageHandler<LogMessage> handler : handlerList) {
+ List<ILogMessageHandler<LogMessage>> handlerList = getRegisteredHandlers(message.getClass());
+ for(ILogMessageHandler<LogMessage> handler : handlerList) {
handler.showMessage(message, context);
}
}
diff --git a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/service/.ratings b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/service/.ratings
index 5fae3a85a..be5e92806 100644
--- a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/service/.ratings
+++ b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/service/.ratings
@@ -1,4 +1,3 @@
-
ICommandStackService.java 33726120716d0628e0ee328e7d1bf2669077b3fd GREEN
IConnectionCompositorService.java c55950f1581ce421dd0213d816d0c14d30a88903 GREEN
IConstraintCheckerService.java 96b4849e7f41448b36f3b91cc095c9cb60e65138 GREEN
@@ -7,7 +6,7 @@ IEclipseResourceStorageService.java 6cd3f7a697c3d1cbf897ae54ce5ebf75aab70b0a GRE
IElementCompositorService.java 30ff8e73fd024de5e408b7c5e10d44790aaf6e26 GREEN
IKernelIntrospectionSystemService.java 685e85ac8639ae0bfd34cb2639bdc9c9b3b1d99a GREEN
ILibraryService.java 70e03666c36f95963d1e0a5568b6526c35ab84ef GREEN
-ILoggingService.java 2e81157d413816164da6621db76027b572dfa41d GREEN
+ILoggingService.java 3e515b141a1117e782f3c30f2974a69241c716c6 GREEN
IMigrationService.java 454d62421b6f118cffdbabd1c6f3790deaff32ef GREEN
IPersistencyService.java 372d17a34e3c39a2f428ded785a11d20c9b2e223 GREEN
IPrototypeService.java c6c2e572495e9c314bfbccdb49d8ff1447e48600 GREEN
diff --git a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/service/ILoggingService.java b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/service/ILoggingService.java
index e710b3b16..1ee9723af 100644
--- a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/service/ILoggingService.java
+++ b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/service/ILoggingService.java
@@ -15,14 +15,14 @@
+--------------------------------------------------------------------------*/
package org.fortiss.tooling.kernel.service;
-import org.fortiss.tooling.kernel.extension.LogMessageHandler;
+import org.fortiss.tooling.kernel.extension.ILogMessageHandler;
import org.fortiss.tooling.kernel.extension.data.ILogMessageContext;
import org.fortiss.tooling.kernel.extension.data.LogMessage;
import org.fortiss.tooling.kernel.internal.LoggingService;
/**
* The logging service allows methods to emit {@link LogMessage}s that are processed by
- * {@link LogMessageHandler}s. The service is implemented in a broadcast manner such that each
+ * {@link ILogMessageHandler}s. The service is implemented in a broadcast manner such that each
* handler is activated that accepts the emitted {@link LogMessage} with the given
* {@link ILogMessageContext}.
*
@@ -40,12 +40,12 @@ public interface ILoggingService {
/**
* Triggers the processing method of the given {@link LogMessage} for all
- * {@link LogMessageHandler}s that accept the {@link LogMessage} from the given
+ * {@link ILogMessageHandler}s that accept the {@link LogMessage} from the given
* {@link ILogMessageContext}.
*/
void processMessage(LogMessage message, ILogMessageContext context);
/** Registers the given handler with the service. */
- <LM extends LogMessage> void registerLogMessageHandler(LogMessageHandler<LM> handler,
+ <LM extends LogMessage> void registerLogMessageHandler(ILogMessageHandler<LM> handler,
Class<LM> logMessageClass);
}
--
GitLab