From 355e83bc0e969d033ba8a525916d59ad982118bd Mon Sep 17 00:00:00 2001
From: Alexander Diewald <diewald@fortiss.org>
Date: Tue, 4 Dec 2018 13:58:04 +0100
Subject: [PATCH] CR: GREEN
Issue-Ref: 3536
Issue-Url: https://af3-developer.fortiss.org/issues/3536
Signed-off-by: Alexander Diewald <diewald@fortiss.org>
---
.../src/org/fortiss/tooling/base/ui/editor/.ratings | 6 +++---
.../fortiss/tooling/base/ui/editor/SourceEditorBase.java | 4 ++--
.../base/ui/editor/SourceEditorConfigurationBase.java | 6 +++---
.../tooling/base/ui/editor/SourceEditorUndoRedo.java | 4 ++--
4 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/org.fortiss.tooling.base.ui/src/org/fortiss/tooling/base/ui/editor/.ratings b/org.fortiss.tooling.base.ui/src/org/fortiss/tooling/base/ui/editor/.ratings
index 2d1b98a8f..ac8c5138b 100644
--- a/org.fortiss.tooling.base.ui/src/org/fortiss/tooling/base/ui/editor/.ratings
+++ b/org.fortiss.tooling.base.ui/src/org/fortiss/tooling/base/ui/editor/.ratings
@@ -7,7 +7,7 @@ DiagramEditorBase.java 09663ce095074d1a8eef086284eea0a7776e0431 GREEN
DiagramKeyHandler.java cfd15ac8f9fc933739cef5e7039960e19826d1ce GREEN
FormsEditorBase.java 4046d340913d951340084ae7240d79f8e75cb8d4 GREEN
GEFEditorBase.java e668f596f45f07215994cbbd3929a9438331718f GREEN
-SourceEditorBase.java 347d6b45d577abd7e23a7234904be118e82469f1 YELLOW
-SourceEditorConfigurationBase.java db3898fe1cace33aab0dd83d9711205c235c9861 YELLOW
-SourceEditorUndoRedo.java 5f5d1b05c8b1287a9e37d866eda3474b6dcbd014 YELLOW
+SourceEditorBase.java 662b921019fed964cd47838e8758194b66fa3a63 GREEN
+SourceEditorConfigurationBase.java e8b810c0d974c475f0a8e6f21aa5b6fd9e17c33a GREEN
+SourceEditorUndoRedo.java 08127a8e0afb4f9c2f4c21294ca3220282c25bf0 GREEN
TreeViewerEditorBase.java 1c59689ff57c4f3cc180d85f13021fc03461ecb0 GREEN
diff --git a/org.fortiss.tooling.base.ui/src/org/fortiss/tooling/base/ui/editor/SourceEditorBase.java b/org.fortiss.tooling.base.ui/src/org/fortiss/tooling/base/ui/editor/SourceEditorBase.java
index 347d6b45d..662b92101 100644
--- a/org.fortiss.tooling.base.ui/src/org/fortiss/tooling/base/ui/editor/SourceEditorBase.java
+++ b/org.fortiss.tooling.base.ui/src/org/fortiss/tooling/base/ui/editor/SourceEditorBase.java
@@ -74,10 +74,10 @@ import org.fortiss.tooling.kernel.ui.extension.base.EditorBase;
import org.fortiss.tooling.kernel.ui.service.IActionService;
/**
- * Editor for code specifications.
+ * Base class for editors of source code of any type.
*
+ * @author doebber
* @author kanav
- * @param <T>
*/
public abstract class SourceEditorBase<T extends EObject> extends EditorBase<T> {
diff --git a/org.fortiss.tooling.base.ui/src/org/fortiss/tooling/base/ui/editor/SourceEditorConfigurationBase.java b/org.fortiss.tooling.base.ui/src/org/fortiss/tooling/base/ui/editor/SourceEditorConfigurationBase.java
index db3898fe1..e8b810c0d 100644
--- a/org.fortiss.tooling.base.ui/src/org/fortiss/tooling/base/ui/editor/SourceEditorConfigurationBase.java
+++ b/org.fortiss.tooling.base.ui/src/org/fortiss/tooling/base/ui/editor/SourceEditorConfigurationBase.java
@@ -15,6 +15,7 @@
+--------------------------------------------------------------------------*/
package org.fortiss.tooling.base.ui.editor;
+import static java.lang.Character.isLetterOrDigit;
import static org.eclipse.jface.text.IDocument.DEFAULT_CONTENT_TYPE;
import static org.eclipse.wb.swt.SWTResourceManager.getColor;
@@ -34,7 +35,6 @@ import org.eclipse.jface.text.source.IAnnotationHover;
import org.eclipse.jface.text.source.ISourceViewer;
import org.eclipse.jface.text.source.SourceViewerConfiguration;
import org.eclipse.swt.graphics.Color;
-import org.fortiss.tooling.base.ui.editor.SourceEditorBase;
import org.fortiss.tooling.base.ui.editor.annotations.AnnotationHover;
/**
@@ -64,13 +64,13 @@ public abstract class SourceEditorConfigurationBase<T extends EObject>
/** {@inheritDoc} */
@Override
public boolean isWordStart(char c) {
- return Character.isLetterOrDigit(c);
+ return isLetterOrDigit(c);
}
/** {@inheritDoc} */
@Override
public boolean isWordPart(char c) {
- return Character.isLetterOrDigit(c) || c == '_';
+ return isLetterOrDigit(c) || c == '_';
}
};
diff --git a/org.fortiss.tooling.base.ui/src/org/fortiss/tooling/base/ui/editor/SourceEditorUndoRedo.java b/org.fortiss.tooling.base.ui/src/org/fortiss/tooling/base/ui/editor/SourceEditorUndoRedo.java
index 5f5d1b05c..08127a8e0 100644
--- a/org.fortiss.tooling.base.ui/src/org/fortiss/tooling/base/ui/editor/SourceEditorUndoRedo.java
+++ b/org.fortiss.tooling.base.ui/src/org/fortiss/tooling/base/ui/editor/SourceEditorUndoRedo.java
@@ -28,6 +28,7 @@ import org.eclipse.swt.events.KeyListener;
* Hack to fix the seemingly broken undo-redo functionality of SourceViewer.
*
* @author aravantinos
+ * @author kanav
*/
public class SourceEditorUndoRedo implements KeyListener, ExtendedModifyListener {
/**
@@ -99,8 +100,7 @@ public class SourceEditorUndoRedo implements KeyListener, ExtendedModifyListener
/**
* Creates a new instance of this class. Automatically starts listening to
- * corresponding key and modify events coming from the given
- * <var>editor</var>.
+ * corresponding key and modify events coming from the given {@code editor}.
*
* @param editor
* the text field to which the Undo-Redo functionality should be
--
GitLab