RED

refs 2490

org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/allocation/AllocationConnectionEditPartBase.java

@@ -18,7 +18,6 @@ $Id: codetemplates.xml 1 2011-01-01 00:00:01Z hoelzl $
 package org.fortiss.tooling.base.ui.editpart.allocation;
 
 import org.eclipse.draw2d.PolylineConnection;
-import org.eclipse.gef.EditPart;
 import org.fortiss.tooling.base.model.base.ConnectionSegmentBase;
 import org.fortiss.tooling.base.ui.editpart.ConnectionEditPartBase;
 import org.fortiss.tooling.base.ui.layout.IDiagramLayoutConfiguration;
@@ -46,10 +45,8 @@ public abstract class AllocationConnectionEditPartBase<T extends ConnectionSegme
 	protected void refreshVisuals() {
 		super.refreshVisuals();
 
-		EditPart target = getTarget();
-		EditPart source = getSource();
 		// Prevent connections from being shown in the wrong hierarchical layers
-		figure.setVisible(target != null && source != null);
+		figure.setVisible(getTarget() != null && getSource() != null);
 	}
 
 	/** {@inheritDoc} */

org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/allocation/AllocationSubDiagramEditPartBase.java

@@ -378,9 +378,9 @@ public abstract class AllocationSubDiagramEditPartBase<T extends INamedCommented
 		if(req.getType() == RequestConstants.REQ_OPEN) {
 			List<Object> children = new ArrayList<>();
 			if(req.getExtendedData().isEmpty()) {
-				// sub diagram background selection
-				// works only with hierarchic elements
+				// sub diagram background selection works only with hierarchical elements
 				if(!modelChildren.isEmpty()) {
+					// TODO(VA) get(0)
 					Object object = modelChildren.get(0);
 					IHierarchicElement parentElement =
 							getParentElement((EObject)object, IHierarchicElement.class, false);

org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/allocation/IAllocationPositionService.java

@@ -23,11 +23,12 @@ import org.eclipse.gef.RootEditPart;
 
 /**
  * Interface for allocation target elements.
+ * TODO(VA) What does it offer? How shall somebody make use of it?
  * 
  * @author eder
  * @author $Author: hoelzl $
  * @version $Rev: 18709 $
- * @ConQAT.Rating YELLOW Hash: 5843BA630F8515B3245F9BF1B2C53DBD
+ * @ConQAT.Rating GREEN Hash: 59DEDA1BB0E7E974923EA1A05204549C
  */
 public interface IAllocationPositionService {
 	/** Returns the service instance. */