From 48b180be150b70af52fede525cf761da3721cfc3 Mon Sep 17 00:00:00 2001 From: Daniel Ratiu <ratiu@fortiss.org> Date: Fri, 5 Aug 2011 09:43:30 +0000 Subject: [PATCH] Yet another review of the code. --- .../base/ui/command/BendpointCommandBase.java | 2 +- .../command/ChangeBoundsRequestCommandBase.java | 2 +- .../base/ui/command/ConnectionCommand.java | 16 ++++++++-------- .../base/ui/command/CreateBendpointCommand.java | 2 +- .../base/ui/command/DeleteBendpointCommand.java | 2 +- .../base/ui/command/MoveBendpointCommand.java | 2 +- .../base/ui/command/MoveConnectorCommand.java | 2 +- .../ui/command/MoveWithinDiagramCommand.java | 2 +- .../fortiss/tooling/base/ui/dnd/DragContext.java | 5 ++++- .../fortiss/tooling/base/ui/dnd/DropContext.java | 5 ++++- .../tooling/base/ui/dnd/DropTargetListener.java | 4 ++-- .../ui/editpart/ExtendedLayerRootEditPart.java | 2 +- .../anchor/InsetChopBoxConnectionAnchor.java | 2 +- .../ui/editpart/figure/AntiAliasedEllipse.java | 2 +- .../base/ui/editpart/figure/DecoratorFigure.java | 2 +- .../base/ui/editpart/figure/EVisualStyle.java | 2 +- .../ui/editpart/figure/PrettyInsetEllipse.java | 2 +- .../editpart/figure/PrettyRoundedRectangle.java | 2 +- .../policy/ConnectionBendpointEditPolicy.java | 2 +- .../ConnectionGraphicalNodeEditPolicy.java | 2 +- .../ConstrainedNonResizableEditPolicy.java | 2 +- .../editpart/policy/DiagramLayoutEditPolicy.java | 2 +- .../editpart/policy/ElementLayoutEditPolicy.java | 2 +- .../editpart/policy/FreeResizableEditPolicy.java | 3 ++- .../ui/editpart/policy/LayoutEditPolicyBase.java | 2 +- .../ui/editpart/policy/RemoveEditPolicy.java | 2 +- .../tooling/base/ui/layout/IPointLayouter.java | 4 +++- .../layout/constants/DefaultLayoutConstants.java | 2 +- .../ui/layout/constants/LayoutKeyConstants.java | 2 +- .../tooling/base/ui/layout/util/AngleUtil.java | 2 +- .../base/ui/layout/util/DimensionUtil.java | 2 +- .../base/ui/layout/util/LayoutDataUtils.java | 2 +- .../ui/layout/util/OffsetOrientationUtil.java | 2 +- .../tooling/base/ui/layout/util/PointUtil.java | 3 +++ .../tooling/base/ui/layout/util/PointsUtil.java | 5 ++++- .../base/ui/layout/util/SnapToGridUtils.java | 2 +- .../tooling/base/ui/layout/util/ZoomUtils.java | 2 +- .../GraphicalViewerPreferencePage.java | 2 +- .../base/ui/preferences/MainPreferencePage.java | 2 +- .../trunk/model/generate-ecore.xml | 2 +- .../tooling/base/ToolingBaseActivator.java | 2 +- 41 files changed, 63 insertions(+), 48 deletions(-) diff --git a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/command/BendpointCommandBase.java b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/command/BendpointCommandBase.java index 311364824..d077a79c7 100644 --- a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/command/BendpointCommandBase.java +++ b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/command/BendpointCommandBase.java @@ -27,7 +27,7 @@ import org.fortiss.tooling.base.model.layout.ILayoutedModelElement; * @author hoelzl * @author $Author$ * @version $Rev$ - * @ConQAT.Rating YELLOW Hash: 6CDD3F1694F0E50432432EBBF3DA82A4 + * @ConQAT.Rating GREEN Hash: 8FB6A5E20076ECFAB90EB559B84E4C2A */ public abstract class BendpointCommandBase extends Command { diff --git a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/command/ChangeBoundsRequestCommandBase.java b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/command/ChangeBoundsRequestCommandBase.java index 49cee17b5..fb1356a90 100644 --- a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/command/ChangeBoundsRequestCommandBase.java +++ b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/command/ChangeBoundsRequestCommandBase.java @@ -34,7 +34,7 @@ import org.fortiss.tooling.base.ui.layout.util.LayoutDataUtils; * @author hoelzl * @author $Author$ * @version $Rev$ - * @ConQAT.Rating YELLOW Hash: 97E72763FD3655AAF658FF43EAA8C3CF + * @ConQAT.Rating GREEN Hash: F47DE8BFDA3950070E5EFC6DAEB4D8C4 */ public abstract class ChangeBoundsRequestCommandBase extends Command { diff --git a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/command/ConnectionCommand.java b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/command/ConnectionCommand.java index 53e582a17..940d8a43f 100644 --- a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/command/ConnectionCommand.java +++ b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/command/ConnectionCommand.java @@ -27,12 +27,12 @@ import org.fortiss.tooling.kernel.service.IConnectionCompositorService; /** * This command is used by {@link ConnectionGraphicalNodeEditPolicy} to - * communicate with the connector service. + * communicate with {@link IConnectionCompositorService}. * * @author hoelzl * @author $Author$ * @version $Rev$ - * @ConQAT.Rating YELLOW Hash: B0F33CCD646C725CE690BDB141193612 + * @ConQAT.Rating GREEN Hash: 00634D0BD9758BDAF4449AFE77C1087D */ public class ConnectionCommand extends Command { @@ -62,9 +62,9 @@ public class ConnectionCommand extends Command { } if (context.getSource().getModel() instanceof EObject && context.getTarget().getModel() instanceof EObject) { - return IConnectionCompositorService.INSTANCE.canConnect((EObject) context - .getSource().getModel(), (EObject) context.getTarget() - .getModel(), connection, context); + return IConnectionCompositorService.INSTANCE.canConnect( + (EObject) context.getSource().getModel(), (EObject) context + .getTarget().getModel(), connection, context); } return false; } @@ -72,8 +72,8 @@ public class ConnectionCommand extends Command { /** {@inheritDoc} */ @Override public void execute() { - IConnectionCompositorService.INSTANCE.connect((EObject) context.getSource() - .getModel(), (EObject) context.getTarget().getModel(), - connection, context); + IConnectionCompositorService.INSTANCE.connect((EObject) context + .getSource().getModel(), (EObject) context.getTarget() + .getModel(), connection, context); } } diff --git a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/command/CreateBendpointCommand.java b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/command/CreateBendpointCommand.java index 838f28e9b..e8477e22c 100644 --- a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/command/CreateBendpointCommand.java +++ b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/command/CreateBendpointCommand.java @@ -28,7 +28,7 @@ import org.fortiss.tooling.base.ui.layout.util.LayoutDataUtils; * @author hoelzl * @author $Author$ * @version $Rev$ - * @ConQAT.Rating YELLOW Hash: F116BF8DD007FAB3A0EA25C09A7B48BB + * @ConQAT.Rating GREEN Hash: F2CCAB8DDBF1645FD902C45F5A115988 */ public class CreateBendpointCommand extends BendpointCommandBase { diff --git a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/command/DeleteBendpointCommand.java b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/command/DeleteBendpointCommand.java index a13dfa891..4811868d0 100644 --- a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/command/DeleteBendpointCommand.java +++ b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/command/DeleteBendpointCommand.java @@ -26,7 +26,7 @@ import org.fortiss.tooling.base.ui.layout.util.LayoutDataUtils; * @author hoelzl * @author $Author$ * @version $Rev$ - * @ConQAT.Rating YELLOW Hash: 1199086FE886DBF2B151CC79C21F48C9 + * @ConQAT.Rating GREEN Hash: 8065D7B4FC73CC70C9CB1FE3290018D9 */ public class DeleteBendpointCommand extends BendpointCommandBase { /** Creates a command to delete a bend point. */ diff --git a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/command/MoveBendpointCommand.java b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/command/MoveBendpointCommand.java index 184e7520d..eb41664b1 100644 --- a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/command/MoveBendpointCommand.java +++ b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/command/MoveBendpointCommand.java @@ -28,7 +28,7 @@ import org.fortiss.tooling.base.ui.layout.util.LayoutDataUtils; * @author hoelzl * @author $Author$ * @version $Rev$ - * @ConQAT.Rating YELLOW Hash: 83BD91B4E187EEE6AAE9948532F3227F + * @ConQAT.Rating GREEN Hash: E24E7BBFF3601BFCFDF0F03ED5BCC2D2 */ public class MoveBendpointCommand extends BendpointCommandBase { diff --git a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/command/MoveConnectorCommand.java b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/command/MoveConnectorCommand.java index 9356ea1e4..83248cda7 100644 --- a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/command/MoveConnectorCommand.java +++ b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/command/MoveConnectorCommand.java @@ -36,7 +36,7 @@ import org.fortiss.tooling.base.ui.layout.util.LayoutDataUtils; * @author hoelzlf * @author $Author$ * @version $Rev$ - * @ConQAT.Rating YELLOW Hash: 44F8907016E9D390775ACCF4FC5FA5E8 + * @ConQAT.Rating GREEN Hash: E806F6189F17B9B9E2A126FB5432A81A */ public class MoveConnectorCommand extends ChangeBoundsRequestCommandBase { diff --git a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/command/MoveWithinDiagramCommand.java b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/command/MoveWithinDiagramCommand.java index e41d77c5a..4b6db4b25 100644 --- a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/command/MoveWithinDiagramCommand.java +++ b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/command/MoveWithinDiagramCommand.java @@ -32,7 +32,7 @@ import org.fortiss.tooling.base.ui.layout.constants.DefaultLayoutConstants; * @author hoelzl * @author $Author$ * @version $Rev$ - * @ConQAT.Rating YELLOW Hash: 4ECC57F8884FDDF3C622F30A50353585 + * @ConQAT.Rating GREEN Hash: D3A1601F1C27EAEC5CDDB52971822FF8 */ public class MoveWithinDiagramCommand extends ChangeBoundsRequestCommandBase { diff --git a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/dnd/DragContext.java b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/dnd/DragContext.java index d748d6391..bb79baa28 100644 --- a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/dnd/DragContext.java +++ b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/dnd/DragContext.java @@ -26,10 +26,13 @@ import org.fortiss.tooling.kernel.extension.data.IConnectionCompositionContext; * i.e. the source edit part and the location w.r.t. this edit part and the * target edit part and the location w.r.t. this edit part. * + * TODO: the class comments of {@link DragContext} and {@link DropContext} are + * highly different. Can we make them more homogeneous? + * * @author hoelzl * @author $Author$ * @version $Rev$ - * @ConQAT.Rating YELLOW Hash: A575B082D1C9D00D4F3DA25290D04715 + * @ConQAT.Rating RED Hash: 3C9A44958574E4B1F774160841886315 */ public class DragContext implements IConnectionCompositionContext { diff --git a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/dnd/DropContext.java b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/dnd/DropContext.java index 627be063f..0f0046238 100644 --- a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/dnd/DropContext.java +++ b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/dnd/DropContext.java @@ -30,10 +30,13 @@ import org.fortiss.tooling.kernel.extension.data.IElementCompositionContext; * The editpart can also be a diagram edit part, e.g. the background of some * diagram editor. * + * TODO: the class comments of {@link DragContext} and {@link DropContext} are + * highly different. Can we make them more homogeneous? + * * @author hoelzl * @author $Author$ * @version $Rev$ - * @ConQAT.Rating YELLOW Hash: 9BC9334824938F81319860D8E7CAFB27 + * @ConQAT.Rating RED Hash: 70B8E48635907E7922445C6DBE918F76 */ public class DropContext implements IElementCompositionContext { diff --git a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/dnd/DropTargetListener.java b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/dnd/DropTargetListener.java index 4cb0ef7c9..40fde7fb4 100644 --- a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/dnd/DropTargetListener.java +++ b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/dnd/DropTargetListener.java @@ -1,5 +1,5 @@ /*--------------------------------------------------------------------------+ -$Id$ + $Id$ | | | Copyright 2011 ForTISS GmbH | | | @@ -35,7 +35,7 @@ import org.fortiss.tooling.base.ui.editor.gef.GraphicalViewerEditorBase; * @author hoelzl * @author $Author$ * @version $Rev$ - * @ConQAT.Rating YELLOW Hash: 45BCB098D77D69D38DD9D04140703745 + * @ConQAT.Rating GREEN Hash: 8254A8D604E8FA36921DB38A8F8C717B */ public class DropTargetListener extends AbstractTransferDropTargetListener { diff --git a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/ExtendedLayerRootEditPart.java b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/ExtendedLayerRootEditPart.java index 7da8cd81c..4e7605156 100644 --- a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/ExtendedLayerRootEditPart.java +++ b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/ExtendedLayerRootEditPart.java @@ -51,7 +51,7 @@ import org.eclipse.gef.editparts.ScalableRootEditPart; * @author hoelzl * @author $Author$ * @version $Rev$ - * @ConQAT.Rating YELLOW Hash: F8855E6AA03A3F8215C9BA073623B464 + * @ConQAT.Rating GREEN Hash: 6AE34957657F23D48142F8C130CCC547 */ public class ExtendedLayerRootEditPart extends ScalableRootEditPart { /** The node layer ID. */ diff --git a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/anchor/InsetChopBoxConnectionAnchor.java b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/anchor/InsetChopBoxConnectionAnchor.java index d34e12d29..5168b778e 100644 --- a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/anchor/InsetChopBoxConnectionAnchor.java +++ b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/anchor/InsetChopBoxConnectionAnchor.java @@ -28,7 +28,7 @@ import org.eclipse.draw2d.geometry.Point; * @author hoelzl * @author $Author$ * @version $Rev$ - * @ConQAT.Rating YELLOW Hash: E1FF5315EEFE58AA002CC01E97F619C6 + * @ConQAT.Rating GREEN Hash: B537BA7FE701844831A67814A81C95C1 */ public class InsetChopBoxConnectionAnchor extends ChopboxAnchor { diff --git a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/figure/AntiAliasedEllipse.java b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/figure/AntiAliasedEllipse.java index a778a4351..535f238b5 100644 --- a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/figure/AntiAliasedEllipse.java +++ b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/figure/AntiAliasedEllipse.java @@ -27,7 +27,7 @@ import org.eclipse.swt.SWT; * @author hoelzl * @author $Author$ * @version $Rev$ - * @ConQAT.Rating YELLOW Hash: 07C86FB2361E45881CEB859B453E3F4F + * @ConQAT.Rating GREEN Hash: 04CA591F54FA5127E1F4933E9FB55449 */ public class AntiAliasedEllipse extends Ellipse { diff --git a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/figure/DecoratorFigure.java b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/figure/DecoratorFigure.java index edc87afcc..34785f0f7 100644 --- a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/figure/DecoratorFigure.java +++ b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/figure/DecoratorFigure.java @@ -32,7 +32,7 @@ import org.fortiss.tooling.kernel.extension.data.IConstraintViolation; * @author hoelzl * @author $Author$ * @version $Rev$ - * @ConQAT.Rating YELLOW Hash: 4E2A474E77547ACB0DF8C8D25A21C743 + * @ConQAT.Rating GREEN Hash: 941368BC6513E660CDC25E44EB53F349 */ public class DecoratorFigure extends Label { diff --git a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/figure/EVisualStyle.java b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/figure/EVisualStyle.java index 1bbed77b9..33f6a4902 100644 --- a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/figure/EVisualStyle.java +++ b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/figure/EVisualStyle.java @@ -28,7 +28,7 @@ import org.fortiss.tooling.base.ui.ToolingBaseUIActivator; * @author hoelzl * @author $Author$ * @version $Rev$ - * @ConQAT.Rating YELLOW Hash: B5D40E290043ECEE13218F5DA589AFB5 + * @ConQAT.Rating GREEN Hash: A56EAF879DF84E2265CA1617D0E8C55F */ public enum EVisualStyle { /** Traditional (since 2007) CCTS style with soft gradients. */ diff --git a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/figure/PrettyInsetEllipse.java b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/figure/PrettyInsetEllipse.java index 493046e86..3305a6ee4 100644 --- a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/figure/PrettyInsetEllipse.java +++ b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/figure/PrettyInsetEllipse.java @@ -40,7 +40,7 @@ import org.eclipse.ui.plugin.AbstractUIPlugin; * @author hoelzl * @author $Author$ * @version $Rev$ - * @ConQAT.Rating YELLOW Hash: 6532DB99FCD990C052DA0B8D0957D3E2 + * @ConQAT.Rating GREEN Hash: CF233E62948846C66408FEE3848CFBDE */ public class PrettyInsetEllipse extends Shape { diff --git a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/figure/PrettyRoundedRectangle.java b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/figure/PrettyRoundedRectangle.java index cf48e6478..6f535092b 100644 --- a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/figure/PrettyRoundedRectangle.java +++ b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/figure/PrettyRoundedRectangle.java @@ -38,7 +38,7 @@ import org.fortiss.tooling.base.ui.ToolingBaseUIActivator; * @author hoelzl * @author $Author$ * @version $Rev$ - * @ConQAT.Rating YELLOW Hash: BF9CBEC805A24099FC3782B3DAFD11CE + * @ConQAT.Rating GREEN Hash: 3FE067E8F618DE4394D10876405951A7 */ public class PrettyRoundedRectangle extends Shape { diff --git a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/policy/ConnectionBendpointEditPolicy.java b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/policy/ConnectionBendpointEditPolicy.java index 1ecd9c490..134c17e30 100644 --- a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/policy/ConnectionBendpointEditPolicy.java +++ b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/policy/ConnectionBendpointEditPolicy.java @@ -36,7 +36,7 @@ import org.fortiss.tooling.base.ui.layout.util.SnapToGridUtils; * @author hoelzl * @author $Author$ * @version $Rev$ - * @ConQAT.Rating YELLOW Hash: 798A66B49EB8A53551DAFDE6BB690C3E + * @ConQAT.Rating GREEN Hash: E77983D22C4E49D977F8A4BC13E34D85 */ public class ConnectionBendpointEditPolicy<T extends ILayoutedModelElement & IConnection> extends BendpointEditPolicy implements IPointLayouter { diff --git a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/policy/ConnectionGraphicalNodeEditPolicy.java b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/policy/ConnectionGraphicalNodeEditPolicy.java index 7daa36560..c47777cf7 100644 --- a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/policy/ConnectionGraphicalNodeEditPolicy.java +++ b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/policy/ConnectionGraphicalNodeEditPolicy.java @@ -78,7 +78,7 @@ import org.fortiss.tooling.base.ui.dnd.DragContext; * @author hoelzl * @author $Author$ * @version $Rev$ - * @ConQAT.Rating YELLOW Hash: 8FF043FB7B5273EEE1829448DB3F2EA8 + * @ConQAT.Rating GREEN Hash: 0CE8E3EEB63110DB784B1877B7405C01 */ public class ConnectionGraphicalNodeEditPolicy extends GraphicalNodeEditPolicy { diff --git a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/policy/ConstrainedNonResizableEditPolicy.java b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/policy/ConstrainedNonResizableEditPolicy.java index e2563ded2..b629a45d1 100644 --- a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/policy/ConstrainedNonResizableEditPolicy.java +++ b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/policy/ConstrainedNonResizableEditPolicy.java @@ -47,7 +47,7 @@ import org.fortiss.tooling.kernel.model.INamedCommentedElement; * @author hoelzl * @author $Author$ * @version $Rev$ - * @ConQAT.Rating YELLOW Hash: D8173BE506F1A36E8BF28B17E1BD9C1E + * @ConQAT.Rating GREEN Hash: 4A355EC6FDC855CE9E728649BD5D8B6B */ public class ConstrainedNonResizableEditPolicy<T extends ILayoutedModelElement & INamedCommentedElement> extends NonResizableEditPolicy { diff --git a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/policy/DiagramLayoutEditPolicy.java b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/policy/DiagramLayoutEditPolicy.java index 77211b126..c57a3987c 100644 --- a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/policy/DiagramLayoutEditPolicy.java +++ b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/policy/DiagramLayoutEditPolicy.java @@ -35,7 +35,7 @@ import org.fortiss.tooling.base.ui.layout.util.ZoomUtils; * @author hoelzl * @author $Author$ * @version $Rev$ - * @ConQAT.Rating YELLOW Hash: FBC121B49FD0AD95808132A6B4477132 + * @ConQAT.Rating GREEN Hash: EDE430BDF6AF2557B61A010B20999456 */ public class DiagramLayoutEditPolicy extends LayoutEditPolicyBase { diff --git a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/policy/ElementLayoutEditPolicy.java b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/policy/ElementLayoutEditPolicy.java index febafaced..f9d135046 100644 --- a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/policy/ElementLayoutEditPolicy.java +++ b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/policy/ElementLayoutEditPolicy.java @@ -36,7 +36,7 @@ import org.fortiss.tooling.kernel.model.INamedCommentedElement; * @author hoelzl * @author $Author$ * @version $Rev$ - * @ConQAT.Rating YELLOW Hash: DA1558F01B70802D5D0DD9A6E2411E65 + * @ConQAT.Rating GREEN Hash: 575F7A8F72757299806077E13181D372 */ public class ElementLayoutEditPolicy<T extends ILayoutedModelElement & INamedCommentedElement> extends LayoutEditPolicyBase { diff --git a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/policy/FreeResizableEditPolicy.java b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/policy/FreeResizableEditPolicy.java index d3a55ba9f..62e3f9a60 100644 --- a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/policy/FreeResizableEditPolicy.java +++ b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/policy/FreeResizableEditPolicy.java @@ -36,9 +36,10 @@ import org.fortiss.tooling.base.ui.layout.util.RectangleLayoutUtils; * @author hoelzl * @author $Author$ * @version $Rev$ - * @ConQAT.Rating YELLOW Hash: DD495DD52938CABD033D98072C8EF8DF + * @ConQAT.Rating GREEN Hash: 8F9361223B2D04A638954A22CE574C86 */ public class FreeResizableEditPolicy extends ResizableEditPolicy { + /** Constructor. */ public FreeResizableEditPolicy() { // enable resizing on east, south-east and south handles. diff --git a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/policy/LayoutEditPolicyBase.java b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/policy/LayoutEditPolicyBase.java index 91be8ac1e..d839de849 100644 --- a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/policy/LayoutEditPolicyBase.java +++ b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/policy/LayoutEditPolicyBase.java @@ -36,7 +36,7 @@ import org.fortiss.tooling.kernel.ui.util.DragAndDropUtils; * @author hoelzl * @author $Author$ * @version $Rev$ - * @ConQAT.Rating YELLOW Hash: 1123D10EB725BCC9D76B7F7322DAF5CA + * @ConQAT.Rating GREEN Hash: 6D1500C8A3A09024E500FF7DEBE8776D */ public abstract class LayoutEditPolicyBase extends LayoutEditPolicy { diff --git a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/policy/RemoveEditPolicy.java b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/policy/RemoveEditPolicy.java index 648c717f9..a0d73ff45 100644 --- a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/policy/RemoveEditPolicy.java +++ b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/policy/RemoveEditPolicy.java @@ -35,7 +35,7 @@ import org.fortiss.tooling.kernel.service.IElementCompositorService; * @author hoelzl * @author $Author$ * @version $Rev$ - * @ConQAT.Rating YELLOW Hash: 64EDE1E67D8B6F94C5B141D37A3B1B1F + * @ConQAT.Rating GREEN Hash: 88B39E781AA009BE850045A046CDC23E */ public final class RemoveEditPolicy extends ComponentEditPolicy { diff --git a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/layout/IPointLayouter.java b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/layout/IPointLayouter.java index 25232b23c..1b83cffba 100644 --- a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/layout/IPointLayouter.java +++ b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/layout/IPointLayouter.java @@ -20,13 +20,15 @@ package org.fortiss.tooling.base.ui.layout; import org.eclipse.draw2d.geometry.Point; /** + * TODO: I don't understand this comment + we do not inherit ILayouter + * * An ILayouter handles specialized layouts of points like snap to grid or move * to border. * * @author hoelzl * @author $Author$ * @version $Rev$ - * @ConQAT.Rating YELLOW Hash: 3198DA6EC6F6DB4064197E9461B2C181 + * @ConQAT.Rating RED Hash: 9E4D64CB75CDF6BCFA08098F50F4C363 */ public interface IPointLayouter { diff --git a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/layout/constants/DefaultLayoutConstants.java b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/layout/constants/DefaultLayoutConstants.java index d1edbc710..233c35a08 100644 --- a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/layout/constants/DefaultLayoutConstants.java +++ b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/layout/constants/DefaultLayoutConstants.java @@ -29,7 +29,7 @@ import org.eclipse.swt.graphics.Font; * @author wandinger * @author $Author$ * @version $Rev$ - * @ConQAT.Rating YELLOW Hash: 473078EED8B10B2D102B2604C564F0A3 + * @ConQAT.Rating GREEN Hash: 1ADDF13DA92039D5C42C0993B683A4F2 */ public final class DefaultLayoutConstants { diff --git a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/layout/constants/LayoutKeyConstants.java b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/layout/constants/LayoutKeyConstants.java index f19a1516b..673f0449f 100644 --- a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/layout/constants/LayoutKeyConstants.java +++ b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/layout/constants/LayoutKeyConstants.java @@ -30,7 +30,7 @@ package org.fortiss.tooling.base.ui.layout.constants; * @author wandinger * @author $Author$ * @version $Rev$ - * @ConQAT.Rating YELLOW Hash: 27C902A52E8959B0F07AC273EC8038DF + * @ConQAT.Rating GREEN Hash: A9C376E80AE980692442DB20A88269B9 */ public final class LayoutKeyConstants { diff --git a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/layout/util/AngleUtil.java b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/layout/util/AngleUtil.java index 26ad64f3e..239bce2a0 100644 --- a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/layout/util/AngleUtil.java +++ b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/layout/util/AngleUtil.java @@ -28,7 +28,7 @@ import org.fortiss.tooling.base.model.layout.LayoutFactory; * @author hoelzl * @author $Author$ * @version $Rev$ - * @ConQAT.Rating YELLOW Hash: 183CE3430521A9C9D9AF01E6B7D243D9 + * @ConQAT.Rating GREEN Hash: 2E92D07592321B47E50BE5DE3633D8E8 */ /* package */final class AngleUtil { diff --git a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/layout/util/DimensionUtil.java b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/layout/util/DimensionUtil.java index b15fc7554..23d97e9f7 100644 --- a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/layout/util/DimensionUtil.java +++ b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/layout/util/DimensionUtil.java @@ -28,7 +28,7 @@ import org.fortiss.tooling.base.model.layout.LayoutFactory; * @author hoelzl * @author $Author$ * @version $Rev$ - * @ConQAT.Rating YELLOW Hash: 007843C6CF423B749B1B39258C1BCB41 + * @ConQAT.Rating GREEN Hash: D5C32EC0DD697B73E8BE1FE02816876F */ /* package */final class DimensionUtil { diff --git a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/layout/util/LayoutDataUtils.java b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/layout/util/LayoutDataUtils.java index 08e6da97d..962a9f24d 100644 --- a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/layout/util/LayoutDataUtils.java +++ b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/layout/util/LayoutDataUtils.java @@ -45,7 +45,7 @@ import org.fortiss.tooling.base.ui.layout.constants.LayoutKeyConstants; * @author hummel * @author $Author$ * @version $Rev$ - * @ConQAT.Rating YELLOW Hash: 4B5CA7ECC0803744F20556EE5113D44A + * @ConQAT.Rating GREEN Hash: 38D5D68A699DB31A9E3691D250641588 */ public class LayoutDataUtils { diff --git a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/layout/util/OffsetOrientationUtil.java b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/layout/util/OffsetOrientationUtil.java index c5351ea94..ee8a990d2 100644 --- a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/layout/util/OffsetOrientationUtil.java +++ b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/layout/util/OffsetOrientationUtil.java @@ -31,7 +31,7 @@ import org.fortiss.tooling.base.model.layout.Orientation; * @author hoelzl * @author $Author$ * @version $Rev$ - * @ConQAT.Rating YELLOW Hash: 599F1F9262B1714FC580C9B8A1F945C7 + * @ConQAT.Rating GREEN Hash: CB7A6378410128772C9D2687A4682FA4 */ /* package */final class OffsetOrientationUtil { diff --git a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/layout/util/PointUtil.java b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/layout/util/PointUtil.java index 27674fff9..01f611c96 100644 --- a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/layout/util/PointUtil.java +++ b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/layout/util/PointUtil.java @@ -25,6 +25,9 @@ import org.fortiss.tooling.base.model.layout.LayoutFactory; import org.fortiss.tooling.base.model.layout.Point; /** + * TODO: What is the difference between {@link PointUtil} and {@link PointsUtil} + * ? + * * Utility class for handling {@link Point} layout data. * * @author hoelzl diff --git a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/layout/util/PointsUtil.java b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/layout/util/PointsUtil.java index 8d740d8bb..48a35abec 100644 --- a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/layout/util/PointsUtil.java +++ b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/layout/util/PointsUtil.java @@ -24,12 +24,15 @@ import org.fortiss.tooling.base.model.layout.Point; import org.fortiss.tooling.base.model.layout.Points; /** + * TODO: What is the difference between {@link PointUtil} and {@link PointsUtil} + * ? + * * Utility class for {@link Points} layout data. * * @author hoelzl * @author $Author$ * @version $Rev$ - * @ConQAT.Rating YELLOW Hash: 67B35E9BB1202928191456CDEA7D00FD + * @ConQAT.Rating GREEN Hash: 1BF8F215A3DAA9B28B98088EE369162A */ /* package */final class PointsUtil { diff --git a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/layout/util/SnapToGridUtils.java b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/layout/util/SnapToGridUtils.java index 0278a35e9..2ccf324cb 100644 --- a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/layout/util/SnapToGridUtils.java +++ b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/layout/util/SnapToGridUtils.java @@ -28,7 +28,7 @@ import org.fortiss.tooling.base.ui.layout.constants.DefaultLayoutConstants; * @author hoelzl * @author $Author$ * @version $Rev$ - * @ConQAT.Rating YELLOW Hash: 864E908FB1B86BFCA206640785FAB8D0 + * @ConQAT.Rating GREEN Hash: EEE21E715A74AC8326AF6F81DC92DCD4 */ public final class SnapToGridUtils { diff --git a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/layout/util/ZoomUtils.java b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/layout/util/ZoomUtils.java index 8d44ce72d..63b0b01e4 100644 --- a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/layout/util/ZoomUtils.java +++ b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/layout/util/ZoomUtils.java @@ -28,7 +28,7 @@ import org.eclipse.gef.requests.ChangeBoundsRequest; * @author hummel * @author $Author$ * @version $Rev$ - * @ConQAT.Rating YELLOW Hash: 990CC0C860163174B266FAE75C2B3197 + * @ConQAT.Rating GREEN Hash: 57E5F4C587CD015E3B85AC0666F7BA44 */ public class ZoomUtils { diff --git a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/preferences/GraphicalViewerPreferencePage.java b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/preferences/GraphicalViewerPreferencePage.java index 3e065113c..3a5677ad3 100644 --- a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/preferences/GraphicalViewerPreferencePage.java +++ b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/preferences/GraphicalViewerPreferencePage.java @@ -31,7 +31,7 @@ import org.fortiss.tooling.base.ui.editpart.figure.EVisualStyle; * @author hoelzl * @author $Author$ * @version $Rev$ - * @ConQAT.Rating YELLOW Hash: A4BF19B04F9E2FCCB5439FE5A029BBBA + * @ConQAT.Rating GREEN Hash: F2CDD837F99C0C706488E9DE16350173 */ public class GraphicalViewerPreferencePage extends FieldEditorPreferencePage implements IWorkbenchPreferencePage { diff --git a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/preferences/MainPreferencePage.java b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/preferences/MainPreferencePage.java index d721cb528..d3d23548c 100644 --- a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/preferences/MainPreferencePage.java +++ b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/preferences/MainPreferencePage.java @@ -29,7 +29,7 @@ import org.fortiss.tooling.base.ui.ToolingBaseUIActivator; * @author hoelzlf * @author $Author$ * @version $Rev$ - * @ConQAT.Rating YELLOW Hash: 6B7E44F27214D28ABD5CE7B961495A60 + * @ConQAT.Rating GREEN Hash: 624CDE136F603C9004BFFDB01D3728DE */ public class MainPreferencePage extends FieldEditorPreferencePage implements IWorkbenchPreferencePage { diff --git a/org.fortiss.tooling.base/trunk/model/generate-ecore.xml b/org.fortiss.tooling.base/trunk/model/generate-ecore.xml index e055284dd..556b1947c 100644 --- a/org.fortiss.tooling.base/trunk/model/generate-ecore.xml +++ b/org.fortiss.tooling.base/trunk/model/generate-ecore.xml @@ -2,7 +2,7 @@ <!-- $Id$ @version $Rev$ - @ConQAT.Rating YELLOW Hash: 684482CCEB1D9551CEEA631D34E66CFB + @ConQAT.Rating GREEN Hash: 547B92CC3BA83267CAA7EB4AB320F6EB --> <project name="org.fortiss.tooling.base" default="generate-ecore" basedir=".."> diff --git a/org.fortiss.tooling.base/trunk/src/org/fortiss/tooling/base/ToolingBaseActivator.java b/org.fortiss.tooling.base/trunk/src/org/fortiss/tooling/base/ToolingBaseActivator.java index 7b6defbf0..64e7b1018 100644 --- a/org.fortiss.tooling.base/trunk/src/org/fortiss/tooling/base/ToolingBaseActivator.java +++ b/org.fortiss.tooling.base/trunk/src/org/fortiss/tooling/base/ToolingBaseActivator.java @@ -26,7 +26,7 @@ import org.osgi.framework.BundleContext; * @author hoelzl * @author $Author$ * @version $Rev$ - * @ConQAT.Rating YELLOW Hash: 5C875862B62D7463965C14A53088735B + * @ConQAT.Rating GREEN Hash: D4F9C27D52B2E1B698A3951BEE7C67A1 */ public class ToolingBaseActivator extends Plugin { -- GitLab