From 4e1e362feefdf23a6d5a151b3a9b269912e492cc Mon Sep 17 00:00:00 2001
From: Simon Barner <barner@fortiss.org>
Date: Wed, 2 Nov 2016 11:59:56 +0000
Subject: [PATCH] - Revert previous change since it resulted into SWT "Widget
is disposed" exceptions - Performed some refactoring (no functional change)
and added documentation refs 2709
---
.../tooling/kernel/ui/internal/views/MarkerViewPart.java | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/views/MarkerViewPart.java b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/views/MarkerViewPart.java
index e31b663bf..25b48384d 100644
--- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/views/MarkerViewPart.java
+++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/views/MarkerViewPart.java
@@ -40,7 +40,6 @@ import org.eclipse.swt.graphics.Image;
import org.eclipse.swt.layout.FillLayout;
import org.eclipse.swt.widgets.Composite;
import org.eclipse.ui.part.ViewPart;
-import org.eclipse.wb.swt.ResourceManager;
import org.fortiss.tooling.kernel.extension.data.IConstraintViolation;
import org.fortiss.tooling.kernel.extension.data.IConstraintViolation.ESeverity;
import org.fortiss.tooling.kernel.service.IPersistencyService;
@@ -55,7 +54,7 @@ import org.fortiss.tooling.kernel.ui.service.IModelElementHandlerService;
* @author hoelzl
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: 0B397D9F1501CDBECCF10925257AB363
+ * @ConQAT.Rating YELLOW Hash: 9632DD179445E13A7C49B222BAB96A84
*/
public class MarkerViewPart extends ViewPart {
@@ -95,9 +94,10 @@ public class MarkerViewPart extends ViewPart {
if(oldImage != null) {
oldImage.dispose();
}
- final ImageDescriptor imageDescr =
+ final ImageDescriptor imageDescriptor =
IMarkerService.getInstance().getImageFor(severity, false);
- cell.setImage(ResourceManager.getImage(imageDescr));
+ // Private copy of image is required is it is owned (and disposed) by the cell
+ cell.setImage(imageDescriptor.createImage());
} else {
cell.setText("");
}
--
GitLab