From 5364084652d8a553c403746c5ee9fa2d48917bc2 Mon Sep 17 00:00:00 2001
From: Florian Hoelzl <hoelzl@fortiss.org>
Date: Wed, 4 Jan 2012 13:08:13 +0000
Subject: [PATCH] review => RED refs 311
---
.../extension/base/ContextMenuSubMenuContributorBase.java | 5 +++++
.../tooling/kernel/ui/extension/base/MenuActionBase.java | 6 ++++++
2 files changed, 11 insertions(+)
diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/base/ContextMenuSubMenuContributorBase.java b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/base/ContextMenuSubMenuContributorBase.java
index a7ca46be3..264c8c3f4 100644
--- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/base/ContextMenuSubMenuContributorBase.java
+++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/base/ContextMenuSubMenuContributorBase.java
@@ -39,7 +39,11 @@ import org.fortiss.tooling.kernel.ui.service.IContextMenuService;
* {@link IMenuManager} with actions provided by actions factories
* {@link ActionFactory} returned by {@link #getActionFactories()}.
*
+ * TODO @review This class implements its interface with default values, e.g.
+ * getMenuSectionID. This should be documented here. See ModelElementHandlerBase
+ * for example.
* <p>
+ * TODO @review What is or where is <T> here?
*
* The generic type parameter {@code T} indicated the type of selection
* elements.
@@ -54,6 +58,7 @@ public abstract class ContextMenuSubMenuContributorBase implements
/** Constructor. */
public ContextMenuSubMenuContributorBase() {
+ // TODO @review unnecessary contructor
super();
}
diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/base/MenuActionBase.java b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/base/MenuActionBase.java
index f50cd2f18..54eafff98 100644
--- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/base/MenuActionBase.java
+++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/base/MenuActionBase.java
@@ -28,9 +28,14 @@ import org.eclipse.jface.resource.ImageDescriptor;
* @version $Rev: 1907 $
* @ConQAT.Rating YELLOW Hash: CD9CF8D6200B156E8C0EE759A512A76E
*/
+// TODO @review: this class looks very similar to EObjectActionBase; why do we
+// need it?
+// TODO @review: what is <T>; document generic parameters in class comment.
public abstract class MenuActionBase<T> extends Action {
/** Factory for the action instances used for this menu */
+ // TODO @review: why this interface? Why not
+ // org.eclipse.ui.actions.ActionFactory?
public static interface ActionFactory<T> {
/** Creates and returns an action instance for the given target. */
MenuActionBase<T> createAction(T target);
@@ -39,6 +44,7 @@ public abstract class MenuActionBase<T> extends Action {
/** The target to be processed. */
protected final T target;
+ // TODO @review: why these methods? there are constructors.
/** Name of the action. */
protected abstract String getActionName();
--
GitLab