From 5c2c51695814ef75ab3fdc6d2d619a204a0aff73 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Christoph=20D=C3=B6bber?= <doebber@in.tum.de>
Date: Wed, 4 Jan 2012 14:02:58 +0000
Subject: [PATCH] kernel.ui review
---
.../org/fortiss/tooling/kernel/ui/internal/ActionService.java | 2 +-
.../org/fortiss/tooling/kernel/ui/internal/MarkerService.java | 3 ++-
.../tooling/kernel/ui/internal/ModelEditorBindingService.java | 2 +-
.../tooling/kernel/ui/internal/ModelElementHandlerService.java | 2 +-
4 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/ActionService.java b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/ActionService.java
index b506e5426..85d544d9b 100644
--- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/ActionService.java
+++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/ActionService.java
@@ -44,7 +44,7 @@ import org.fortiss.tooling.kernel.ui.util.EObjectSelectionUtils;
* @author hoelzlf
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: AEE7A59A21CE5A68CAC3BC04EF872569
+ * @ConQAT.Rating GREEN Hash: B033E4456F7E06AC68BDC015C379828D
*/
public class ActionService implements IActionService,
IPersistencyServiceListener, CommandStackListener {
diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/MarkerService.java b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/MarkerService.java
index 7850cef4b..1aeb56c61 100644
--- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/MarkerService.java
+++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/MarkerService.java
@@ -53,7 +53,7 @@ import org.fortiss.tooling.kernel.ui.service.IMarkerService;
* @author hoelzl
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: 463B8B4054B09A79D1A87DC2F77A813B
+ * @ConQAT.Rating RED Hash: 14D6FBDEDFCCB59B545EEF873D46DAC9
*/
public class MarkerService implements IMarkerService,
IPersistencyServiceListener, ILightweightLabelDecorator {
@@ -214,6 +214,7 @@ public class MarkerService implements IMarkerService,
// use preferences settings here
switch (highest) {
case FATAL:
+ // TODO @Review CD: missing break and default behavior.
case ERROR:
decoration.addOverlay(ESharedImages.ERROR_OVERLAY
.getImageDescriptor());
diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/ModelEditorBindingService.java b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/ModelEditorBindingService.java
index b9fb2c513..4e13cf194 100644
--- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/ModelEditorBindingService.java
+++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/ModelEditorBindingService.java
@@ -53,7 +53,7 @@ import org.fortiss.tooling.kernel.utils.LoggingUtils;
* @author hoelzl
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: B22AF6BFF05488F229A48209695AF5F9
+ * @ConQAT.Rating GREEN Hash: 5D8E3357E3B8F103A782BBD7096D5616
*/
public class ModelEditorBindingService extends
EObjectAwareServiceBase<IModelEditorBinding<EObject>> implements
diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/ModelElementHandlerService.java b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/ModelElementHandlerService.java
index 8538db3eb..63e807886 100644
--- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/ModelElementHandlerService.java
+++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/ModelElementHandlerService.java
@@ -35,7 +35,7 @@ import org.fortiss.tooling.kernel.utils.LoggingUtils;
* @author hoelzl
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: 12259D6B9163AFDDACC1B14FF407BE50
+ * @ConQAT.Rating GREEN Hash: 074E65AEBD71DD87A0C35D0D401F924E
*/
public class ModelElementHandlerService extends
EObjectAwareServiceBase<IModelElementHandler<EObject>> implements
--
GitLab