From 629c6d1372e83bca56c2720d9e0bc827c95118a1 Mon Sep 17 00:00:00 2001
From: Daniel Ratiu <ratiu@fortiss.org>
Date: Tue, 28 Jun 2011 07:31:00 +0000
Subject: [PATCH] code reviews
---
.../org/fortiss/tooling/kernel/ui/base/EObjectActionBase.java | 2 +-
.../src/org/fortiss/tooling/kernel/ui/base/EditorBase.java | 2 +-
.../fortiss/tooling/kernel/ui/base/ModelElementHandlerBase.java | 1 +
.../kernel/ui/base/NamedCommentedModelElementHandlerBase.java | 2 +-
.../org/fortiss/tooling/kernel/ui/base/PropertySectionBase.java | 1 +
.../tooling/kernel/ui/databinding/EObjectObservableValue.java | 2 +-
.../org/fortiss/tooling/kernel/ui/databinding/Observables.java | 2 +-
.../src/org/fortiss/tooling/kernel/ui/databinding/package.html | 2 +-
8 files changed, 8 insertions(+), 6 deletions(-)
diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/base/EObjectActionBase.java b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/base/EObjectActionBase.java
index 8408679ce..1548f6770 100644
--- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/base/EObjectActionBase.java
+++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/base/EObjectActionBase.java
@@ -27,7 +27,7 @@ import org.eclipse.jface.resource.ImageDescriptor;
* @author hoelzlf
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: 39A7CCEBD43D310CCB0F78BF6714E3AE
+ * @ConQAT.Rating GREEN Hash: 827FFC915A61A58BA1E8D6A70D51D197
*/
public abstract class EObjectActionBase extends Action {
diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/base/EditorBase.java b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/base/EditorBase.java
index 333c3993a..a11bddba8 100644
--- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/base/EditorBase.java
+++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/base/EditorBase.java
@@ -38,7 +38,7 @@ import org.fortiss.tooling.kernel.ui.internal.editor.ModelElementEditorInput;
* @author hoelzlf
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: 468A589E32DF24EEF966B06649887E03
+ * @ConQAT.Rating GREEN Hash: 73A4C3200D46DC571C694AD3A5B811BA
*/
public abstract class EditorBase<T extends EObject> extends EditorPart
implements IActionContributingEditor {
diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/base/ModelElementHandlerBase.java b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/base/ModelElementHandlerBase.java
index 99f8df5ee..a43fe2097 100644
--- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/base/ModelElementHandlerBase.java
+++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/base/ModelElementHandlerBase.java
@@ -36,6 +36,7 @@ import org.fortiss.tooling.kernel.ui.interfaces.IModelElementHandler;
public abstract class ModelElementHandlerBase<T extends EObject> implements
IModelElementHandler<T> {
+ // @TODO: why 'singleton' ?
/** Stores the singleton of the icon image. */
private Image iconImage;
diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/base/NamedCommentedModelElementHandlerBase.java b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/base/NamedCommentedModelElementHandlerBase.java
index 05bc93716..f94779f9b 100644
--- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/base/NamedCommentedModelElementHandlerBase.java
+++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/base/NamedCommentedModelElementHandlerBase.java
@@ -27,7 +27,7 @@ import org.fortiss.tooling.kernel.ui.interfaces.IModelElementHandler;
* @author hoelzlf
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: 55120D889569756A57306BB1E5624DA8
+ * @ConQAT.Rating GREEN Hash: BAD6146F064C56919E4CB05338327D32
*/
public abstract class NamedCommentedModelElementHandlerBase<T extends INamedCommentedElement>
extends ModelElementHandlerBase<T> {
diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/base/PropertySectionBase.java b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/base/PropertySectionBase.java
index 761a02acf..81c1b46fe 100644
--- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/base/PropertySectionBase.java
+++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/base/PropertySectionBase.java
@@ -90,6 +90,7 @@ public abstract class PropertySectionBase extends AbstractPropertySection {
/** This is used to set the single section input. The parameter may be null! */
protected abstract void setSectionInput(Object input);
+ // @TODO: missing the implementation
/**
* Creates a text widget, which has a {@link ControlDecoration} attached.
* The decoration is stored as widget data for convenience.
diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/databinding/EObjectObservableValue.java b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/databinding/EObjectObservableValue.java
index 6906a3d78..1409f70cf 100644
--- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/databinding/EObjectObservableValue.java
+++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/databinding/EObjectObservableValue.java
@@ -38,7 +38,7 @@ import org.fortiss.tooling.kernel.services.ICommandStackService;
* @author hummel
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: FF1D7244CAF1F42A0CDCD95FA05EF519
+ * @ConQAT.Rating GREEN Hash: 7D915ADC82815E040E4685528FED4C7E
*/
public class EObjectObservableValue extends AbstractObservableValue {
diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/databinding/Observables.java b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/databinding/Observables.java
index 230bae259..ab4a5a430 100644
--- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/databinding/Observables.java
+++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/databinding/Observables.java
@@ -29,7 +29,7 @@ import org.eclipse.emf.ecore.EStructuralFeature;
* @author hummel
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: 1F057C79CD5F9FFAC36A9B899B5D5FA6
+ * @ConQAT.Rating GREEN Hash: 714FEC022718BEA0D783DC7A39A08742
*/
public class Observables {
diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/databinding/package.html b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/databinding/package.html
index 0dbc6d133..e6cd7c225 100644
--- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/databinding/package.html
+++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/databinding/package.html
@@ -1,7 +1,7 @@
<!--
$Id$
@version $Rev$
- @ConQAT.Rating YELLOW Hash: 58C4BAD95DB2861023A4A0727E144297
+ @ConQAT.Rating GREEN Hash: 996283773B2EC0D22D4A844A3C9E30A8
-->
<body>
Support classes for using the data binding mechanism with EMF EObjects.
--
GitLab