From 68fadfab21c267ccc243e8ae998a861565f2742a Mon Sep 17 00:00:00 2001
From: Vincent Aravantinos <aravantinos@fortiss.org>
Date: Tue, 14 Nov 2017 10:05:59 +0000
Subject: [PATCH] GREEN
---
.../allocation/AllocationConnectionEditPartBase.java | 2 +-
.../allocation/AllocationSubDiagramEditPartBase.java | 6 ++++--
...AllocationDirectConnectionAndReconnectionEditPolicy.java | 2 +-
.../fortiss/tooling/base/ui/utils/DragAndDropBaseUtils.java | 2 +-
4 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/allocation/AllocationConnectionEditPartBase.java b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/allocation/AllocationConnectionEditPartBase.java
index b5ee93991..63a536343 100644
--- a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/allocation/AllocationConnectionEditPartBase.java
+++ b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/allocation/AllocationConnectionEditPartBase.java
@@ -29,7 +29,7 @@ import org.fortiss.tooling.base.ui.layout.IDiagramLayoutConfiguration;
* @author $Author: hoelzl $
* @version $Rev: 18709 $
* @param <T>
- * @ConQAT.Rating YELLOW Hash: 268DD09BF527D2CCD78FAFCB933C0D85
+ * @ConQAT.Rating GREEN Hash: 46E2D8D9E24BE02BEC398AD9F361C247
*/
public abstract class AllocationConnectionEditPartBase<T extends ConnectionSegmentBase> extends
ConnectionEditPartBase<T> {
diff --git a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/allocation/AllocationSubDiagramEditPartBase.java b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/allocation/AllocationSubDiagramEditPartBase.java
index 43d551359..2485868f5 100644
--- a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/allocation/AllocationSubDiagramEditPartBase.java
+++ b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/allocation/AllocationSubDiagramEditPartBase.java
@@ -72,7 +72,7 @@ import org.fortiss.tooling.kernel.utils.EcoreUtils;
* @author $Author: hoelzl $
* @version $Rev: 18709 $
* @param <T>
- * @ConQAT.Rating GREEN Hash: CEE547DE8E92222EAAE1BD3287CBDC30
+ * @ConQAT.Rating GREEN Hash: C5890B9D68C30A8A8937EB5FD1C97672
*/
public abstract class AllocationSubDiagramEditPartBase<T extends INamedCommentedElement> extends
GraphicalEditPartBase<T> implements NodeEditPart {
@@ -380,7 +380,9 @@ public abstract class AllocationSubDiagramEditPartBase<T extends INamedCommented
if(req.getExtendedData().isEmpty()) {
// sub diagram background selection works only with hierarchical elements
if(!modelChildren.isEmpty()) {
- // TODO(VA) get(0)
+ // get(0): There is at least one modelChildren due to the guard above, and it is
+ // relevant to use the first one because we pick any of them just to access the
+ // parent.
Object object = modelChildren.get(0);
IHierarchicElement parentElement =
getParentElement((EObject)object, IHierarchicElement.class, false);
diff --git a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/policy/AllocationDirectConnectionAndReconnectionEditPolicy.java b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/policy/AllocationDirectConnectionAndReconnectionEditPolicy.java
index 20f4e6761..86620fd11 100644
--- a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/policy/AllocationDirectConnectionAndReconnectionEditPolicy.java
+++ b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/policy/AllocationDirectConnectionAndReconnectionEditPolicy.java
@@ -32,7 +32,7 @@ import org.fortiss.tooling.base.ui.editpart.command.AllocationConnectCommand;
* @author eder
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating GREEN Hash: 3FD699A85C20C4AD2D96DBC2B4D3D8ED
+ * @ConQAT.Rating GREEN Hash: F046FCF2D9910D9CCFDD62C15A330802
*/
public class AllocationDirectConnectionAndReconnectionEditPolicy extends
DirectConnectionAndReconnectionEditPolicy {
diff --git a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/utils/DragAndDropBaseUtils.java b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/utils/DragAndDropBaseUtils.java
index 09e7dfefa..ddfb7a20b 100644
--- a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/utils/DragAndDropBaseUtils.java
+++ b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/utils/DragAndDropBaseUtils.java
@@ -34,7 +34,7 @@ import org.fortiss.tooling.kernel.extension.data.IConnectionCompositionContext;
* @author diewald
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating GREEN Hash: 824388D4F78A6E57DA6AB343F2FCECD6
+ * @ConQAT.Rating GREEN Hash: DB80C6A65E4242B9EC6D93E90A89E2BB
*/
public class DragAndDropBaseUtils {
--
GitLab