diff --git a/org.fortiss.tooling.base.ui/src/org/fortiss/tooling/base/ui/javafx/control/treetableview/.ratings b/org.fortiss.tooling.base.ui/src/org/fortiss/tooling/base/ui/javafx/control/treetableview/.ratings index d17f3c38d4701582e8122a7fc31cec5d32f004d4..fa2968f9f986ed98ed40e29f5418fc88f66e022d 100644 --- a/org.fortiss.tooling.base.ui/src/org/fortiss/tooling/base/ui/javafx/control/treetableview/.ratings +++ b/org.fortiss.tooling.base.ui/src/org/fortiss/tooling/base/ui/javafx/control/treetableview/.ratings @@ -1 +1 @@ -ModelElementTreeViewer.java d8443481e634347b0c533f23d0ae65e312b658f6 YELLOW +ModelElementTreeViewer.java 44744e6b11264547bd6b05a84a427948bf919969 RED diff --git a/org.fortiss.tooling.base.ui/src/org/fortiss/tooling/base/ui/javafx/control/treetableview/ModelElementTreeViewer.java b/org.fortiss.tooling.base.ui/src/org/fortiss/tooling/base/ui/javafx/control/treetableview/ModelElementTreeViewer.java index d8443481e634347b0c533f23d0ae65e312b658f6..44744e6b11264547bd6b05a84a427948bf919969 100644 --- a/org.fortiss.tooling.base.ui/src/org/fortiss/tooling/base/ui/javafx/control/treetableview/ModelElementTreeViewer.java +++ b/org.fortiss.tooling.base.ui/src/org/fortiss/tooling/base/ui/javafx/control/treetableview/ModelElementTreeViewer.java @@ -15,6 +15,8 @@ +--------------------------------------------------------------------------*/ package org.fortiss.tooling.base.ui.javafx.control.treetableview; +import static javafx.embed.swt.SWTFXUtils.toFXImage; + import org.fortiss.tooling.base.model.element.IHierarchicElement; import org.fortiss.tooling.base.model.element.IModelElement; import org.fortiss.tooling.common.ui.javafx.control.treetableview.DynamicTreeContentProviderBase; @@ -23,18 +25,18 @@ import org.fortiss.tooling.common.ui.javafx.control.treetableview.DynamicTreeVie import org.fortiss.tooling.kernel.model.INamedCommentedElement; import org.fortiss.tooling.kernel.ui.service.IModelElementHandlerService; -import javafx.embed.swt.SWTFXUtils; import javafx.scene.Node; import javafx.scene.control.ContextMenu; import javafx.scene.control.TreeView; import javafx.scene.image.Image; import javafx.scene.image.ImageView; +// TODO (SB, indicate what is the propose of the TreeView) /** * TreeViewer that constructs a DynamicTreeViewer whose UI provider uses the methods and kernel * services for {@link IHierarchicElement}s and {@link INamedCommentedElement}s. - * The Viewer uses a composition principle where a client must provide {@link TreeView} (JavaFX), a - * root element (AF3), and a content provider that selects the elements to be displayed. + * The Viewer uses a composition principle where a client must provide a {@link TreeView} (JavaFX), + * a root element (AF3), and a content provider that selects the elements to be displayed. * * @author diewald */ @@ -56,7 +58,8 @@ public class ModelElementTreeViewer<T extends IModelElement & INamedCommentedEle * {@link IHierarchicElement}s. It also uses the {@link IModelElementHandlerService} for a nicer * visual appearance. * <p> - * Externalize this method into a class when subclassing seems appropriate. + * TODO(SB, unclear) + * Externalizing this method into a class when subclassing seems appropriate. * * @return The constructed UI Provider. */ @@ -75,7 +78,7 @@ public class ModelElementTreeViewer<T extends IModelElement & INamedCommentedEle org.eclipse.swt.graphics.Image icon = IModelElementHandlerService.getInstance().getIcon(element); if(icon != null) { - Image fxImage = SWTFXUtils.toFXImage(icon.getImageData(), null); + Image fxImage = toFXImage(icon.getImageData(), null); return new ImageView(fxImage); } return null;