From 7883ffc5a7167698b94c7bf2e55ab32cd9f2c1da Mon Sep 17 00:00:00 2001
From: Simon Barner <barner@fortiss.org>
Date: Tue, 19 Jun 2018 15:34:46 +0200
Subject: [PATCH] RED (Base MM review)
* Mark ConstraintInstanceContainer deprecated
* Add TODOs for metaclasses related to constraints.
Issue-Ref: 3401
Issue-Url: https://af3-developer.fortiss.org/issues/3401
Signed-off-by: Simon Barner <barner@fortiss.org>
---
org.fortiss.tooling.base/model/.ratings | 2 +-
org.fortiss.tooling.base/model/base.ecore | 12 ++++++++----
2 files changed, 9 insertions(+), 5 deletions(-)
diff --git a/org.fortiss.tooling.base/model/.ratings b/org.fortiss.tooling.base/model/.ratings
index d04c46eba..a010f8f18 100644
--- a/org.fortiss.tooling.base/model/.ratings
+++ b/org.fortiss.tooling.base/model/.ratings
@@ -1 +1 @@
-base.ecore 3d98f771fef61c067b2722c1bdf401f5b533ce37 RED
+base.ecore c656c35978afc6ea540440c2f47f45d360cc35b6 RED
diff --git a/org.fortiss.tooling.base/model/base.ecore b/org.fortiss.tooling.base/model/base.ecore
index 3d98f771f..c656c3597 100644
--- a/org.fortiss.tooling.base/model/base.ecore
+++ b/org.fortiss.tooling.base/model/base.ecore
@@ -190,7 +190,7 @@
<eClassifiers xsi:type="ecore:EClass" name="IConstraintBasedProcess" abstract="true"
interface="true">
<eAnnotations source="http://www.eclipse.org/emf/2002/GenModel">
- <details key="documentation" value="Marker interface for metaclasses to describe constraint-based development processes."/>
+ <details key="documentation" value="Marker interface for metaclasses to describe constraint-based development processes.

TODO: Clarify relation to constraint metaclasses in tooling.kernel."/>
</eAnnotations>
<eStructuralFeatures xsi:type="ecore:EReference" name="currentObjective" eType="#//element/ConstraintConfiguration">
<eAnnotations source="http://www.eclipse.org/emf/2002/GenModel">
@@ -212,7 +212,7 @@
</eClassifiers>
<eClassifiers xsi:type="ecore:EClass" name="ConstraintConfiguration" eSuperTypes="platform:/resource/org.fortiss.tooling.kernel/model/kernel.ecore#//INamedElement">
<eAnnotations source="http://www.eclipse.org/emf/2002/GenModel">
- <details key="documentation" value="Hierarchical description of constraint configuration."/>
+ <details key="documentation" value="Hierarchical description of constraint configuration.

TODO: Clarify relation to constraint metaclasses in tooling.kernel."/>
</eAnnotations>
<eStructuralFeatures xsi:type="ecore:EAttribute" name="activeConstraints" upperBound="-1"
eType="ecore:EDataType http://www.eclipse.org/emf/2002/Ecore#//EString">
@@ -504,10 +504,14 @@
<eTypeArguments eTypeParameter="#//base/DerivedAnnotationBase/T"/>
</eGenericSuperTypes>
</eClassifiers>
- <eClassifiers xsi:type="ecore:EClass" name="ConstraintInstanceContainer" eSuperTypes="platform:/resource/org.fortiss.tooling.kernel/model/kernel.ecore#//constraints/IConstraintInstanceContainer"/>
+ <eClassifiers xsi:type="ecore:EClass" name="ConstraintInstanceContainer" eSuperTypes="platform:/resource/org.fortiss.tooling.kernel/model/kernel.ecore#//constraints/IConstraintInstanceContainer">
+ <eAnnotations source="http://www.eclipse.org/emf/2002/GenModel">
+ <details key="documentation" value="@deprecated Currently unused. TODO Caveat: Base class is defined in tooling.kernel."/>
+ </eAnnotations>
+ </eClassifiers>
<eClassifiers xsi:type="ecore:EClass" name="ConstraintBasedProcess" eSuperTypes="#//element/IConstraintBasedProcess">
<eAnnotations source="http://www.eclipse.org/emf/2002/GenModel">
- <details key="documentation" value="Base class for {@link IConstraintBasedProcess}es."/>
+ <details key="documentation" value="Base class for {@link IConstraintBasedProcess}es.

TODO: Clarify relation to constraint metaclasses in tooling.kernel."/>
</eAnnotations>
</eClassifiers>
</eSubpackages>
--
GitLab