From 8544ec290169e65593b17cf4c10e87789c1452fb Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Christoph=20D=C3=B6bber?= <doebber@in.tum.de>
Date: Mon, 9 Jan 2012 14:29:06 +0000
Subject: [PATCH] reviewed portion of tooling.base.ui refs 311
---
.../ui/editpart/command/ChangeBoundsRequestCommandBase.java | 2 +-
.../tooling/base/ui/editpart/command/ConnectCommand.java | 2 +-
.../base/ui/editpart/command/MoveWithinDiagramCommand.java | 2 +-
.../base/ui/editpart/command/MoveWithinElementCommand.java | 2 +-
.../tooling/base/ui/editpart/command/ReconnectCommand.java | 4 +++-
.../tooling/base/ui/editpart/command/RemoveCommand.java | 2 +-
6 files changed, 8 insertions(+), 6 deletions(-)
diff --git a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/command/ChangeBoundsRequestCommandBase.java b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/command/ChangeBoundsRequestCommandBase.java
index d9b6d7326..7b8fee978 100644
--- a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/command/ChangeBoundsRequestCommandBase.java
+++ b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/command/ChangeBoundsRequestCommandBase.java
@@ -28,7 +28,7 @@ import org.eclipse.gef.requests.ChangeBoundsRequest;
* @author hoelzl
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: C9178C428EEB9D5F404EAF7BF1A0AC07
+ * @ConQAT.Rating GREEN Hash: B69AF7C192C2DA85F62E392EFED666F4
*/
public abstract class ChangeBoundsRequestCommandBase extends Command {
/** The creation request */
diff --git a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/command/ConnectCommand.java b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/command/ConnectCommand.java
index ca99c8f3e..87c3258c5 100644
--- a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/command/ConnectCommand.java
+++ b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/command/ConnectCommand.java
@@ -33,7 +33,7 @@ import org.fortiss.tooling.kernel.service.IConnectionCompositorService;
* @author hoelzl
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: 7791FA91BCC608A8043C019544D34B42
+ * @ConQAT.Rating GREEN Hash: 032DFA20DC9449DB023C623C5B467635
*/
public class ConnectCommand extends Command {
diff --git a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/command/MoveWithinDiagramCommand.java b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/command/MoveWithinDiagramCommand.java
index a25e266be..e2513c618 100644
--- a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/command/MoveWithinDiagramCommand.java
+++ b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/command/MoveWithinDiagramCommand.java
@@ -33,7 +33,7 @@ import org.fortiss.tooling.base.ui.utils.LayoutDataUtils;
* @author hoelzl
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: B6F68F3F16FCCB14CEA9010FAF6E9253
+ * @ConQAT.Rating GREEN Hash: D77509B4DC3030D691C452F0365C364E
*/
public class MoveWithinDiagramCommand extends ChangeBoundsRequestCommandBase {
diff --git a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/command/MoveWithinElementCommand.java b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/command/MoveWithinElementCommand.java
index e15a15d19..605f5c31d 100644
--- a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/command/MoveWithinElementCommand.java
+++ b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/command/MoveWithinElementCommand.java
@@ -31,7 +31,7 @@ import org.fortiss.tooling.base.ui.editpart.StickyConnectorEditPartBase;
* @author hoelzl
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: 0A679B93BB27E11F9524222C9BB74AAA
+ * @ConQAT.Rating GREEN Hash: 930132173F760C9E1EDB5B98F71C0494
*/
public class MoveWithinElementCommand extends ChangeBoundsRequestCommandBase {
diff --git a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/command/ReconnectCommand.java b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/command/ReconnectCommand.java
index 135eb5377..8840b6cb1 100644
--- a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/command/ReconnectCommand.java
+++ b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/command/ReconnectCommand.java
@@ -31,7 +31,7 @@ import org.fortiss.tooling.kernel.service.IConnectionCompositorService;
* @author hoelzl
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: C792E06111B81A009ED464F85FA83E90
+ * @ConQAT.Rating RED Hash: 014CBB9569896D0AA2554DE850E8F91E
*/
public class ReconnectCommand extends ConnectCommand {
@@ -54,6 +54,8 @@ public class ReconnectCommand extends ConnectCommand {
}
if (context.getSource().getModel() instanceof EObject
&& context.getTarget().getModel() instanceof EObject
+ // TODO @review CD: why check source's parent? - C&P from
+ // Connect?
&& context.getSource().getParent().getModel() instanceof EObject) {
return IConnectionCompositorService.INSTANCE.canReconnect(
connection, (EObject) context.getSource().getModel(),
diff --git a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/command/RemoveCommand.java b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/command/RemoveCommand.java
index 0d03b1e5f..a8d6abd0e 100644
--- a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/command/RemoveCommand.java
+++ b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/command/RemoveCommand.java
@@ -28,7 +28,7 @@ import org.fortiss.tooling.kernel.service.IElementCompositorService;
* @author hoelzl
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: D5B0D83636D2C71A946182020FBD15CB
+ * @ConQAT.Rating GREEN Hash: 1538EA3CEED7E1A44E6AEFAD983D31B8
*/
public class RemoveCommand extends Command {
/** The entity to be removed. */
--
GitLab