From 876330049965abc304c53d01900ac6b90a9078fd Mon Sep 17 00:00:00 2001 From: Dongyue Mou <mou@fortiss.org> Date: Thu, 2 Feb 2012 08:53:20 +0000 Subject: [PATCH] code reviewed refs 511 --- .../tooling/base/ui/editpart/ConnectionEditPartBase.java | 2 +- .../org/fortiss/tooling/kernel/ToolingKernelActivator.java | 2 +- .../tooling/kernel/extension/data/IConstraintViolation.java | 2 +- .../tooling/kernel/internal/ConnectionCompositorService.java | 4 +--- .../org/fortiss/tooling/kernel/utils/TransformationUtils.java | 2 +- 5 files changed, 5 insertions(+), 7 deletions(-) diff --git a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/ConnectionEditPartBase.java b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/ConnectionEditPartBase.java index 69e5a034c..5f99bc15b 100644 --- a/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/ConnectionEditPartBase.java +++ b/org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/ConnectionEditPartBase.java @@ -68,7 +68,7 @@ import org.fortiss.tooling.kernel.ui.service.IModelElementHandlerService; * @author hoelzl * @author $Author$ * @version $Rev$ - * @ConQAT.Rating YELLOW Hash: 9924C9304C8DC34A5FB6C0B088B11502 + * @ConQAT.Rating GREEN Hash: 201088F399DC474CAF8E1359CC729651 */ public abstract class ConnectionEditPartBase<T extends ConnectionSegmentBase> extends AbstractConnectionEditPart { diff --git a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/ToolingKernelActivator.java b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/ToolingKernelActivator.java index e9919e351..e8e90d2a9 100644 --- a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/ToolingKernelActivator.java +++ b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/ToolingKernelActivator.java @@ -26,7 +26,7 @@ import org.osgi.framework.BundleContext; * @author hoelzl * @author $Author$ * @version $Rev$ - * @ConQAT.Rating YELLOW Hash: 1E146634511FCA18BA62D7739D4A773A + * @ConQAT.Rating GREEN Hash: DCF168925B9064D0417F1921981D6FBE */ public class ToolingKernelActivator extends Plugin { diff --git a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/extension/data/IConstraintViolation.java b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/extension/data/IConstraintViolation.java index 9429bac07..5f5856322 100644 --- a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/extension/data/IConstraintViolation.java +++ b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/extension/data/IConstraintViolation.java @@ -37,7 +37,7 @@ import org.fortiss.tooling.kernel.extension.base.ConstraintViolationBase; * @author hoelzlf * @author $Author$ * @version $Rev$ - * @ConQAT.Rating YELLOW Hash: C7983E84AE129101D5BEF37F511DDFFD + * @ConQAT.Rating GREEN Hash: 6DB0B3EBD6CF6D4102DB7AAD71D850F0 */ public interface IConstraintViolation<T extends EObject> extends IAdaptable { diff --git a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/ConnectionCompositorService.java b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/ConnectionCompositorService.java index 57350734e..3c5094161 100644 --- a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/ConnectionCompositorService.java +++ b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/ConnectionCompositorService.java @@ -32,7 +32,7 @@ import org.fortiss.tooling.kernel.service.base.EObjectAware2ServiceBase; * @author hoelzl * @author $Author$ * @version $Rev$ - * @ConQAT.Rating YELLOW Hash: 38715B7E9629CFEE9DABD601D8D0A814 + * @ConQAT.Rating GREEN Hash: D4CDA9CD830FFA7964FD9195D4724A84 */ public class ConnectionCompositorService extends @@ -52,7 +52,6 @@ public class ConnectionCompositorService @Override public boolean canConnect(EObject source, EObject target, EObject parent, IConnectionCompositionContext context) { - // the find method calls canConnect of the underlying connector return findWorkingConnector(source, target, parent, context) != null; } @@ -69,7 +68,6 @@ public class ConnectionCompositorService @Override public boolean canReconnect(EObject connection, EObject source, EObject target, IConnectionCompositionContext context) { - // the find method calls canReconnect of the underlying connector return findWorkingReconnector(connection, source, target, context) != null; } diff --git a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/utils/TransformationUtils.java b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/utils/TransformationUtils.java index 85f5fa015..93f51f14f 100644 --- a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/utils/TransformationUtils.java +++ b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/utils/TransformationUtils.java @@ -31,7 +31,7 @@ import org.fortiss.tooling.kernel.service.ITransformationService; * @author hoelzl * @author $Author$ * @version $Rev$ - * @ConQAT.Rating YELLOW Hash: D42C81323686D7B361C24AF7F42BB64B + * @ConQAT.Rating GREEN Hash: D2DD40A0416EC2BE7497F82BD2BCD44F */ public final class TransformationUtils { /** -- GitLab