From a692586c00dec4ed3449e9bb4f97e90479187f62 Mon Sep 17 00:00:00 2001
From: Johannes Eder <eder@fortiss.org>
Date: Thu, 28 Jun 2018 14:17:45 +0200
Subject: [PATCH] RED code review
Signed-off-by: Johannes Eder <eder@fortiss.org>
---
.../org/fortiss/tooling/common/ui/javafx/AF3FXViewPart.java | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/org.fortiss.tooling.common.ui/src/org/fortiss/tooling/common/ui/javafx/AF3FXViewPart.java b/org.fortiss.tooling.common.ui/src/org/fortiss/tooling/common/ui/javafx/AF3FXViewPart.java
index 10100de78..b47d37d00 100644
--- a/org.fortiss.tooling.common.ui/src/org/fortiss/tooling/common/ui/javafx/AF3FXViewPart.java
+++ b/org.fortiss.tooling.common.ui/src/org/fortiss/tooling/common/ui/javafx/AF3FXViewPart.java
@@ -61,6 +61,10 @@ public abstract class AF3FXViewPart extends FXViewPart { // NO_UCD
private Pane root;
/**
+ * TODO(JE): Is this comment correct? No FXML def is passed here. Additionally, it would be
+ * beneficial to mention here that a default definition is used when using this Constructor.
+ *
+ *
* Constructor. Allows to pass the view's FXML definition file along with style.
*
* @param viewerClass
@@ -192,6 +196,8 @@ public abstract class AF3FXViewPart extends FXViewPart { // NO_UCD
}
/**
+ * TODO(JE): Please check correctness of first sentence. I guess there is a 'not' missing.
+ *
* Sets the native look of the target platform to break the UI. Most of the UI code is based on
* SWT which uses a platform native look. Currently, Windows 8&10, Windows 7, and MacOS X native
* looks are supported.
--
GitLab