From bd4ca5efc11eebc8ac512b4a1d8fc780f44fc8e5 Mon Sep 17 00:00:00 2001
From: Florian Hoelzl <hoelzl@fortiss.org>
Date: Wed, 4 Jan 2012 15:15:47 +0000
Subject: [PATCH] YELLOW refs 311
---
.../kernel/ui/extension/IModelElementHandler.java | 7 ++-----
.../tooling/kernel/ui/extension/data/package.html | 9 ++-------
.../tooling/kernel/ui/internal/views/MarkerViewPart.java | 5 ++---
3 files changed, 6 insertions(+), 15 deletions(-)
diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/IModelElementHandler.java b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/IModelElementHandler.java
index 965037a5c..59f81d3ae 100644
--- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/IModelElementHandler.java
+++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/IModelElementHandler.java
@@ -38,14 +38,11 @@ import org.fortiss.tooling.kernel.ui.service.IModelElementHandlerService;
* @author hoelzl
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating RED Hash: 1DDC37806BAC50CC6BB5840A863C8DF2
+ * @ConQAT.Rating YELLOW Hash: B8D3975736E43F76782CCA394A4BCE3E
*/
public interface IModelElementHandler<T extends EObject> extends
IEObjectAware<T> {
- // TODO @Review CD:unsure about visibilities. possibly emphasize by using
- // /*package*/ Object name....
-
/** Returns the name of the model element (if any). */
String getName(T element);
@@ -56,7 +53,7 @@ public interface IModelElementHandler<T extends EObject> extends
Image getIcon();
/** Returns image descriptor to be used as icon image. */
- public ImageDescriptor getIconImageDescriptor();
+ ImageDescriptor getIconImageDescriptor();
/**
* Returns all children acting as nodes, which are usually displayed as edit
diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/data/package.html b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/data/package.html
index b74a74d31..fb56aa114 100644
--- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/data/package.html
+++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/data/package.html
@@ -1,18 +1,13 @@
<!--
$Id: package.html 914 2011-07-12 12:16:22Z ratiu $
@version $Rev: 914 $
- @ConQAT.Rating YELLOW Hash: 4937634A5C7499B64F188C4A364D8A16
+ @ConQAT.Rating YELLOW Hash: BE37765EE2B3760E634184DE7450DF3D
-->
<body>
-// TODO @Review CD: I do not see obvious sufficient resemblance between this explanation and the class.
-<br>
-<br>
-
-
Interfaces and classes for data transfer between the kernel and extensions.
<P>
The classes and interfaces of this package appear as parameter and result types of the
-interfaces in the <code>kernel.ui.extension</code> package. Parameter objects resemble
+methods of interfaces in the <code>kernel.ui.extension</code> package. Parameter objects resemble
additional context data provided to the extension, while result objects are required from the
extension.
</body>
diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/views/MarkerViewPart.java b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/views/MarkerViewPart.java
index 600cdb338..8eef57cc3 100644
--- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/views/MarkerViewPart.java
+++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/views/MarkerViewPart.java
@@ -54,7 +54,7 @@ import org.fortiss.tooling.kernel.ui.service.IModelElementHandlerService;
* @author hoelzl
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating RED Hash: 88A64BBF9581BAB1DDF25CDFA888D66D
+ * @ConQAT.Rating YELLOW Hash: EA3783F4D0A722FFCB4BF103A62AD35E
*/
public class MarkerViewPart extends ViewPart {
@@ -222,8 +222,7 @@ public class MarkerViewPart extends ViewPart {
Separator additionsSeperator = new Separator("additions");
additionsSeperator.setVisible(true);
toolBarManager.add(additionsSeperator);
- // TODO @review CD: why not iterate until array.length?
- for (int i = 0; i < 5; i++) {
+ for (int i = 0; i < toggleSeverityFilterAction.length; i++) {
toolBarManager.insertAfter("additions",
toggleSeverityFilterAction[i]);
}
--
GitLab