From d5cec44d2b6d9c75b4923be32e4e26360bfc74a5 Mon Sep 17 00:00:00 2001
From: Daniel Ratiu <ratiu@fortiss.org>
Date: Mon, 4 Jul 2011 15:01:39 +0000
Subject: [PATCH] Another review iteration.
---
.../org/fortiss/tooling/kernel/ToolingKernelActivator.java | 2 +-
.../interfaces/IEclipseResourceStorageLocationProvider.java | 3 +++
.../tooling/kernel/interfaces/IElementCompositionContext.java | 2 +-
.../fortiss/tooling/kernel/interfaces/IElementCompositor.java | 2 +-
.../fortiss/tooling/kernel/interfaces/IPrototypeProvider.java | 2 +-
.../fortiss/tooling/kernel/interfaces/IStorageProvider.java | 2 +-
.../kernel/interfaces/ITopLevelElementChangeListener.java | 2 +-
.../tooling/kernel/interfaces/ITopLevelElementContext.java | 4 +++-
.../src/org/fortiss/tooling/kernel/interfaces/package.html | 4 ++++
.../fortiss/tooling/kernel/internal/CommandStackService.java | 2 +-
.../tooling/kernel/internal/ConnectionCompositorService.java | 2 +-
.../tooling/kernel/internal/ElementCompositorService.java | 2 +-
.../fortiss/tooling/kernel/internal/PersistencyService.java | 2 +-
.../org/fortiss/tooling/kernel/internal/PrototypeService.java | 2 +-
.../src/org/fortiss/tooling/kernel/internal/package.html | 2 +-
.../kernel/internal/storage/eclipse/AutoUndoCommandStack.java | 2 +-
.../internal/storage/eclipse/EMFTransactionalCommand.java | 4 ++++
.../storage/eclipse/EclipseResourceStorageProvider.java | 3 +++
.../fortiss/tooling/kernel/services/ICommandStackService.java | 2 +-
.../tooling/kernel/services/IConnectionCompositorService.java | 2 +-
.../tooling/kernel/services/IElementCompositorService.java | 2 +-
.../fortiss/tooling/kernel/services/IPersistencyService.java | 3 +++
.../fortiss/tooling/kernel/services/IPrototypeService.java | 2 +-
.../src/org/fortiss/tooling/kernel/services/package.html | 4 ++--
.../src/org/fortiss/tooling/kernel/util/EMFResourceUtils.java | 2 +-
.../fortiss/tooling/kernel/util/ProjectRootElementUtils.java | 2 +-
26 files changed, 41 insertions(+), 22 deletions(-)
diff --git a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/ToolingKernelActivator.java b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/ToolingKernelActivator.java
index 1f27ca5e0..a27426593 100644
--- a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/ToolingKernelActivator.java
+++ b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/ToolingKernelActivator.java
@@ -26,7 +26,7 @@ import org.osgi.framework.BundleContext;
* @author hoelzl
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: DB241126336AD7DDFEF835CC72703F1E
+ * @ConQAT.Rating GREEN Hash: BE5981AF550CF440C98D0CEB5CBBC5CF
*/
public class ToolingKernelActivator extends Plugin {
diff --git a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/interfaces/IEclipseResourceStorageLocationProvider.java b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/interfaces/IEclipseResourceStorageLocationProvider.java
index 8a7ed9990..e631d38b3 100644
--- a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/interfaces/IEclipseResourceStorageLocationProvider.java
+++ b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/interfaces/IEclipseResourceStorageLocationProvider.java
@@ -27,6 +27,9 @@ import org.fortiss.tooling.kernel.internal.storage.eclipse.EclipseResourceStorag
* built above the kernel is required to decide whether the file provided with
* {@link #isStorageLocation(IFile)} should be considered.
*
+ * @TODO: who implements this interface? (I could not find any class - is this a
+ * dead code?)
+ *
* @author hoelzlf
* @author $Author$
* @version $Rev$
diff --git a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/interfaces/IElementCompositionContext.java b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/interfaces/IElementCompositionContext.java
index 18d4dc7af..b6e444d06 100644
--- a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/interfaces/IElementCompositionContext.java
+++ b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/interfaces/IElementCompositionContext.java
@@ -29,7 +29,7 @@ package org.fortiss.tooling.kernel.interfaces;
* @author hoelzl
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: 4C3F8D3097CB3379B1AA27B6A0BC05DE
+ * @ConQAT.Rating GREEN Hash: 23C121BA36B5BBC85B457B0195BB5647
*/
public interface IElementCompositionContext {
// this is just a marker interface
diff --git a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/interfaces/IElementCompositor.java b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/interfaces/IElementCompositor.java
index ceb253842..f0556d7c1 100644
--- a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/interfaces/IElementCompositor.java
+++ b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/interfaces/IElementCompositor.java
@@ -35,7 +35,7 @@ import org.fortiss.tooling.kernel.services.IPrototypeService.Prototype;
* @author hoelzl
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: 4073D9D3263D0123CD583E9636EE101D
+ * @ConQAT.Rating GREEN Hash: 55AAA8CFC923138D7FC62924B1FD5208
*/
public interface IElementCompositor<C extends EObject> extends IEObjectAware<C> {
/**
diff --git a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/interfaces/IPrototypeProvider.java b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/interfaces/IPrototypeProvider.java
index ff0d9e44c..e52ef61f0 100644
--- a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/interfaces/IPrototypeProvider.java
+++ b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/interfaces/IPrototypeProvider.java
@@ -31,7 +31,7 @@ import org.fortiss.tooling.kernel.services.IPrototypeService.Prototype;
* @author hoelzl
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: 1160E8FBB539CAEA58CB178AF41E5ED2
+ * @ConQAT.Rating GREEN Hash: B9EFDFBB6757268CE263BDB325ADF72B
*/
public interface IPrototypeProvider {
diff --git a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/interfaces/IStorageProvider.java b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/interfaces/IStorageProvider.java
index c009c78f5..8e6560ad1 100644
--- a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/interfaces/IStorageProvider.java
+++ b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/interfaces/IStorageProvider.java
@@ -30,7 +30,7 @@ import java.util.List;
* @author hoelzl
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: 94E6ACB100AAF673434E0A0F9B548357
+ * @ConQAT.Rating GREEN Hash: E87A345ADBF36DD5D10D19765D45CB31
*/
public interface IStorageProvider {
diff --git a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/interfaces/ITopLevelElementChangeListener.java b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/interfaces/ITopLevelElementChangeListener.java
index f567e0101..b3212fafc 100644
--- a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/interfaces/ITopLevelElementChangeListener.java
+++ b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/interfaces/ITopLevelElementChangeListener.java
@@ -24,7 +24,7 @@ package org.fortiss.tooling.kernel.interfaces;
* @author hoelzl
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: 47E5580127F52AD1A331B4E01D385128
+ * @ConQAT.Rating GREEN Hash: 42C58F24583661CF28BB783416B2805E
*/
public interface ITopLevelElementChangeListener {
diff --git a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/interfaces/ITopLevelElementContext.java b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/interfaces/ITopLevelElementContext.java
index 9fbcf6862..485f8d223 100644
--- a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/interfaces/ITopLevelElementContext.java
+++ b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/interfaces/ITopLevelElementContext.java
@@ -37,10 +37,12 @@ import org.eclipse.emf.ecore.EObject;
*/
public interface ITopLevelElementContext {
+ // @TODO: shouldn't we use a ProgressMonitor as well? (like saving, loading
+ // can be potentially slow)
/** Returns the top-level model element represented by this context. */
EObject getTopLevelElement();
- /** Executes the given {@link Runnable} as model changing command-. */
+ /** Executes the given {@link Runnable} as model changing command. */
void runAsCommand(Runnable runner);
/** Adds a command stack listener. */
diff --git a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/interfaces/package.html b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/interfaces/package.html
index 27c51e2e5..bfff2d83e 100644
--- a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/interfaces/package.html
+++ b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/interfaces/package.html
@@ -5,4 +5,8 @@
-->
<body>
Interface definitions for extension classes of kernel extension points.
+
+@TODO: are the interfaces from this package needed only for extension points? -
+it seems that there are also other interfaces -- e.g. ITopLevelElementChangeListener
+that have nothing to do with extension points.
</body>
diff --git a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/CommandStackService.java b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/CommandStackService.java
index 25692baf8..fa54e4a0a 100644
--- a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/CommandStackService.java
+++ b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/CommandStackService.java
@@ -32,7 +32,7 @@ import org.fortiss.tooling.kernel.util.LoggingUtils;
* @author hoelzl
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: 24589AA882EB757183F8EB940CF778D0
+ * @ConQAT.Rating GREEN Hash: 9D56A2E364F6199C6CAE194DFA9AB5AE
*/
public class CommandStackService implements ICommandStackService {
/** {@inheritDoc} */
diff --git a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/ConnectionCompositorService.java b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/ConnectionCompositorService.java
index 20f3814c6..933653dc5 100644
--- a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/ConnectionCompositorService.java
+++ b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/ConnectionCompositorService.java
@@ -31,7 +31,7 @@ import org.fortiss.tooling.kernel.services.IConnectionCompositorService;
* @author hoelzl
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: E03DE566919A836263949B2899453A61
+ * @ConQAT.Rating GREEN Hash: 91DC9881CCEA9F0C1EEBF5128E9FCB3C
*/
public class ConnectionCompositorService
extends
diff --git a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/ElementCompositorService.java b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/ElementCompositorService.java
index e1fcf1c32..954cab0df 100644
--- a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/ElementCompositorService.java
+++ b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/ElementCompositorService.java
@@ -32,7 +32,7 @@ import org.fortiss.tooling.kernel.services.IPrototypeService.Prototype;
* @author hoelzl
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: E27B124C6AC4A10B7A8C04949A8BFF86
+ * @ConQAT.Rating GREEN Hash: 090065A55A0C7D76FEDE97D75C459D01
*/
public final class ElementCompositorService extends
EObjectAwareServiceBase<IElementCompositor<EObject>> implements
diff --git a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/PersistencyService.java b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/PersistencyService.java
index 35017f482..106d3438b 100644
--- a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/PersistencyService.java
+++ b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/PersistencyService.java
@@ -46,7 +46,7 @@ import org.osgi.framework.Bundle;
* @author hoelzl
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: D6F9583647E210E21463E15ECC7E6334
+ * @ConQAT.Rating GREEN Hash: 92CEC917582981B1AD7A906AF31D5BE0
*/
public class PersistencyService implements IPersistencyService {
diff --git a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/PrototypeService.java b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/PrototypeService.java
index 0826618cd..61243af42 100644
--- a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/PrototypeService.java
+++ b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/PrototypeService.java
@@ -39,7 +39,7 @@ import org.osgi.framework.Bundle;
* @author hoelzl
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: E67EFFAA3034D8BFA1A2E2C673CA5811
+ * @ConQAT.Rating GREEN Hash: 267402CC6D535D379628A4A85CCF7F1F
*/
public class PrototypeService implements IPrototypeService {
diff --git a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/package.html b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/package.html
index 6d70243e0..b11452b46 100644
--- a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/package.html
+++ b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/package.html
@@ -1,7 +1,7 @@
<!--
$Id$
@version $Rev$
- @ConQAT.Rating YELLOW Hash: 9EF9DAA1FC3C08A44EC8946A0CFB9ABC
+ @ConQAT.Rating GREEN Hash: 9FBEA96965AF718EB00560E14DB6D4FB
-->
<body>
Implementations of the kernel services defined in the <code>kernel.services</code> package.
diff --git a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/storage/eclipse/AutoUndoCommandStack.java b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/storage/eclipse/AutoUndoCommandStack.java
index 95321aeac..f802c9742 100644
--- a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/storage/eclipse/AutoUndoCommandStack.java
+++ b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/storage/eclipse/AutoUndoCommandStack.java
@@ -34,7 +34,7 @@ import org.eclipse.emf.transaction.TransactionalEditingDomain;
* @author hummel
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: AFB8CA71F5FD955F7EFC6113A7A59A0F
+ * @ConQAT.Rating GREEN Hash: 36DC8E77AF147ABB387E3447588E997D
*/
public class AutoUndoCommandStack implements TransactionalCommandStack {
diff --git a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/storage/eclipse/EMFTransactionalCommand.java b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/storage/eclipse/EMFTransactionalCommand.java
index f0433f174..b32fd541a 100644
--- a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/storage/eclipse/EMFTransactionalCommand.java
+++ b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/storage/eclipse/EMFTransactionalCommand.java
@@ -116,6 +116,10 @@ public class EMFTransactionalCommand implements Command {
} catch (RollbackException e) {
// There is nothing we can do about.
// Maybe it even was intended, so ignore.
+ // @TODO: fail silently is a bad programming style since
+ // there are errors that are from outside not seen. Print a
+ // stacktrace should be the minimum what we do for an
+ // exception
}
} else {
LoggingUtils.log(ToolingKernelActivator.getDefault(),
diff --git a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/storage/eclipse/EclipseResourceStorageProvider.java b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/storage/eclipse/EclipseResourceStorageProvider.java
index 95d631192..a8a709555 100644
--- a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/storage/eclipse/EclipseResourceStorageProvider.java
+++ b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/storage/eclipse/EclipseResourceStorageProvider.java
@@ -147,6 +147,8 @@ public class EclipseResourceStorageProvider implements IResourceChangeListener,
public boolean visit(IResourceDelta delta) {
if (delta.getResource() instanceof IFile
&& delta.getResource().getParent() instanceof IProject
+ // @TODO: is it OK to hardcode the extension "af3_20" here? -
+ // use better a constant
&& delta.getResource().getFileExtension().equals("af3_20")) {
runWorkspaceChangeJob((IFile) delta.getResource(), delta.getKind());
}
@@ -212,6 +214,7 @@ public class EclipseResourceStorageProvider implements IResourceChangeListener,
return mc;
}
+ // @TODO: comment is bad: copied from loadContext
/** Loads a file and creates a new context from its contents. */
private void unloadContext(IFile file) {
ModelContext context = loadedContexts.remove(file);
diff --git a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/services/ICommandStackService.java b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/services/ICommandStackService.java
index 0dc6a407b..036f62bf8 100644
--- a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/services/ICommandStackService.java
+++ b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/services/ICommandStackService.java
@@ -31,7 +31,7 @@ import org.fortiss.tooling.kernel.internal.CommandStackService;
* @author hoelzl
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: CCF7573F1C48CF4CFFD1464C4498F56F
+ * @ConQAT.Rating GREEN Hash: 0673CEE9D531862ED2BEB34AFCB77AED
*/
public interface ICommandStackService {
diff --git a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/services/IConnectionCompositorService.java b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/services/IConnectionCompositorService.java
index 4645d873d..6820d15ab 100644
--- a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/services/IConnectionCompositorService.java
+++ b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/services/IConnectionCompositorService.java
@@ -37,7 +37,7 @@ import org.fortiss.tooling.kernel.internal.ConnectionCompositorService;
* @author hoelzl
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: E9F9052783770B8F9494E84F990874BD
+ * @ConQAT.Rating GREEN Hash: EBFA052BA702812ED4FD5C17ED8F709B
*/
public interface IConnectionCompositorService {
diff --git a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/services/IElementCompositorService.java b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/services/IElementCompositorService.java
index c7d5f2f18..4aa269980 100644
--- a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/services/IElementCompositorService.java
+++ b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/services/IElementCompositorService.java
@@ -37,7 +37,7 @@ import org.fortiss.tooling.kernel.services.IPrototypeService.Prototype;
* @author hoelzl
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: 1B489882210AB188E82A94F41F2CF796
+ * @ConQAT.Rating GREEN Hash: C7ED8EC9FDC7763BF3755FBEA4DEDE64
*/
public interface IElementCompositorService {
diff --git a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/services/IPersistencyService.java b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/services/IPersistencyService.java
index 1d8f0aefa..8fae644a4 100644
--- a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/services/IPersistencyService.java
+++ b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/services/IPersistencyService.java
@@ -46,6 +46,9 @@ public interface IPersistencyService {
/**
* Returns the list of top level {@link ITopLevelElementContext}s provided
* by {@link IStorageProvider}s.
+ *
+ * @TODO: if doSave takes a ProgressMonitor, shouldn't we have one here as
+ * well?
*/
List<ITopLevelElementContext> getTopLevelElementContexts();
diff --git a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/services/IPrototypeService.java b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/services/IPrototypeService.java
index aa0ff934e..6498d3c6d 100644
--- a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/services/IPrototypeService.java
+++ b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/services/IPrototypeService.java
@@ -32,7 +32,7 @@ import org.fortiss.tooling.kernel.internal.PrototypeService;
* @author hoelzl
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: A052488068BAE9406F9BEAD648E70BD7
+ * @ConQAT.Rating GREEN Hash: 7D308E866BBAEF201D83AE622C201A8F
*/
public interface IPrototypeService {
diff --git a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/services/package.html b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/services/package.html
index e52bcfb15..379f00728 100644
--- a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/services/package.html
+++ b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/services/package.html
@@ -1,10 +1,10 @@
<!--
$Id$
@version $Rev$
- @ConQAT.Rating YELLOW Hash: 659E35767FF963AE2A8D7C2195891AA2
+ @ConQAT.Rating GREEN Hash: 5BF74F97872CB3DAB8DD92B75E8880EC
-->
<body>
Interface definitions of the kernel services. Each interface corresponds to a certain functionality of the kernel.
Some of the services provide extension points. Extension implementors should refer to the <code>kernel.interfaces</code>
-and <code>kernel.base</code>m packages. Kernel services are implemented by classes from the <code>kernel.internal.services</code> package.
+and <code>kernel.base</code> packages. Kernel services are implemented by classes from the <code>kernel.internal.services</code> package.
</body>
diff --git a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/util/EMFResourceUtils.java b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/util/EMFResourceUtils.java
index cd429e305..3c96676f3 100644
--- a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/util/EMFResourceUtils.java
+++ b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/util/EMFResourceUtils.java
@@ -34,7 +34,7 @@ import org.eclipse.emf.ecore.xmi.XMLResource;
* @author hoelzl
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: B220811451A4B54EB48A985228AC065F
+ * @ConQAT.Rating GREEN Hash: 457FAB182DE3C79EDED1E33D6E744BC2
*/
public final class EMFResourceUtils {
/**
diff --git a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/util/ProjectRootElementUtils.java b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/util/ProjectRootElementUtils.java
index 12ae6e147..13f88b4c1 100644
--- a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/util/ProjectRootElementUtils.java
+++ b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/util/ProjectRootElementUtils.java
@@ -28,7 +28,7 @@ import org.fortiss.tooling.kernel.services.IPersistencyService;
* @author hoelzl
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: A52D2C0621A144E03101499724BCF926
+ * @ConQAT.Rating GREEN Hash: 54BEFCC44B523976BF14E4F2BC6FB697
*/
public final class ProjectRootElementUtils {
--
GitLab