From e53d1d89ef0db14c20fdec5cfc58cb1dc4a4d70d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Christoph=20D=C3=B6bber?= <doebber@in.tum.de>
Date: Mon, 5 Dec 2011 12:16:59 +0000
Subject: [PATCH] reviewed portion of kernel.ui
---
.../tooling/kernel/ui/extension/IEditPartFactory.java | 2 +-
.../fortiss/tooling/kernel/ui/extension/IModelEditor.java | 2 +-
.../tooling/kernel/ui/extension/IModelElementHandler.java | 5 +++--
.../kernel/ui/extension/base/EObjectActionBase.java | 3 ++-
.../tooling/kernel/ui/extension/base/EditorBase.java | 2 +-
.../kernel/ui/extension/base/ModelElementHandlerBase.java | 5 ++---
.../kernel/ui/extension/base/PropertySectionBase.java | 3 ++-
.../fortiss/tooling/kernel/ui/extension/data/package.html | 8 ++++++++
8 files changed, 20 insertions(+), 10 deletions(-)
create mode 100644 org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/data/package.html
diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/IEditPartFactory.java b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/IEditPartFactory.java
index 4dc50ab1d..c31892529 100644
--- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/IEditPartFactory.java
+++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/IEditPartFactory.java
@@ -33,7 +33,7 @@ import org.fortiss.tooling.kernel.ui.service.IEditPartFactoryService;
* @author hoelzlf
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: E21D51F62B0AD223BF62913A4E00ED78
+ * @ConQAT.Rating GREEN Hash: B07D0D955E38DE935B5E87A1FED4CD7A
*/
public interface IEditPartFactory extends IEObjectAware<EObject>,
EditPartFactory {
diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/IModelEditor.java b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/IModelEditor.java
index 3caba2c5e..514b24d9d 100644
--- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/IModelEditor.java
+++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/IModelEditor.java
@@ -26,7 +26,7 @@ import org.eclipse.ui.IEditorPart;
* @author hoelzl
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: F0A94041C50D164FB6A321C68DB038D5
+ * @ConQAT.Rating GREEN Hash: A0FEDA6616CBC0DCC4632D2E73E4FDA5
*/
public interface IModelEditor<T extends EObject> extends IEditorPart {
/** Returns the edited object. */
diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/IModelElementHandler.java b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/IModelElementHandler.java
index c64127c9c..5f48c2237 100644
--- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/IModelElementHandler.java
+++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/IModelElementHandler.java
@@ -38,7 +38,7 @@ import org.fortiss.tooling.kernel.ui.service.IModelElementHandlerService;
* @author hoelzl
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: 991B6E327C707A1BB7046234807F5D06
+ * @ConQAT.Rating RED Hash: EF2C8B5B955C72DE74CB4FCD7A9D67EE
*/
public interface IModelElementHandler<T extends EObject> extends
IEObjectAware<T> {
@@ -62,7 +62,7 @@ public interface IModelElementHandler<T extends EObject> extends
List<EObject> getSubnodes(T element);
/**
- * Returns all children acting as connectors, which are usually display as
+ * Returns all children acting as connectors, which are usually displayed as
* edit parts in graphical editors, but NOT as entries in the navigator
* tree.
*/
@@ -91,5 +91,6 @@ public interface IModelElementHandler<T extends EObject> extends
* Returns true if the underlying element should be visible in the navigator
* in the non-expert view.
*/
+ // TODO @review CD: Naming of method and meaning of comment inconsistent.
boolean hiddenInNonExpertView();
}
diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/base/EObjectActionBase.java b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/base/EObjectActionBase.java
index 815e13f4a..46abbf3ab 100644
--- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/base/EObjectActionBase.java
+++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/base/EObjectActionBase.java
@@ -27,7 +27,7 @@ import org.eclipse.jface.resource.ImageDescriptor;
* @author hoelzlf
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: 05CFD4FE53BA46507F5619DDD7BD47B5
+ * @ConQAT.Rating RED Hash: 2BA72A5FAFFBBF746808612946F56A18
*/
public abstract class EObjectActionBase extends Action {
@@ -35,6 +35,7 @@ public abstract class EObjectActionBase extends Action {
private EObject target;
/** Constructor. */
+ // TODO @review CD: why necessary?
public EObjectActionBase(String text, ImageDescriptor image) {
super(text, image);
}
diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/base/EditorBase.java b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/base/EditorBase.java
index b0640c158..2d33cf858 100644
--- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/base/EditorBase.java
+++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/base/EditorBase.java
@@ -39,7 +39,7 @@ import org.fortiss.tooling.kernel.ui.internal.editor.ModelElementEditorInput;
* @author hoelzlf
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: 69ECBCA616C4201AF71EB5DAB02705C1
+ * @ConQAT.Rating GREEN Hash: D735C9795A2EB99EDB8D0DF67CDF0A23
*/
public abstract class EditorBase<T extends EObject> extends EditorPart
implements IActionContributingEditor, IModelEditor<T> {
diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/base/ModelElementHandlerBase.java b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/base/ModelElementHandlerBase.java
index c3ac4c698..aba0adf6a 100644
--- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/base/ModelElementHandlerBase.java
+++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/base/ModelElementHandlerBase.java
@@ -35,14 +35,13 @@ import org.fortiss.tooling.kernel.ui.extension.IModelElementHandler;
* @author hoelzl
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: D840BECB0A8B2398C01EBF945CF2EA0B
+ * @ConQAT.Rating GREEN Hash: C425E25E66646B2383453FCE7C93A894
*/
public abstract class ModelElementHandlerBase<T extends EObject> implements
IModelElementHandler<T> {
/**
- * Stores of the icon image. Use singleton to save the limited image
- * buffers.
+ * Stores the icon image. Use singleton to save the limited image buffers.
*/
private Image iconImage;
diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/base/PropertySectionBase.java b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/base/PropertySectionBase.java
index a46f78abd..18a5f5af7 100644
--- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/base/PropertySectionBase.java
+++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/base/PropertySectionBase.java
@@ -49,7 +49,7 @@ import org.fortiss.tooling.kernel.ui.util.DataBindingUtils;
* @author hoelzl
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: C933211F21A9E76CBE2281807031C684
+ * @ConQAT.Rating RED Hash: 92596C4508B3EB9393F80DD61A652FF9
*/
public abstract class PropertySectionBase extends AbstractPropertySection {
@@ -57,6 +57,7 @@ public abstract class PropertySectionBase extends AbstractPropertySection {
public static final int PROPERTIES_LABEL_WIDTH = 150;
/** The main composite for the controls. */
+ // TODO @review CD: final?
protected Composite composite;
/** Stores the data binding context used. */
diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/data/package.html b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/data/package.html
new file mode 100644
index 000000000..15a7b6dbe
--- /dev/null
+++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/data/package.html
@@ -0,0 +1,8 @@
+<!--
+ $Id: package.html 914 2011-07-12 12:16:22Z ratiu $
+ @version $Rev: 914 $
+ @ConQAT.Rating RED Hash: 0E247D0F04DEF8F70072DAEE84BB9B7E
+-->
+<body>
+Classes for extension of....
+</body>
--
GitLab