From e5cd58b6cd9eece35a6fc8d0b63bbd8315823248 Mon Sep 17 00:00:00 2001
From: Daniel Ratiu <ratiu@fortiss.org>
Date: Tue, 12 Jul 2011 12:07:16 +0000
Subject: [PATCH] yet another code review iteration
---
.../kernel/extension/IConnectionCompositor.java | 3 +++
.../tooling/kernel/extension/IConstraintChecker.java | 2 +-
.../IEclipseResourceStorageLocationProvider.java | 2 +-
.../tooling/kernel/extension/IElementCompositor.java | 2 +-
.../tooling/kernel/extension/IPrototypeProvider.java | 2 +-
.../tooling/kernel/extension/IStorageProvider.java | 2 ++
.../kernel/extension/base/PrototypeProviderBase.java | 6 ++----
.../fortiss/tooling/kernel/extension/base/package.html | 2 +-
.../extension/data/IConnectionCompositionContext.java | 2 +-
.../kernel/extension/data/IConstraintViolation.java | 2 +-
.../extension/data/IElementCompositionContext.java | 2 +-
.../kernel/extension/data/ITopLevelElement.java | 2 +-
.../tooling/kernel/extension/data/Prototype.java | 2 +-
.../fortiss/tooling/kernel/extension/data/package.html | 2 +-
.../org/fortiss/tooling/kernel/extension/package.html | 2 +-
.../tooling/kernel/internal/CommandStackService.java | 2 +-
.../kernel/internal/ConnectionCompositorService.java | 2 +-
.../kernel/internal/ElementCompositorService.java | 2 +-
.../tooling/kernel/internal/PersistencyService.java | 2 +-
.../tooling/kernel/internal/PrototypeService.java | 2 +-
.../storage/eclipse/EMFTransactionalCommand.java | 2 +-
.../eclipse/EclipseResourceStorageProvider.java | 10 ++++++----
.../kernel/internal/storage/eclipse/ModelContext.java | 2 +-
.../kernel/internal/storage/eclipse/package.html | 2 ++
.../kernel/listener/IPersistencyServiceListener.java | 2 +-
.../org/fortiss/tooling/kernel/listener/package.html | 9 +++++++++
.../kernel/service/IConnectionCompositorService.java | 2 +-
.../kernel/service/IConstraintCheckerService.java | 2 +-
.../kernel/service/IEclipseResourceStorageService.java | 2 +-
.../kernel/service/IElementCompositorService.java | 2 +-
.../tooling/kernel/service/IPersistencyService.java | 3 +++
.../tooling/kernel/service/IPrototypeService.java | 2 +-
.../kernel/service/base/EObjectAware2ServiceBase.java | 2 +-
.../kernel/service/base/EObjectAwareServiceBase.java | 2 +-
.../tooling/kernel/service/base/IEObjectAware.java | 2 +-
.../tooling/kernel/service/base/IEObjectAware2.java | 2 +-
.../fortiss/tooling/kernel/service/base/package.html | 2 +-
.../org/fortiss/tooling/kernel/service/package.html | 2 +-
38 files changed, 58 insertions(+), 39 deletions(-)
create mode 100644 org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/listener/package.html
diff --git a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/extension/IConnectionCompositor.java b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/extension/IConnectionCompositor.java
index d7f53d764..daf5d8f0b 100644
--- a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/extension/IConnectionCompositor.java
+++ b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/extension/IConnectionCompositor.java
@@ -77,6 +77,9 @@ public interface IConnectionCompositor<P extends EObject, S extends EObject, T e
* reused for the connection (reconnect).
* @param context
* context information for the connection. May be null.
+ *
+ * TODO: what is the return? true is success and false otherwise?
+ * or what?
*/
boolean connect(S source, T target, EObject connection,
IConnectionCompositionContext context);
diff --git a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/extension/IConstraintChecker.java b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/extension/IConstraintChecker.java
index 3327e124e..f1c8a7cdd 100644
--- a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/extension/IConstraintChecker.java
+++ b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/extension/IConstraintChecker.java
@@ -36,7 +36,7 @@ import org.fortiss.tooling.kernel.service.base.IEObjectAware;
* @author hoelzlf
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: E2CC5EF1073822B0237FAB3E5F609D51
+ * @ConQAT.Rating GREEN Hash: 9D1C13DDE03060268433FC560D3BB754
*/
public interface IConstraintChecker<C extends EObject> extends IEObjectAware<C> {
diff --git a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/extension/IEclipseResourceStorageLocationProvider.java b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/extension/IEclipseResourceStorageLocationProvider.java
index 0c9237c59..ae74a264d 100644
--- a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/extension/IEclipseResourceStorageLocationProvider.java
+++ b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/extension/IEclipseResourceStorageLocationProvider.java
@@ -36,7 +36,7 @@ import org.fortiss.tooling.kernel.service.IEclipseResourceStorageService;
* @author hoelzlf
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: 6036762A8AD9A6300F2E9B1309662D02
+ * @ConQAT.Rating GREEN Hash: CE0537EAE8D9116253F7769DF9378FDE
*/
public interface IEclipseResourceStorageLocationProvider {
diff --git a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/extension/IElementCompositor.java b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/extension/IElementCompositor.java
index e969bfb72..1d56a4881 100644
--- a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/extension/IElementCompositor.java
+++ b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/extension/IElementCompositor.java
@@ -39,7 +39,7 @@ import org.fortiss.tooling.kernel.service.base.IEObjectAware;
* @author hoelzl
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: 4793D9DD3334268CB2CAC0A959A56FF1
+ * @ConQAT.Rating GREEN Hash: 4F8B26BA3A47A0A7E09A8E3528BBA598
*/
public interface IElementCompositor<C extends EObject> extends IEObjectAware<C> {
/**
diff --git a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/extension/IPrototypeProvider.java b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/extension/IPrototypeProvider.java
index cee17b671..2a854782e 100644
--- a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/extension/IPrototypeProvider.java
+++ b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/extension/IPrototypeProvider.java
@@ -35,7 +35,7 @@ import org.fortiss.tooling.kernel.service.IPrototypeService;
* @author hoelzl
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: 02459651984F56CAF5055BE52B0E1642
+ * @ConQAT.Rating GREEN Hash: 80777FB968BED2B17E291F87E33B8B2E
*/
public interface IPrototypeProvider {
diff --git a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/extension/IStorageProvider.java b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/extension/IStorageProvider.java
index 8c642321f..5b7ae7a1d 100644
--- a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/extension/IStorageProvider.java
+++ b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/extension/IStorageProvider.java
@@ -45,6 +45,8 @@ public interface IStorageProvider {
* Returns the top-level elements provided by this storage provider. This
* method is called by persistency service during initialization. Only
* successfully loaded models must be returned to the persitency service.
+ *
+ * TODO: Why "getTopLevelElementContexts" and not "getTopLevelElements"?
*/
List<ITopLevelElement> getTopLevelElementContexts();
}
diff --git a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/extension/base/PrototypeProviderBase.java b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/extension/base/PrototypeProviderBase.java
index 561766532..23381c240 100644
--- a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/extension/base/PrototypeProviderBase.java
+++ b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/extension/base/PrototypeProviderBase.java
@@ -26,9 +26,7 @@ import org.fortiss.tooling.kernel.extension.IPrototypeProvider;
import org.fortiss.tooling.kernel.extension.data.Prototype;
/**
- * Base implementation for {@link IPrototypeProvider}s. TODO: isn't
- * PrototypeProvider a service as well? It is really easy to get lost among
- * services, and only interfaces etc)
+ * Base implementation for {@link IPrototypeProvider}s.
*
* <p>
* Sub-classes must implement {@link #registerPrototypes()} to register specific
@@ -37,7 +35,7 @@ import org.fortiss.tooling.kernel.extension.data.Prototype;
* @author hoelzlf
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: 9E3EB670536CB826308AE303244A9D33
+ * @ConQAT.Rating GREEN Hash: 27473E69AFF40772E5205476D860BC34
*/
public abstract class PrototypeProviderBase implements IPrototypeProvider {
diff --git a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/extension/base/package.html b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/extension/base/package.html
index 436ba00f3..5e9a6c11d 100644
--- a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/extension/base/package.html
+++ b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/extension/base/package.html
@@ -1,7 +1,7 @@
<!--
$Id$
@version $Rev$
- @ConQAT.Rating YELLOW Hash: BFA3AA34142126C434C02403B80670B9
+ @ConQAT.Rating GREEN Hash: 5D7FEA884A05FEC3B8693DA8DF7D8C71
-->
<body>
Base implementations for extension classes of kernel extension points.
diff --git a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/extension/data/IConnectionCompositionContext.java b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/extension/data/IConnectionCompositionContext.java
index 40a98db20..2fce76349 100644
--- a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/extension/data/IConnectionCompositionContext.java
+++ b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/extension/data/IConnectionCompositionContext.java
@@ -31,7 +31,7 @@ import org.fortiss.tooling.kernel.extension.IConnectionCompositor;
* @author hoelzl
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: FBC55EDBE8003E3781A5D6C79B062FE1
+ * @ConQAT.Rating GREEN Hash: 720E4A1D7A01A95DA7C4E54343A1F004
*/
public interface IConnectionCompositionContext {
// this is just a marker interface
diff --git a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/extension/data/IConstraintViolation.java b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/extension/data/IConstraintViolation.java
index 6637d3cd5..230d9c04f 100644
--- a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/extension/data/IConstraintViolation.java
+++ b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/extension/data/IConstraintViolation.java
@@ -30,7 +30,7 @@ import org.eclipse.emf.ecore.EObject;
* @author hoelzlf
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: 1C25076B7A79733306A4053406C5E378
+ * @ConQAT.Rating GREEN Hash: 59B63AA8B22AF7224E17B92B0CD261BF
*/
public interface IConstraintViolation<T extends EObject> {
diff --git a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/extension/data/IElementCompositionContext.java b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/extension/data/IElementCompositionContext.java
index e33cd6ca7..2317d480f 100644
--- a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/extension/data/IElementCompositionContext.java
+++ b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/extension/data/IElementCompositionContext.java
@@ -31,7 +31,7 @@ import org.fortiss.tooling.kernel.extension.IElementCompositor;
* @author hoelzl
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: 481ACAA6E32399E69BEF87A33A670BDE
+ * @ConQAT.Rating GREEN Hash: 80C5E55D6A67F099F4106CFA3481D95F
*/
public interface IElementCompositionContext {
// this is just a marker interface
diff --git a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/extension/data/ITopLevelElement.java b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/extension/data/ITopLevelElement.java
index 38bc6997a..f6c774ac3 100644
--- a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/extension/data/ITopLevelElement.java
+++ b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/extension/data/ITopLevelElement.java
@@ -40,7 +40,7 @@ import org.fortiss.tooling.kernel.extension.IStorageProvider;
* @author hoelzl
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: 46D4B0852566538FAED1AB6B39AD22D9
+ * @ConQAT.Rating GREEN Hash: D6E05CB93BCCCF00295DCFDA946B5F5D
*/
public interface ITopLevelElement {
diff --git a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/extension/data/Prototype.java b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/extension/data/Prototype.java
index 18671881d..acce3b82c 100644
--- a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/extension/data/Prototype.java
+++ b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/extension/data/Prototype.java
@@ -27,7 +27,7 @@ import org.eclipse.emf.ecore.util.EcoreUtil;
* @author hoelzl
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: 1D8DA4B2312BAB5112C0FDEA9EADB8E0
+ * @ConQAT.Rating GREEN Hash: A5DDFFB23BD8EEFA0DC58151601AAC2D
*/
public final class Prototype {
diff --git a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/extension/data/package.html b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/extension/data/package.html
index 12ee9041b..05f2a0213 100644
--- a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/extension/data/package.html
+++ b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/extension/data/package.html
@@ -1,7 +1,7 @@
<!--
$Id$
@version $Rev$
- @ConQAT.Rating YELLOW Hash: 8559DA9A8CB872E4F00B04DAD51E8E17
+ @ConQAT.Rating GREEN Hash: C2BFA0EE34A29B7F6CC93972CB58419B
-->
<body>
Interfaces and classes for data transfer between the kernel and extensions.
diff --git a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/extension/package.html b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/extension/package.html
index fa68ee591..728910c3d 100644
--- a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/extension/package.html
+++ b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/extension/package.html
@@ -1,7 +1,7 @@
<!--
$Id$
@version $Rev$
- @ConQAT.Rating YELLOW Hash: DC71F316A934392F97E1B69B74FBC82E
+ @ConQAT.Rating GREEN Hash: D101602A1EAE907937C2A494F40289E9
-->
<body>
Interface definitions for extension classes of kernel extension points.
diff --git a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/CommandStackService.java b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/CommandStackService.java
index 89c969e16..e9b1abef9 100644
--- a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/CommandStackService.java
+++ b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/CommandStackService.java
@@ -32,7 +32,7 @@ import org.fortiss.tooling.kernel.util.LoggingUtils;
* @author hoelzl
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: 77093BE6ACCF48F747456A3E17E4F837
+ * @ConQAT.Rating GREEN Hash: 05A073E630BD60C0AB017812C6AFFAE4
*/
public class CommandStackService implements ICommandStackService {
/** {@inheritDoc} */
diff --git a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/ConnectionCompositorService.java b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/ConnectionCompositorService.java
index b5b8e442a..ffd24ccf7 100644
--- a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/ConnectionCompositorService.java
+++ b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/ConnectionCompositorService.java
@@ -31,7 +31,7 @@ import org.fortiss.tooling.kernel.service.base.EObjectAware2ServiceBase;
* @author hoelzl
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: 3F434A924BFA7706162D055414ECF57A
+ * @ConQAT.Rating GREEN Hash: 4282E7337B452ECF3966EC202E08A0C7
*/
public class ConnectionCompositorService
extends
diff --git a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/ElementCompositorService.java b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/ElementCompositorService.java
index fb3120563..8382d81b1 100644
--- a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/ElementCompositorService.java
+++ b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/ElementCompositorService.java
@@ -32,7 +32,7 @@ import org.fortiss.tooling.kernel.service.base.EObjectAwareServiceBase;
* @author hoelzl
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: 7E6D49987FE1E3D45E1B8ECCF95774F6
+ * @ConQAT.Rating GREEN Hash: EBB07ED0EEB3A43FE2A79DE0FCF6A44F
*/
public final class ElementCompositorService extends
EObjectAwareServiceBase<IElementCompositor<EObject>> implements
diff --git a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/PersistencyService.java b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/PersistencyService.java
index 3842c3f3f..1d30f5d65 100644
--- a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/PersistencyService.java
+++ b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/PersistencyService.java
@@ -49,7 +49,7 @@ import org.osgi.framework.Bundle;
* @author hoelzl
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: 656CF4CEE3E0F1F5BB7F7C7A642DFA5A
+ * @ConQAT.Rating GREEN Hash: BA1EE25D06B3C06BF8A5BC6B3BC9CFAC
*/
public class PersistencyService implements IPersistencyService {
diff --git a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/PrototypeService.java b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/PrototypeService.java
index 49d317b46..e50c5e733 100644
--- a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/PrototypeService.java
+++ b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/PrototypeService.java
@@ -40,7 +40,7 @@ import org.osgi.framework.Bundle;
* @author hoelzl
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: DA18D225E16D97EB10C92E74B8880871
+ * @ConQAT.Rating GREEN Hash: 86C5C8E593C55BD338124CCDC30AF856
*/
public class PrototypeService implements IPrototypeService {
diff --git a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/storage/eclipse/EMFTransactionalCommand.java b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/storage/eclipse/EMFTransactionalCommand.java
index b618dc0b2..ae8a3ee70 100644
--- a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/storage/eclipse/EMFTransactionalCommand.java
+++ b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/storage/eclipse/EMFTransactionalCommand.java
@@ -39,7 +39,7 @@ import org.fortiss.tooling.kernel.util.LoggingUtils;
* @author hummel
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: B03C08D5C3638DC9319D608E0425960D
+ * @ConQAT.Rating GREEN Hash: 033E90E46FF2E736A09F2FEBD2365AF1
*/
public class EMFTransactionalCommand implements Command {
diff --git a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/storage/eclipse/EclipseResourceStorageProvider.java b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/storage/eclipse/EclipseResourceStorageProvider.java
index c4fe46626..fa69c4d19 100644
--- a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/storage/eclipse/EclipseResourceStorageProvider.java
+++ b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/storage/eclipse/EclipseResourceStorageProvider.java
@@ -56,7 +56,7 @@ import org.osgi.framework.Bundle;
* @author hoelzlf
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: EB9EBACBD5314247AC28D98B7E7BC6A4
+ * @ConQAT.Rating RED Hash: 9D11F8884C0E9AD666F0F39804D7321A
*/
public class EclipseResourceStorageProvider implements
IEclipseResourceStorageService, IResourceChangeListener,
@@ -144,13 +144,15 @@ public class EclipseResourceStorageProvider implements
}
}
- /** {@inheritDoc} */
+ /**
+ * {@inheritDoc}
+ */
@Override
public boolean visit(IResourceDelta delta) {
if (delta.getResource() instanceof IFile
&& delta.getResource().getParent() instanceof IProject
- // @TODO: is it OK to hardcode the extension "af3_20" here? -
- // use better a constant
+ // TODO is it OK to hardcode the extension "af3_20" here? - use
+ // better a constant
&& delta.getResource().getFileExtension().equals("af3_20")) {
runWorkspaceChangeJob((IFile) delta.getResource(), delta.getKind());
}
diff --git a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/storage/eclipse/ModelContext.java b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/storage/eclipse/ModelContext.java
index ab6219071..6cceab077 100644
--- a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/storage/eclipse/ModelContext.java
+++ b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/storage/eclipse/ModelContext.java
@@ -52,7 +52,7 @@ import org.fortiss.tooling.kernel.util.LoggingUtils;
* @author hummel
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: 7FEA429DA177E3405DD0AC7A1D711834
+ * @ConQAT.Rating GREEN Hash: B4A8F77626D454C4ABC487DFAE289D71
*/
class ModelContext implements ITopLevelElement {
diff --git a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/storage/eclipse/package.html b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/storage/eclipse/package.html
index 46bc287f4..f70b0805f 100644
--- a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/storage/eclipse/package.html
+++ b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/storage/eclipse/package.html
@@ -5,4 +5,6 @@
-->
<body>
Implementation of the <code>IStorageProvider</code> interface using Eclipse file resources as storage mechanism for models.
+
+TODO: in this package is more that the implementation of IStorageProvider - or?
</body>
diff --git a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/listener/IPersistencyServiceListener.java b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/listener/IPersistencyServiceListener.java
index 6fde97a07..73d243654 100644
--- a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/listener/IPersistencyServiceListener.java
+++ b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/listener/IPersistencyServiceListener.java
@@ -28,7 +28,7 @@ import org.fortiss.tooling.kernel.extension.data.ITopLevelElement;
* @author hoelzl
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: E54C0BBFF4612E1E23502EA3D6CEA3DE
+ * @ConQAT.Rating GREEN Hash: 76EAC97C783A9B5263C99D3958E9C575
*/
public interface IPersistencyServiceListener {
diff --git a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/listener/package.html b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/listener/package.html
new file mode 100644
index 000000000..31a1627de
--- /dev/null
+++ b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/listener/package.html
@@ -0,0 +1,9 @@
+<!--
+ $Id: package.html 901 2011-07-10 13:44:11Z hoelzl $
+ @version $Rev: 901 $
+ @ConQAT.Rating GREEN Hash: 9FBEA96965AF718EB00560E14DB6D4FB
+-->
+<body>
+TODO
+<p>
+</body>
diff --git a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/service/IConnectionCompositorService.java b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/service/IConnectionCompositorService.java
index 24fefcfca..44f794ef0 100644
--- a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/service/IConnectionCompositorService.java
+++ b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/service/IConnectionCompositorService.java
@@ -35,7 +35,7 @@ import org.fortiss.tooling.kernel.internal.ConnectionCompositorService;
* @author hoelzl
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: A7FE0CEF3CF25444AE5F8E77B8F499EA
+ * @ConQAT.Rating GREEN Hash: 982C28C5882DC9ED374779B6059D096D
*/
public interface IConnectionCompositorService {
diff --git a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/service/IConstraintCheckerService.java b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/service/IConstraintCheckerService.java
index 30cbbe5ce..942fb3f17 100644
--- a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/service/IConstraintCheckerService.java
+++ b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/service/IConstraintCheckerService.java
@@ -34,7 +34,7 @@ import org.fortiss.tooling.kernel.internal.ConstraintCheckerService;
* @author hoelzl
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: 490B73740C4C864AECBC3FA969746B18
+ * @ConQAT.Rating GREEN Hash: 9F13D22CC269B9811CD13C341024AA78
*/
public interface IConstraintCheckerService {
diff --git a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/service/IEclipseResourceStorageService.java b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/service/IEclipseResourceStorageService.java
index 35f0d7316..dc89b50da 100644
--- a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/service/IEclipseResourceStorageService.java
+++ b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/service/IEclipseResourceStorageService.java
@@ -31,7 +31,7 @@ import org.fortiss.tooling.kernel.extension.IEclipseResourceStorageLocationProvi
* @author hoelzlf
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: BFC64E77516E911A8C868F964F7EB6CF
+ * @ConQAT.Rating GREEN Hash: A99A2CEFC57086E32ABE67618F618E20
*/
public interface IEclipseResourceStorageService {
diff --git a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/service/IElementCompositorService.java b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/service/IElementCompositorService.java
index 7c1256d54..4be9a647a 100644
--- a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/service/IElementCompositorService.java
+++ b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/service/IElementCompositorService.java
@@ -35,7 +35,7 @@ import org.fortiss.tooling.kernel.internal.ElementCompositorService;
* @author hoelzl
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: 28767D3487AB11E0BB918174285CA661
+ * @ConQAT.Rating GREEN Hash: 72BAA99C391B2206BCB495943F28FBF5
*/
public interface IElementCompositorService {
diff --git a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/service/IPersistencyService.java b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/service/IPersistencyService.java
index 3f47d408a..add987fed 100644
--- a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/service/IPersistencyService.java
+++ b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/service/IPersistencyService.java
@@ -53,6 +53,8 @@ public interface IPersistencyService {
* {@link IStorageProvider}s. All storage providers are requested to load
* and provide their models during the persistency initialization. Therefore
* this method does not have a progress monitor.
+ *
+ * TODO why getTopLevelElementContexts and not getTopLevelElements?
*/
List<ITopLevelElement> getTopLevelElementContexts();
@@ -66,6 +68,7 @@ public interface IPersistencyService {
void removeTopLevelElementListener(IPersistencyServiceListener listener);
/** Returns the top-level element for the given model element. */
+ // TODO: why getTopLevelElementContextFor and not getTopLevelElementFor ?
ITopLevelElement getTopLevelElementContextFor(EObject modelElement);
/** Returns whether the some storage provider has unsaved changes. */
diff --git a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/service/IPrototypeService.java b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/service/IPrototypeService.java
index 583e112d1..796714efa 100644
--- a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/service/IPrototypeService.java
+++ b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/service/IPrototypeService.java
@@ -35,7 +35,7 @@ import org.fortiss.tooling.kernel.internal.PrototypeService;
* @author hoelzl
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: 1BDCBB77BE5A3FBC71081D73B5627C0C
+ * @ConQAT.Rating GREEN Hash: 1E77C1DDE59B00E4FE31D85709CD40F1
*/
public interface IPrototypeService {
diff --git a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/service/base/EObjectAware2ServiceBase.java b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/service/base/EObjectAware2ServiceBase.java
index 95ebbe708..1f2d733eb 100644
--- a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/service/base/EObjectAware2ServiceBase.java
+++ b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/service/base/EObjectAware2ServiceBase.java
@@ -67,7 +67,7 @@ import org.osgi.framework.Bundle;
* @author hoelzlf
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: 6FE5EF3092D437F3FF884423D2586506
+ * @ConQAT.Rating GREEN Hash: 68234E8D2E623CB3492E3DEBD97D61FC
*/
public abstract class EObjectAware2ServiceBase<T extends IEObjectAware2<? extends EObject, ? extends EObject>> {
diff --git a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/service/base/EObjectAwareServiceBase.java b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/service/base/EObjectAwareServiceBase.java
index 152ed2285..1eb4ac90c 100644
--- a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/service/base/EObjectAwareServiceBase.java
+++ b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/service/base/EObjectAwareServiceBase.java
@@ -64,7 +64,7 @@ import org.osgi.framework.Bundle;
* @author hoelzlf
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: 725BAAF5C5E50725A2444E91B66D3CD1
+ * @ConQAT.Rating GREEN Hash: DCEC975EF973BA6B3385D458381F7E3D
*/
public abstract class EObjectAwareServiceBase<T extends IEObjectAware<? extends EObject>> {
diff --git a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/service/base/IEObjectAware.java b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/service/base/IEObjectAware.java
index b5bb9d376..8654c8d0e 100644
--- a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/service/base/IEObjectAware.java
+++ b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/service/base/IEObjectAware.java
@@ -37,7 +37,7 @@ import org.fortiss.tooling.kernel.service.IElementCompositorService;
* @author hoelzl
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: 9CD9972A45FB1C3E8F1BE6A4275546AE
+ * @ConQAT.Rating GREEN Hash: 0A3C635BA583EF368DB2E394AF2B76A3
*/
public interface IEObjectAware<T extends EObject> {
// nothing specific is need here
diff --git a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/service/base/IEObjectAware2.java b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/service/base/IEObjectAware2.java
index 493653933..318f05f18 100644
--- a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/service/base/IEObjectAware2.java
+++ b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/service/base/IEObjectAware2.java
@@ -37,7 +37,7 @@ import org.fortiss.tooling.kernel.service.IConnectionCompositorService;
* @author hoelzl
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: B4DC46BA5960A4DBBC199EAFFF17E605
+ * @ConQAT.Rating GREEN Hash: 97D29062614C5E30453F4B16A04A2A10
*/
public interface IEObjectAware2<S extends EObject, T extends EObject> extends
IEObjectAware<T> {
diff --git a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/service/base/package.html b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/service/base/package.html
index fad20a062..59eb3c6be 100644
--- a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/service/base/package.html
+++ b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/service/base/package.html
@@ -1,7 +1,7 @@
<!--
$Id$
@version $Rev$
- @ConQAT.Rating YELLOW Hash: 446D40A0E4D5A10A2765B1A0FB8215A5
+ @ConQAT.Rating GREEN Hash: 8A8A45255454F08E12A70FB6867D0155
-->
<body>
Abstract base implementations for the kernel services.
diff --git a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/service/package.html b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/service/package.html
index 9939aa3cb..410b18d05 100644
--- a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/service/package.html
+++ b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/service/package.html
@@ -1,7 +1,7 @@
<!--
$Id$
@version $Rev$
- @ConQAT.Rating YELLOW Hash: AA0B81138FE2E7D14D47B61C0465D535
+ @ConQAT.Rating GREEN Hash: D1F74AF2CA514F3B272F63D5DC9757CB
-->
<body>
Interface definitions of the kernel services. Each interface corresponds to a certain functionality of the kernel.
--
GitLab