diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/dnd/CompositionServiceLocalCopyPasteTransfer.java b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/dnd/CompositionServiceLocalCopyPasteTransfer.java
index 5a09b0256b2e90ef6b07f040c470635b1e396451..118090102086cd9e5f782a81c533cb6ec72085ab 100644
--- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/dnd/CompositionServiceLocalCopyPasteTransfer.java
+++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/dnd/CompositionServiceLocalCopyPasteTransfer.java
@@ -32,7 +32,7 @@ import org.fortiss.tooling.kernel.service.IElementCompositorService;
* @author hoelzl
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: C4A39BE50B2BEFAF5F14754943920C1A
+ * @ConQAT.Rating GREEN Hash: FF31D6F7A71D2A2CE37F7ABE2EAFA593
*/
public class CompositionServiceLocalCopyPasteTransfer extends
SimpleObjectTransfer {
diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/dnd/CompositionServiceLocalDNDTransfer.java b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/dnd/CompositionServiceLocalDNDTransfer.java
index c26e13a202fb1237fa9f5586e641e0128bfc34ad..36e224d07b60634472f0d660a2c5aa40701decf1 100644
--- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/dnd/CompositionServiceLocalDNDTransfer.java
+++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/dnd/CompositionServiceLocalDNDTransfer.java
@@ -33,7 +33,7 @@ import org.fortiss.tooling.kernel.service.IElementCompositorService;
* @author hoelzl
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: 5169C8BD6F5DFB37A4FAB9C70E309861
+ * @ConQAT.Rating GREEN Hash: 3FBAB8464E7ECE8B69F3B49168EB7E21
*/
public class CompositionServiceLocalDNDTransfer extends SimpleObjectTransfer {
/** Singleton instance. */
diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/dnd/ConnectionCompositionDragSourceAdapter.java b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/dnd/ConnectionCompositionDragSourceAdapter.java
index fb2e852c434e378cc2164fb77bc05b4dbd0138e1..f85a00ce7e6808dfa9e97fd5ac70e050c25a0d3b 100644
--- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/dnd/ConnectionCompositionDragSourceAdapter.java
+++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/dnd/ConnectionCompositionDragSourceAdapter.java
@@ -35,7 +35,7 @@ import org.eclipse.swt.dnd.DragSourceAdapter;
* @author hoelzl
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: BC296AB36683BA41596609D5F1C08EB9
+ * @ConQAT.Rating GREEN Hash: 8A512C1E79E60FF146D0269B51227DAD
*/
public abstract class ConnectionCompositionDragSourceAdapter extends
ElementCompositionDragSourceAdapter {
diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/dnd/ConnectionCompositionDropTargetAdapter.java b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/dnd/ConnectionCompositionDropTargetAdapter.java
index 97b42263dd3264f9aa37ce7810092dfb85f3b67b..03f3bdcab89b68f0b1b91c57b7ca687d7ad72ff0 100644
--- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/dnd/ConnectionCompositionDropTargetAdapter.java
+++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/dnd/ConnectionCompositionDropTargetAdapter.java
@@ -34,7 +34,7 @@ import org.fortiss.tooling.kernel.service.IConnectionCompositorService;
* @author hoelzl
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: D54893DCC7518DBBE02F92827BB2418A
+ * @ConQAT.Rating GREEN Hash: 11BB46E8DAD057A518FA32C43B985D30
*/
public abstract class ConnectionCompositionDropTargetAdapter extends
DropTargetAdapter {
diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/dnd/ConnectionCompositionSource.java b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/dnd/ConnectionCompositionSource.java
index 85320e81d448cc9523c59f0144d481afa753a21a..db57a0ec26aa15fb5bbf85b2f1b8699626fbc3e3 100644
--- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/dnd/ConnectionCompositionSource.java
+++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/dnd/ConnectionCompositionSource.java
@@ -28,7 +28,7 @@ import org.fortiss.tooling.kernel.service.IConnectionCompositorService;
* @author hoelzl
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: F146EB39DD806F5A40DED1CA93D74F7A
+ * @ConQAT.Rating GREEN Hash: 4B7B233AD01792FF782880603219374B
*/
public class ConnectionCompositionSource extends ElementCompositionSource {
/** Stores the parent element for use in connection composition. */
diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/dnd/ElementCompositionDragSourceAdapter.java b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/dnd/ElementCompositionDragSourceAdapter.java
index 608f55638eb636844e561ad33a84996e1ff82cfc..718e394cdcab691ea1e9ded826093ab7a49bcda8 100644
--- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/dnd/ElementCompositionDragSourceAdapter.java
+++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/dnd/ElementCompositionDragSourceAdapter.java
@@ -34,7 +34,7 @@ import org.eclipse.swt.dnd.Transfer;
* @author hoelzl
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: B29FA6FC8720DBBD2AE8807F5FE9DC46
+ * @ConQAT.Rating GREEN Hash: D4F6D51798BDE2F2A8C348287E42B344
*/
public abstract class ElementCompositionDragSourceAdapter extends
DragSourceAdapter {
diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/dnd/ElementCompositionDropTargetAdapter.java b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/dnd/ElementCompositionDropTargetAdapter.java
index cf5b2518843d74e9e73764d30dbef76f70838fc5..c4385cf51093bf3044ead0db275f6f60305f4713 100644
--- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/dnd/ElementCompositionDropTargetAdapter.java
+++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/dnd/ElementCompositionDropTargetAdapter.java
@@ -34,7 +34,7 @@ import org.fortiss.tooling.kernel.service.IElementCompositorService;
* @author hoelzl
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: C26BA94BBBB077835EDB9298D41E7EF5
+ * @ConQAT.Rating GREEN Hash: D5FA2315AA3F0C3CFD92E9456DE94B9A
*/
public abstract class ElementCompositionDropTargetAdapter extends
DropTargetAdapter {
diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/dnd/ElementCompositionSource.java b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/dnd/ElementCompositionSource.java
index 601bbf2f1d0108db426b7c29794c6f22d1b67039..1cfafb3f621f8893ae3a97888195d168422ae291 100644
--- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/dnd/ElementCompositionSource.java
+++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/dnd/ElementCompositionSource.java
@@ -28,7 +28,7 @@ import org.fortiss.tooling.kernel.service.IElementCompositorService;
* @author hoelzl
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: C8BE422248D89555D262BED1F8815C99
+ * @ConQAT.Rating GREEN Hash: A8B1B3B73BCCAD81F00FEDD2272CD3E3
*/
public class ElementCompositionSource {
diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/dnd/package.html b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/dnd/package.html
index 56ff3be057a1f8b0f2875ff5bda2e283e06ddcdd..612fe3c563e048b3a97b4fbd8eac97dd8fa95121 100644
--- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/dnd/package.html
+++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/dnd/package.html
@@ -1,7 +1,7 @@
<!--
$Id: package.html 835 2011-06-28 07:31:00Z ratiu $
@version $Rev: 835 $
- @ConQAT.Rating YELLOW Hash: 3EA4EA7091245D0A40304F5CD8136DA9
+ @ConQAT.Rating GREEN Hash: AD7A328817E111D2DBE64C89A0405215
-->
<body>
Support classes for using the SWT-based drag and drop mechanism.
diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/IModelEditor.java b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/IModelEditor.java
index 3bb62f4a3279a3dc26d07b5f358815c93b8c25b9..393d2ef6afca41df6f7c3d16e8fc535b046c9c7c 100644
--- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/IModelEditor.java
+++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/IModelEditor.java
@@ -26,7 +26,7 @@ import org.eclipse.ui.IEditorPart;
* @author hoelzl
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: CD4AF6D1FAD865473DCF9928CF7C245D
+ * @ConQAT.Rating GREEN Hash: 95A80A3A24D4CA4B5662B2416E910C8C
*/
public interface IModelEditor<T extends EObject> extends IEditorPart {
/** Returns the edited object. */
diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/IModelElementHandler.java b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/IModelElementHandler.java
index 45b2b851bd24d6ee840ce34c1dd79231af74db1f..5be7cbb59106300694cbcb321dff863fbb2338ec 100644
--- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/IModelElementHandler.java
+++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/IModelElementHandler.java
@@ -38,11 +38,14 @@ import org.fortiss.tooling.kernel.ui.service.IModelElementHandlerService;
* @author hoelzl
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: B70658CE4F4F97254156C590DF944C2B
+ * @ConQAT.Rating RED Hash: 4E314066E959BB2F449657AD8F254BFA
*/
public interface IModelElementHandler<T extends EObject> extends
IEObjectAware<T> {
+ // TODO @Review CD:unsure about visibilities. possibly emphasize by using
+ // /*package*/ Object name....
+
/** Returns the name of the model element (if any). */
String getName(T element);
@@ -92,10 +95,4 @@ public interface IModelElementHandler<T extends EObject> extends
* navigator's simplified non-expert view.
*/
boolean hiddenInNonExpertView();
-
- /**
- * Handles the open model element request by returning the object that
- * should be passed to the model editor service.
- */
- EObject handleOpenModelElementRequest(T element);
}
diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/base/EObjectActionBase.java b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/base/EObjectActionBase.java
index 1dcaef18ab393f9a949e0a59da34daad74ccdf8c..ab3cce8858232f2821f3eb92cb310b6c0d2b57dc 100644
--- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/base/EObjectActionBase.java
+++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/base/EObjectActionBase.java
@@ -27,7 +27,7 @@ import org.eclipse.jface.resource.ImageDescriptor;
* @author hoelzlf
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: 1EBE28874A90F7EC98B7FED5E6FF0214
+ * @ConQAT.Rating GREEN Hash: 9995CEA8009A5730AC380E5017A51C5F
*/
public abstract class EObjectActionBase<T extends EObject> extends Action {
diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/base/EditorBase.java b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/base/EditorBase.java
index 152231a546dd80016175d86ddc0108ace7a40ce9..5c10c0b452be8c0d2f2822c4fae3e4c332e1833a 100644
--- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/base/EditorBase.java
+++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/base/EditorBase.java
@@ -41,7 +41,7 @@ import org.fortiss.tooling.kernel.ui.internal.editor.ModelElementEditorInput;
* @author hoelzlf
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: 8E78A5604AD81E0BA5E5124F58512E6A
+ * @ConQAT.Rating RED Hash: DF6DB4EFA6BC29413748BFF39E53C654
*/
public abstract class EditorBase<T extends EObject> extends EditorPart
implements IActionContributingEditor, IModelEditor<T> {
@@ -50,9 +50,13 @@ public abstract class EditorBase<T extends EObject> extends EditorPart
* The object shown in this editor. This is valid as soon as
* {@link #init(IEditorSite, IEditorInput)} has been called.
*/
+ // TODO @Review CD:possibly final?
+ // moreover: field often called directly instead of using getter. reduce
+ // visibility?
protected T editedObject;
/** The model element handler to be used with the {@link #editedObject}. */
+ // TODO @Review CD: as far as I can see this can be made final
protected IModelElementHandler<T> handler;
/** Databinding context used for model changes. */
diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/base/PropertySectionBase.java b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/base/PropertySectionBase.java
index a46f78abd082cee2865d929a3d4e7fa8916b27a7..053d97bdfe54ad479cc9d26fd48af8cc630ce489 100644
--- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/base/PropertySectionBase.java
+++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/base/PropertySectionBase.java
@@ -49,7 +49,7 @@ import org.fortiss.tooling.kernel.ui.util.DataBindingUtils;
* @author hoelzl
* @author $Author$
* @version $Rev$
- * @ConQAT.Rating YELLOW Hash: C933211F21A9E76CBE2281807031C684
+ * @ConQAT.Rating GREEN Hash: 532E5AECE5CF1BAB9CC2A690D10FAC34
*/
public abstract class PropertySectionBase extends AbstractPropertySection {
diff --git a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/data/package.html b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/data/package.html
index 09da899cca61c2b2ab4d8fad7d2b54e11f5013a3..b74a74d3192987bd2670903ee1e74f44058ebfd9 100644
--- a/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/data/package.html
+++ b/org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/data/package.html
@@ -4,6 +4,11 @@
@ConQAT.Rating YELLOW Hash: 4937634A5C7499B64F188C4A364D8A16
-->
<body>
+// TODO @Review CD: I do not see obvious sufficient resemblance between this explanation and the class.
+<br>
+<br>
+
+
Interfaces and classes for data transfer between the kernel and extensions.
<P>
The classes and interfaces of this package appear as parameter and result types of the