From f1dfabf4adfc6d1a57d59d28738c2e8ca9c576a2 Mon Sep 17 00:00:00 2001
From: Johannes Eder <eder@fortiss.org>
Date: Mon, 9 Mar 2020 15:59:13 +0100
Subject: [PATCH] RED
Issue-Ref: 3924
Issue-Url: https://af3-developer.fortiss.org/issues/3924
Signed-off-by: Johannes Eder <eder@fortiss.org>
---
.../src/org/fortiss/tooling/common/ui/javafx/lwfxef/.ratings | 2 +-
.../javafx/lwfxef/visual/elliptic/EllipticBorderLocation.java | 2 ++
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/org.fortiss.tooling.common.ui/src/org/fortiss/tooling/common/ui/javafx/lwfxef/.ratings b/org.fortiss.tooling.common.ui/src/org/fortiss/tooling/common/ui/javafx/lwfxef/.ratings
index 1d69252bb..52b5d14c7 100644
--- a/org.fortiss.tooling.common.ui/src/org/fortiss/tooling/common/ui/javafx/lwfxef/.ratings
+++ b/org.fortiss.tooling.common.ui/src/org/fortiss/tooling/common/ui/javafx/lwfxef/.ratings
@@ -9,4 +9,4 @@ FeedbackChange.java b088fa89af648f1674f2f9c1f7f99d585ce801ca GREEN
GridCanvasVisual.java 734027d56af342cd01ff445ba9347b8dbb6c83c2 GREEN
MVCBundleManager.java 2b4ab114c55b30a3d98d7135458f8f3ddd244d58 GREEN
MouseState.java ff90af6d1cca427ef6f3fded76367b535120a5df GREEN
-SVGExporter.java cbbd1eceb2910fd5c1693e05c5303a193127b9db YELLOW
+SVGExporter.java cbbd1eceb2910fd5c1693e05c5303a193127b9db GREEN
diff --git a/org.fortiss.tooling.common.ui/src/org/fortiss/tooling/common/ui/javafx/lwfxef/visual/elliptic/EllipticBorderLocation.java b/org.fortiss.tooling.common.ui/src/org/fortiss/tooling/common/ui/javafx/lwfxef/visual/elliptic/EllipticBorderLocation.java
index 6775dd54c..af451b11d 100644
--- a/org.fortiss.tooling.common.ui/src/org/fortiss/tooling/common/ui/javafx/lwfxef/visual/elliptic/EllipticBorderLocation.java
+++ b/org.fortiss.tooling.common.ui/src/org/fortiss/tooling/common/ui/javafx/lwfxef/visual/elliptic/EllipticBorderLocation.java
@@ -51,6 +51,8 @@ public final class EllipticBorderLocation {
/**
* Returns the location computed from this {@link EllipticBorderLocation} relative to the
* ellipse center.
+ * TODO(JE): leads to java.lang.ArithmeticException: / by zero if cos is 0. What is the
+ * difference to the existing code? Why is an adaption needed?
*/
public DiagramCoordinate getLocation() {
double angle = Math.PI * angleInDegree / 180;
--
GitLab