Skip to content
Snippets Groups Projects
Unverified Commit 53d71cd8 authored by Bob Callaway's avatar Bob Callaway Committed by GitHub
Browse files

Improve separation between type implementations and CLI code (#339)


* Refactor PKI factory and add type checking

This allows for more DRY addition of new PKI types, and stricter
type checking. This also allows for simpler enumeration of
supported PKI formats which will be used in further updates to
simplify the CLI codebase.

Signed-off-by: default avatarBob Callaway <bob.callaway@gmail.com>

* revamp CLI flags; support different versions for upload

Signed-off-by: default avatarBob Callaway <bob.callaway@gmail.com>

* Add Alpine Package type

This adds support for the alpine package format used by Alpine Linux,
which is the concatenation of three tgz files (signature, control data,
and then the actual package files).

Signed-off-by: default avatarBob Callaway <bob.callaway@gmail.com>

* use shaFlag for --artifact-hash

Signed-off-by: default avatarBob Callaway <bob.callaway@gmail.com>

* change arg type to PKIFormat

Signed-off-by: default avatarBob Callaway <bob.callaway@gmail.com>

* defer type-specific validation logic to type code (instead of in CLI); also use CliLogger throughout CLI

Signed-off-by: default avatarBob Callaway <bob.callaway@gmail.com>

* refactor factory code

Signed-off-by: default avatarBob Callaway <bob.callaway@gmail.com>

* review comments

Signed-off-by: default avatarBob Callaway <bob.callaway@gmail.com>
parent e63fe717
No related branches found
No related tags found
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment