Skip to content
Snippets Groups Projects
Commit 0d4e17e8 authored by Simon Barner's avatar Simon Barner
Browse files

- Fix SWT Image leak

refs 2709
parent 99dfbe72
No related branches found
No related tags found
No related merge requests found
......@@ -30,6 +30,7 @@ import org.eclipse.emf.ecore.EObject;
import org.eclipse.jface.action.Action;
import org.eclipse.jface.action.IToolBarManager;
import org.eclipse.jface.action.Separator;
import org.eclipse.jface.resource.ImageDescriptor;
import org.eclipse.jface.viewers.CellLabelProvider;
import org.eclipse.jface.viewers.ColumnViewerToolTipSupport;
import org.eclipse.jface.viewers.IStructuredSelection;
......@@ -39,6 +40,7 @@ import org.eclipse.swt.graphics.Image;
import org.eclipse.swt.layout.FillLayout;
import org.eclipse.swt.widgets.Composite;
import org.eclipse.ui.part.ViewPart;
import org.eclipse.wb.swt.ResourceManager;
import org.fortiss.tooling.kernel.extension.data.IConstraintViolation;
import org.fortiss.tooling.kernel.extension.data.IConstraintViolation.ESeverity;
import org.fortiss.tooling.kernel.service.IPersistencyService;
......@@ -53,7 +55,7 @@ import org.fortiss.tooling.kernel.ui.service.IModelElementHandlerService;
* @author hoelzl
* @author $Author$
* @version $Rev$
* @ConQAT.Rating GREEN Hash: F7502A796B32B1C64DD80A4C3671200F
* @ConQAT.Rating YELLOW Hash: 0B397D9F1501CDBECCF10925257AB363
*/
public class MarkerViewPart extends ViewPart {
......@@ -87,13 +89,15 @@ public class MarkerViewPart extends ViewPart {
@Override
public void update(ViewerCell cell) {
if(cell.getElement() instanceof ESeverity) {
cell.setText(((ESeverity)cell.getElement()).toString());
final ESeverity severity = (ESeverity)cell.getElement();
cell.setText(severity.toString());
Image oldImage = cell.getImage();
if(oldImage != null) {
oldImage.dispose();
}
cell.setImage(IMarkerService.getInstance()
.getImageFor((ESeverity)cell.getElement(), false).createImage());
final ImageDescriptor imageDescr =
IMarkerService.getInstance().getImageFor(severity, false);
cell.setImage(ResourceManager.getImage(imageDescr));
} else {
cell.setText("");
}
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment