code review

org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/extension/IConnectionCompositor.java

@@ -47,7 +47,7 @@ import org.fortiss.tooling.kernel.service.base.IEObjectAware2;
  * @author hoelzl
  * @author $Author$
  * @version $Rev$
- * @ConQAT.Rating GREEN Hash: E742F52CFB04C7A360DB5B8E6B298A9B
+ * @ConQAT.Rating GREEN Hash: FB4A39FA785FA53441998CE212CA9017
  */
 public interface IConnectionCompositor<P extends EObject, S extends EObject, T extends EObject>
 		extends IEObjectAware2<S, T> {

org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/extension/IElementCompositor.java

@@ -39,7 +39,7 @@ import org.fortiss.tooling.kernel.service.base.IEObjectAware;
  * @author hoelzl
  * @author $Author$
  * @version $Rev$
- * @ConQAT.Rating GREEN Hash: 4F8B26BA3A47A0A7E09A8E3528BBA598
+ * @ConQAT.Rating GREEN Hash: 4929B7B9EBEB238C092A10FBB4E854F1
  */
 public interface IElementCompositor<C extends EObject> extends IEObjectAware<C> {
 	/**

org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/extension/ITransformationProvider.java

@@ -33,7 +33,7 @@ import org.fortiss.tooling.kernel.service.base.IObjectAware2;
  * @author hoelzl
  * @author $Author$
  * @version $Rev$
- * @ConQAT.Rating YELLOW Hash: BD2DD3B19C8FF84B0F5544D6D1BFD19D
+ * @ConQAT.Rating GREEN Hash: F0053C7CED31063AA1AA02BFAB0791BB
  */
 public interface ITransformationProvider extends IObjectAware2<Object, Object> {
 

org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/extension/base/ConstraintViolationBase.java

@@ -23,10 +23,13 @@ import org.fortiss.tooling.kernel.extension.data.IConstraintViolation;
 /**
  * Base implementation for model element constraint checkers.
  * 
+ * TODO: the above comment is not aligned with the name of the class - should we
+ * use a better docu?
+ * 
  * @author hoelzl
  * @author $Author$
  * @version $Rev$
- * @ConQAT.Rating YELLOW Hash: 3DDF9C3071E7CA9B599EFAFEEC27DDFF
+ * @ConQAT.Rating RED Hash: 8D1F169799F4A0110E68D25482929E80
  */
 public abstract class ConstraintViolationBase<T extends EObject> implements
 		IConstraintViolation<T> {

org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/extension/base/TransformationContextChainBase.java

@@ -26,7 +26,7 @@ import org.fortiss.tooling.kernel.extension.data.ITransformationContext;
  * @author hoelzl
  * @author $Author$
  * @version $Rev$
- * @ConQAT.Rating YELLOW Hash: 662BCDD98432EED08BA052803173A5D0
+ * @ConQAT.Rating GREEN Hash: F98256FB0E0A681F13136FC0C2348369
  */
 public abstract class TransformationContextChainBase implements
 		ITransformationContext {
@@ -51,14 +51,14 @@ public abstract class TransformationContextChainBase implements
 
 	/** Finds an ITransform of the given class in the chain. */
 	@SuppressWarnings("unchecked")
-	public <T extends ITransformationContext> T findContextinChain(
+	public <T extends ITransformationContext> T findContextInChain(
 			Class<T> clazz) {
 		if (clazz.isAssignableFrom(this.getClass())) {
 			return (T) this;
 		}
 		if (chainedContext instanceof TransformationContextChainBase) {
 			return ((TransformationContextChainBase) chainedContext)
-					.findContextinChain(clazz);
+					.findContextInChain(clazz);
 		}
 		return null;
 	}

org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/extension/data/ITopLevelElement.java

@@ -40,7 +40,7 @@ import org.fortiss.tooling.kernel.extension.IStorageProvider;
  * @author hoelzl
  * @author $Author$
  * @version $Rev$
- * @ConQAT.Rating YELLOW Hash: DE8A819268F75497B61A48B6E32A648F
+ * @ConQAT.Rating GREEN Hash: 85B4A36E3F052F4BED404969E3CDB7B0
  */
 public interface ITopLevelElement {
 

org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/extension/data/ModelElementTransformationContext.java

@@ -26,7 +26,7 @@ import org.fortiss.tooling.kernel.extension.base.TransformationContextChainBase;
  * @author hoelzl
  * @author $Author$
  * @version $Rev$
- * @ConQAT.Rating YELLOW Hash: 0E04AF20E122C47C6545809D144811E0
+ * @ConQAT.Rating GREEN Hash: F585ABF0304B72F06AF002690C0FD68E
  */
 public class ModelElementTransformationContext extends
 		TransformationContextChainBase {

org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/extension/data/Prototype.java

@@ -27,12 +27,13 @@ import org.eclipse.emf.ecore.util.EcoreUtil;
  * @author hoelzl
  * @author $Author$
  * @version $Rev$
- * @ConQAT.Rating YELLOW Hash: 462A5E84E8BF482222209236A2855BEC
+ * @ConQAT.Rating GREEN Hash: 44143526E8A49A4CE9E0D982F1ABA4F3
  */
 public final class Prototype {
 
 	/** The generic prototype name. */
 	private final String name;
+
 	/** The pre-configured {@link EObject}. */
 	private final EObject prototype;
 
@@ -52,9 +53,7 @@ public final class Prototype {
 		return prototype;
 	}
 
-	/**
-	 * Returns a copy of the prototype. This method is potentially expensive.
-	 */
+	/** Returns a copy of the prototype. This method is potentially expensive. */
 	public EObject getPrototypeCopy() {
 		return EcoreUtil.copy(prototype);
 	}

org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/CommandStackService.java

@@ -32,9 +32,10 @@ import org.fortiss.tooling.kernel.utils.LoggingUtils;
  * @author hoelzl
  * @author $Author$
  * @version $Rev$
- * @ConQAT.Rating YELLOW Hash: BA190E69F3975AEA8C17310496C653BE
+ * @ConQAT.Rating GREEN Hash: 4EC48FE57128162812231DF1915E0DFA
  */
 public class CommandStackService implements ICommandStackService {
+
 	/** {@inheritDoc} */
 	@Override
 	public void runAsCommand(EObject target, Runnable runner) {

org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/ConnectionCompositorService.java

@@ -33,7 +33,7 @@ import org.fortiss.tooling.kernel.service.base.EObjectAware2ServiceBase;
  * @author hoelzl
  * @author $Author$
  * @version $Rev$
- * @ConQAT.Rating GREEN Hash: 51C72E3E2B906CA666B2A2649441B518
+ * @ConQAT.Rating GREEN Hash: 8EA9DA35FC5ABE4E59208DA0DA509CE0
  */
 public class ConnectionCompositorService
 		extends

org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/ElementCompositorService.java

@@ -33,7 +33,7 @@ import org.fortiss.tooling.kernel.service.base.EObjectAwareServiceBase;
  * @author hoelzl
  * @author $Author$
  * @version $Rev$
- * @ConQAT.Rating GREEN Hash: DC6A32F0B679D71C283A86517CF900BA
+ * @ConQAT.Rating GREEN Hash: 83DB3A776C6AEFFBDF6E5AB03FDAEFCA
  */
 public final class ElementCompositorService extends
 		EObjectAwareServiceBase<IElementCompositor<EObject>> implements

org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/PersistencyService.java

@@ -49,7 +49,7 @@ import org.osgi.framework.Bundle;
  * @author hoelzl
  * @author $Author$
  * @version $Rev$
- * @ConQAT.Rating YELLOW Hash: 060A162FF7D175A41E24EA12218D968F
+ * @ConQAT.Rating GREEN Hash: 9B4C1045CBB864223484897D94848F95
  */
 public class PersistencyService implements IPersistencyService {
 

org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/TransformationService.java

@@ -37,7 +37,7 @@ import org.fortiss.tooling.kernel.service.base.ObjectAware2ServiceBase;
  * @author hoelzl
  * @author $Author$
  * @version $Rev$
- * @ConQAT.Rating YELLOW Hash: F56BA3742E56A3E35A84F57E987FEED3
+ * @ConQAT.Rating GREEN Hash: 6B458E38F49D0A7A496096B0A265405D
  */
 public class TransformationService extends
 		ObjectAware2ServiceBase<ITransformationProvider> implements

org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/storage/eclipse/EMFTransactionalCommand.java

@@ -38,7 +38,7 @@ import org.fortiss.tooling.kernel.utils.LoggingUtils;
  * @author hummel
  * @author $Author$
  * @version $Rev$
- * @ConQAT.Rating YELLOW Hash: 27D92C7B38D1ECDF229AAE5E7CFA8C94
+ * @ConQAT.Rating GREEN Hash: 3A80DC630AEA6971552C44802D7533A3
  */
 public class EMFTransactionalCommand implements Command {
 
@@ -97,9 +97,7 @@ public class EMFTransactionalCommand implements Command {
 		});
 	}
 
-	/**
-	 * Executes the given runnable in a transaction.
-	 */
+	/** Executes the given runnable in a transaction. */
 	private void runInTransaction(Runnable runnable) {
 		Transaction tx = null;
 		try {

org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/storage/eclipse/ModelContext.java

@@ -52,7 +52,7 @@ import org.fortiss.tooling.kernel.utils.LoggingUtils;
  * @author hummel
  * @author $Author$
  * @version $Rev$
- * @ConQAT.Rating YELLOW Hash: 9B3C3C5DF436704CB38392ECEC8E5E64
+ * @ConQAT.Rating GREEN Hash: AAAEB5802D74F212F47C25AD613B97CF
  */
 class ModelContext implements ITopLevelElement {
 

org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/storage/eclipse/package.html

 <!--  
   $Id$
   @version $Rev$
-  @ConQAT.Rating YELLOW Hash: C8BC7DC15E2C9B1D3EEB7A9611BBB9B1
+  @ConQAT.Rating GREEN Hash: B397C5A502FDE8C3B7EF89A8FAE80D37
 -->
 <body>
 Implementation of the <code>IStorageProvider</code> interface using Eclipse file resources as storage mechanism for models.
@@ -12,7 +12,7 @@ For each such files the set of registered <code>eclipseResourceStorageLocationPr
 asked whether the respective file should be considered a model file. This extension mechanism is used
 to allow independent tools (running in the same Eclipse instance or two RCPs running independently) to use
 different file extensions for their models, e.g., tool A uses file pattern "*.toolA", while tool B uses
-the file pattern "*.toolP". The file extension is usually a hint on the meta-model class of the contained root
+the file pattern "*.toolB". The file extension is usually a hint on the meta-model class of the contained root
 model element.
 
 </body>

org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/service/IConnectionCompositorService.java

@@ -35,7 +35,7 @@ import org.fortiss.tooling.kernel.internal.ConnectionCompositorService;
  * @author hoelzl
  * @author $Author$
  * @version $Rev$
- * @ConQAT.Rating GREEN Hash: 982C28C5882DC9ED374779B6059D096D
+ * @ConQAT.Rating GREEN Hash: C946551167EBAC9E9C1296FD20E198E1
  */
 public interface IConnectionCompositorService {
 

org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/service/IElementCompositorService.java

@@ -35,7 +35,7 @@ import org.fortiss.tooling.kernel.internal.ElementCompositorService;
  * @author hoelzl
  * @author $Author$
  * @version $Rev$
- * @ConQAT.Rating GREEN Hash: 72BAA99C391B2206BCB495943F28FBF5
+ * @ConQAT.Rating GREEN Hash: 133F80DB408CFA904C4FBB8B7BFC9F47
  */
 public interface IElementCompositorService {
 

org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/service/ITransformationService.java

@@ -26,7 +26,7 @@ import org.fortiss.tooling.kernel.extension.exception.TransformationFailedExcept
 import org.fortiss.tooling.kernel.internal.TransformationService;
 
 /**
- * The transformation service provides registratoin and access to transformation
+ * The transformation service provides registration and access to transformation
  * providers. A transformation provider knows how to transform a given source
  * object into an instance of a given target class using the provided context
  * information.
@@ -36,7 +36,7 @@ import org.fortiss.tooling.kernel.internal.TransformationService;
  * @author hoelzl
  * @author $Author$
  * @version $Rev$
- * @ConQAT.Rating YELLOW Hash: AE9EAD90C7E6E1BBEF27698F49CA2F69
+ * @ConQAT.Rating GREEN Hash: 1A3F5C9BB18ACEB99A11FDC5321D3CA7
  */
 public interface ITransformationService {
 

org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/service/base/EObjectAware2ServiceBase.java

@@ -54,7 +54,7 @@ import org.fortiss.tooling.kernel.internal.ElementCompositorService;
  * @author hoelzlf
  * @author $Author$
  * @version $Rev$
- * @ConQAT.Rating YELLOW Hash: 776368E364F25CDD4BBD1200383D1B5A
+ * @ConQAT.Rating GREEN Hash: D96C0E23657D6FF5EF7D86C37F3D9AE9
  */
 public abstract class EObjectAware2ServiceBase<T extends IEObjectAware2<? extends EObject, ? extends EObject>>
 		extends ObjectAware2ServiceBase<T> {