RED (3 related FIXME)

Issue-Ref: 3862
Issue-Url: af3#3862



Signed-off-by: Sebastian Bergemann <bergemann@fortiss.org>

org.fortiss.tooling.ext.variability.ui/src/org/fortiss/tooling/ext/variability/ui/util/PresenceConditionProposalProvider.java

@@ -61,6 +61,8 @@ public class PresenceConditionProposalProvider extends ProposalProviderBase {
 
 		List<String> stringLiterals = literals.stream().map(l -> l.getName()).collect(toList());
 
+		// FIXME (SB): if you have a final operator list (in the utils class), you can replace this
+		// list here with it.
 		stringLiterals.addAll(asList("DEFAULT", "NOT", "AND", "OR"));
 
 		List<String> proposals =

org.fortiss.variability/src/org/fortiss/variability/util/VariabilityUtils.java

@@ -156,6 +156,8 @@ public class VariabilityUtils {
 	 * @return Whether the given name is compatible with the presence condition systax.
 	 */
 	public static boolean isNameLegalInPresenceCondition(String literalName) {
+		// FIXME (SB): if you have a final operator list (in the utils class), you can use this here
+		// (go through it with stream and return the false when anyMatch hits)
 		if(literalName.equals("OR") || literalName.equals("AND") || literalName.equals("NOT") ||
 				literalName.equals("DEFAULT")) {
 			return false;

org.fortiss.variability/src/org/fortiss/variability/util/VariabilityUtilsInternal.java

@@ -49,6 +49,9 @@ public class VariabilityUtilsInternal {
 	public final static String FEATURE_LITERAL_LEGAL_CHAR_REGEX =
 			"[a-zA-Z\\d\\$&\\[\\]_\\-\\+@/\\\\,\\.=]";
 
+	// FIXME (SB): add a final string list containing all valid operators (AND, OR, ...) to be able
+	// to use this list a other places
+
 	/**
 	 * Retrieves all elements of type T from a containment tree. The 'context' is
 	 * any element in a containment tree. The result will also contain all parents,