cleanup of kernel classes => YELLOW

3171d5d0 · Florian Hölzl · 7d05072a · 3171d5d0 · 3171d5d0 · 3171d5d0
Commit 3171d5d0 authored 13 years ago by Florian Hölzl
--- a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/CommandStackService.java
+++ b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/CommandStackService.java
@@ -32,7 +32,7 @@ import org.fortiss.tooling.kernel.util.LoggingUtils;
 * @author hoelzl
 * @author $Author$
 * @version $Rev$
- * @ConQAT.Rating GREEN Hash: 9D56A2E364F6199C6CAE194DFA9AB5AE
+ * @ConQAT.Rating YELLOW Hash: 77093BE6ACCF48F747456A3E17E4F837
 */
 public class CommandStackService implements ICommandStackService {
 	/** {@inheritDoc} */

--- a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/ConnectionCompositorService.java
+++ b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/ConnectionCompositorService.java
@@ -31,7 +31,7 @@ import org.fortiss.tooling.kernel.service.base.EObjectAware2ServiceBase;
 * @author hoelzl
 * @author $Author$
 * @version $Rev$
- * @ConQAT.Rating GREEN Hash: 91DC9881CCEA9F0C1EEBF5128E9FCB3C
+ * @ConQAT.Rating YELLOW Hash: 3F434A924BFA7706162D055414ECF57A
 */
 public class ConnectionCompositorService
 		extends

--- a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/ConstraintCheckerService.java
+++ b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/ConstraintCheckerService.java
@@ -33,7 +33,7 @@ import org.fortiss.tooling.kernel.service.base.EObjectAwareServiceBase;
 * @author hoelzl
 * @author $Author$
 * @version $Rev$
- * @ConQAT.Rating GREEN Hash: B81C51C19484814E4EB0693AE12282DD
+ * @ConQAT.Rating YELLOW Hash: A006E157691A87D7C02500FEAB0C9FB9
 */
 public class ConstraintCheckerService extends
 		EObjectAwareServiceBase<IConstraintChecker<EObject>> implements

--- a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/ElementCompositorService.java
+++ b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/ElementCompositorService.java
@@ -32,7 +32,7 @@ import org.fortiss.tooling.kernel.service.base.EObjectAwareServiceBase;
 * @author hoelzl
 * @author $Author$
 * @version $Rev$
- * @ConQAT.Rating GREEN Hash: 090065A55A0C7D76FEDE97D75C459D01
+ * @ConQAT.Rating YELLOW Hash: 7E6D49987FE1E3D45E1B8ECCF95774F6
 */
 public final class ElementCompositorService extends
 		EObjectAwareServiceBase<IElementCompositor<EObject>> implements

--- a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/PersistencyService.java
+++ b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/PersistencyService.java
@@ -46,7 +46,7 @@ import org.osgi.framework.Bundle;
 * @author hoelzl
 * @author $Author$
 * @version $Rev$
- * @ConQAT.Rating GREEN Hash: 92CEC917582981B1AD7A906AF31D5BE0
+ * @ConQAT.Rating YELLOW Hash: 21310FA83AEEB318D9578C72F9C7693B
 */
 public class PersistencyService implements IPersistencyService {


--- a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/PrototypeService.java
+++ b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/PrototypeService.java
@@ -40,7 +40,7 @@ import org.osgi.framework.Bundle;
 * @author hoelzl
 * @author $Author$
 * @version $Rev$
- * @ConQAT.Rating GREEN Hash: 267402CC6D535D379628A4A85CCF7F1F
+ * @ConQAT.Rating YELLOW Hash: DA18D225E16D97EB10C92E74B8880871
 */
 public class PrototypeService implements IPrototypeService {


--- a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/package.html
+++ b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/package.html
@@ -4,9 +4,9 @@
  @ConQAT.Rating GREEN Hash: 9FBEA96965AF718EB00560E14DB6D4FB
 -->
 <body>
-Implementations of the kernel services defined in the <code>kernel.services</code> package.
-Kernel services are only accessible through the singletons defined in the <code>kernel.services</code> package.
-The implementation in the current package are not intended to be used directly.
+Implementations of the kernel services defined in the <code>kernel.service</code> package.
+Kernel services are only accessible through the singletons defined in the <code>kernel.service</code> package.
+The implementation in this package are not intended to be used directly.
 Therefore they are not exported in the <code>plugin.xml</code> 
 <p>
 </body>
--- a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/storage/eclipse/EMFTransactionalCommand.java
+++ b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/storage/eclipse/EMFTransactionalCommand.java
@@ -39,7 +39,7 @@ import org.fortiss.tooling.kernel.util.LoggingUtils;
 * @author hummel
 * @author $Author$
 * @version $Rev$
- * @ConQAT.Rating YELLOW Hash: 1F16376712579A2350052EF8560C1861
+ * @ConQAT.Rating YELLOW Hash: B03C08D5C3638DC9319D608E0425960D
 */
 public class EMFTransactionalCommand implements Command {

@@ -114,12 +114,8 @@ public class EMFTransactionalCommand implements Command {
 				try {
 					tx.commit();
 				} catch (RollbackException e) {
-					// There is nothing we can do about.
-					// Maybe it even was intended, so ignore.
-					// @TODO: fail silently is a bad programming style since
-					// there are errors that are from outside not seen. Print a
-					// stacktrace should be the minimum what we do for an
-					// exception
+					LoggingUtils.log(ToolingKernelActivator.getDefault(),
+							"Transaction was rolled back!", IStatus.ERROR, e);
 				}
 			} else {
 				LoggingUtils.log(ToolingKernelActivator.getDefault(),
@@ -171,7 +167,7 @@ public class EMFTransactionalCommand implements Command {
 			return this;
 		}

-		final CompoundCommand result = new CompoundCommand();
+		CompoundCommand result = new CompoundCommand();
 		result.append(this);
 		result.append(command);
 		return result;

--- a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/storage/eclipse/EclipseResourceStorageProvider.java
+++ b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/storage/eclipse/EclipseResourceStorageProvider.java
@@ -56,7 +56,7 @@ import org.osgi.framework.Bundle;
 * @author hoelzlf
 * @author $Author$
 * @version $Rev$
- * @ConQAT.Rating YELLOW Hash: E6C694CF323750F7A6415B755FAC5522
+ * @ConQAT.Rating YELLOW Hash: EB9EBACBD5314247AC28D98B7E7BC6A4
 */
 public class EclipseResourceStorageProvider implements
 		IEclipseResourceStorageService, IResourceChangeListener,
@@ -216,8 +216,7 @@ public class EclipseResourceStorageProvider implements
 		return mc;
 	}

-	// @TODO: comment is bad: copied from loadContext
-	/** Loads a file and creates a new context from its contents. */
+	/** Unloads the context and destroys it. */
 	private void unloadContext(IFile file) {
 		ModelContext context = loadedContexts.remove(file);
 		if (context != null) {

--- a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/listener/IPersistencyServiceListener.java
+++ b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/listener/IPersistencyServiceListener.java
@@ -26,7 +26,7 @@ import org.fortiss.tooling.kernel.extension.data.ITopLevelElement;
 * @author hoelzl
 * @author $Author$
 * @version $Rev$
- * @ConQAT.Rating GREEN Hash: 42C58F24583661CF28BB783416B2805E
+ * @ConQAT.Rating YELLOW Hash: ECDFE5D1BD7F0D6EEC2386C221CE82BB
 */
 public interface IPersistencyServiceListener {


--- a/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/util/ProjectRootElementUtils.java
+++ b/org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/util/ProjectRootElementUtils.java
@@ -28,7 +28,7 @@ import org.fortiss.tooling.kernel.service.IPersistencyService;
 * @author hoelzl
 * @author $Author$
 * @version $Rev$
- * @ConQAT.Rating GREEN Hash: 54BEFCC44B523976BF14E4F2BC6FB697
+ * @ConQAT.Rating YELLOW Hash: 4F0D1BA91E831DBE36E16AC7553F730B
 */
 public final class ProjectRootElementUtils {