YELLOW

Issue-ref: 4299
Issue-Url: af3#4299



Signed-off-by: Sebastian Bergemann <bergemann@fortiss.org>

org.fortiss.tooling.base.ui/src/org/fortiss/tooling/base/ui/editor/.ratings

@@ -2,6 +2,6 @@ AdvancedTreeViewerEditorBase.java 9d9eded6848ee78991d1416592d1136efd71d2b7 GREEN
 FormsEditorBase.java b113501b98ffffcac362ca9f474ad02a42bde186 GREEN
 GEFEditorBase.java e668f596f45f07215994cbbd3929a9438331718f GREEN
 SourceEditorBase.java 47e69e2e6788b9897339c384cd03f9a22755037c GREEN
-SourceEditorConfigurationBase.java 7ebd080e394b394602e136ae7d63b5a51f952b0c RED
+SourceEditorConfigurationBase.java edb5eaa20d3f6c060600422b841c668b5efccabf YELLOW
 SourceEditorUndoRedo.java 08127a8e0afb4f9c2f4c21294ca3220282c25bf0 GREEN
 TreeViewerEditorBase.java 1c59689ff57c4f3cc180d85f13021fc03461ecb0 GREEN

org.fortiss.tooling.base.ui/src/org/fortiss/tooling/base/ui/editor/SourceEditorConfigurationBase.java

 /*-------------------------------------------------------------------------+
-| Copyright 2012 fortiss GmbH                                              |
+| Copyright 2023 fortiss GmbH                                              |
 |                                                                          |
 | Licensed under the Apache License, Version 2.0 (the "License");          |
 | you may not use this file except in compliance with the License.         |
@@ -114,6 +114,12 @@ public abstract class SourceEditorConfigurationBase<T extends EObject>
 		/*
 		 * FIXME (AB): Wouldn't it be cleaner and more efficient, to collect all rules in one List
 		 * that can be converted to an array at once?
+		 * Answer (SeBe): Yes, but you cannot directly cast the whole list to the more generic
+		 * IRule. Either, I would need to go through all lists and cast each WordRule and each
+		 * PatternRule separately to an IRule before I could merge them in one List, or I would need
+		 * to turn every initial List directly into an array and then concatenate these arrays. Both
+		 * needs more effort and computation power than the current solution.
+		 * I would therefore suggest to leave it like it is now.
 		 */
 		// word rules
 		List<WordRule> wordRules = getCommonRules();