GREEN (with minor cleanup)

Issue-Ref: 4225
Issue-Url: af3#4225



Signed-off-by: Simon Barner <barner@fortiss.org>

org.fortiss.tooling.kernel.ui/src/org/fortiss/tooling/kernel/ui/internal/views/marker/.ratings

-MarkerViewContentProvider.java 1d188fa2ef7acf075706da36c98dd9562a8d98ca YELLOW
-MarkerViewController.java 75718eb856ee94a7d7ec96b5c285108d74d77b6c YELLOW
+MarkerViewContentProvider.java 761764e4913370e2b99be123209785df8001f93f GREEN
+MarkerViewController.java 75718eb856ee94a7d7ec96b5c285108d74d77b6c GREEN
 MarkerViewPart.java 65d80aaf6a6b1a67dadc5547401fdfd02584add7 GREEN
 MarkerViewUIProvider.java 2a65b0c416f07fffa496099d94936b1a0eaaeb59 GREEN

org.fortiss.tooling.kernel.ui/src/org/fortiss/tooling/kernel/ui/internal/views/marker/MarkerViewContentProvider.java

@@ -39,26 +39,26 @@ public class MarkerViewContentProvider extends DynamicTreeContentProviderBase<Ob
 	@SuppressWarnings("unchecked")
 	@Override
 	public Collection<? extends Object> getChildren(Object parent) {
-		Map<ESeverity, Boolean> statusEntries;
-		Collection<IConstraintViolation<?>> violation_list =
-				new ArrayList<IConstraintViolation<?>>();
+
 		if(parent instanceof Map<?, ?>) {
-			statusEntries = (Map<ESeverity, Boolean>)parent;
+			Map<ESeverity, Boolean> statusEntries = (Map<ESeverity, Boolean>)parent;
 
-			// sort the entries according to the severity levels to have later a meaningful display
-			// order (first FATAL, then ERROR, WARNING, INFO and at the end/bottom DEBUG)
+			// Sort the entries types according to the severity levels to have later a meaningful
+			// display order (first FATAL, then ERROR, WARNING, INFO and at the end/bottom DEBUG)
 			List<Map.Entry<ESeverity, Boolean>> orderedStatusEntries =
 					new ArrayList<>(statusEntries.entrySet());
 			orderedStatusEntries.sort((mapEntry1, mapEntry2) -> Integer.compare(
 					getIntSeverity(mapEntry1.getKey()), getIntSeverity(mapEntry2.getKey())));
 
+			Collection<IConstraintViolation<?>> rval = new ArrayList<IConstraintViolation<?>>();
+			IMarkerService ms = IMarkerService.getInstance();
 			for(Entry<ESeverity, Boolean> statusEntry : orderedStatusEntries) {
+				// Only display selected severity types
 				if(statusEntry.getValue()) {
-					violation_list.addAll(IMarkerService.getInstance()
-							.getAllViolationsWithSeverity(statusEntry.getKey()));
+					rval.addAll(ms.getAllViolationsWithSeverity(statusEntry.getKey()));
 				}
 			}
-			return violation_list;
+			return rval;
 		}
 		return null;
 	}