GREEN

(some cleanup without functional changes has been applied)

org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/base/.ratings

@@ -4,7 +4,7 @@ EObjectActionBase.java 67c307ac15d7f45ad970ab1df42f4729fee09518 GREEN
 EReferencePropertySectionBase.java d4cce5af54efc59b33415a34d5130ab8952d60ce GREEN
 EditorBase.java 3af0350a488adf676d5b5e5ccad2087fb97c3d5b GREEN
 ModelEditorBindingBase.java 12f6323750cde28cefa99c1ec9d45191c8779109 GREEN
-ModelElementHandlerBase.java 6feeb52a46b4b3a4c3d72f857f019434e12e2fe5 YELLOW
+ModelElementHandlerBase.java 35bc01f05872770e4c69ae59321ea1775e121837 GREEN
 MultiEObjectActionBase.java ab9170f3918a069fa2a3aabae0436618317fa7b8 GREEN
 NamedCommentedModelElementHandlerBase.java 8f9cb1e750afb577f528d330165a9f377e23aa8b GREEN
 PropertySectionBase.java f8e2cf4444ab4808ac8c45b65840619b367ba112 GREEN

org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/base/ModelElementHandlerBase.java

@@ -15,7 +15,8 @@
 +--------------------------------------------------------------------------*/
 package org.fortiss.tooling.kernel.ui.extension.base;
 
-import java.util.Collections;
+import static java.util.Collections.emptyList;
+
 import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
@@ -31,7 +32,7 @@ import org.fortiss.tooling.kernel.ui.extension.IModelElementHandler;
  * Base implementation for {@link IModelElementHandler}s.
  * 
  * Sub-classes must implement {@link #getIconImageDescriptor()} and may override
- * the other methods of {@link IModelElementHandler}. By default the base
+ * the other non-final methods of {@link IModelElementHandler}. By default the base
  * implementation returns empty lists for the respective methods. Open editor
  * requests are handled by returning the model element itself.
  * 
@@ -86,31 +87,31 @@ public abstract class ModelElementHandlerBase<T extends EObject> implements IMod
 	/** {@inheritDoc} */
 	@Override
 	public List<EObject> getSubnodes(T element) {
-		return Collections.emptyList();
+		return emptyList();
 	}
 
 	/** {@inheritDoc} */
 	@Override
 	public List<EObject> getConnectors(T element) {
-		return Collections.emptyList();
+		return emptyList();
 	}
 
 	/** {@inheritDoc} */
 	@Override
 	public List<EObject> getIncomingConnections(T element) {
-		return Collections.emptyList();
+		return emptyList();
 	}
 
 	/** {@inheritDoc} */
 	@Override
 	public List<EObject> getOutgoingConnections(T element) {
-		return Collections.emptyList();
+		return emptyList();
 	}
 
 	/** {@inheritDoc} */
 	@Override
 	public List<EObject> getSpecifications(T element) {
-		return Collections.emptyList();
+		return emptyList();
 	}
 
 	/** {@inheritDoc} */
@@ -142,8 +143,9 @@ public abstract class ModelElementHandlerBase<T extends EObject> implements IMod
 	}
 
 	/**
-	 * Returns the overlay, that is applied to the icon of the given element.
-	 * This overlay is used in getIcon() to decorate the image of getIconImageDescriptor().
+	 * Returns the overlay, that is applied on top of the icon of the given element.
+	 * This overlay is used in {@link #getIcon(EObject)} to decorate the image returned by
+	 * {@link #getIconImageDescriptor(EObject)}.
 	 * 
 	 * @param element
 	 *            The element for which its icon shall be decorated with the overlay.