Skip to content
Snippets Groups Projects
Commit 79980e69 authored by Daniel Ratiu's avatar Daniel Ratiu
Browse files

Yet another review of the code.

parent a0a44f18
No related branches found
No related tags found
No related merge requests found
Showing
with 24 additions and 19 deletions
......@@ -27,7 +27,7 @@ import org.eclipse.swt.graphics.Image;
* @author hoelzl
* @author $Author$
* @version $Rev$
* @ConQAT.Rating YELLOW Hash: E59433EE668B5ECADF9434D12178512D
* @ConQAT.Rating GREEN Hash: 2F45B07DB4FEDB2C91BA48C8D2D55B01
*/
public enum ESharedImages {
......
......@@ -28,7 +28,7 @@ import org.osgi.framework.BundleContext;
* @author hoelzl
* @author $Author$
* @version $Rev$
* @ConQAT.Rating YELLOW Hash: C33F030E817D16A4704D4136B5734537
* @ConQAT.Rating GREEN Hash: EFBA6B7C4976A505A4B01B242107E42A
*/
public class ToolingKernelUIActivator extends AbstractUIPlugin {
......
......@@ -38,7 +38,7 @@ import org.fortiss.tooling.kernel.ui.service.IContextMenuService;
* @author hoelzl
* @author $Author$
* @version $Rev$
* @ConQAT.Rating YELLOW Hash: 477CB9CFFBADD034DBEA59D615E3478B
* @ConQAT.Rating GREEN Hash: C290BD0529E603F61EAA10692326C759
*/
public interface IContextMenuContributor {
......
......@@ -49,7 +49,7 @@ import org.fortiss.tooling.kernel.ui.util.DataBindingUtils;
* @author hoelzl
* @author $Author$
* @version $Rev$
* @ConQAT.Rating YELLOW Hash: 138F31EE850E5B4039B7335B3A9F57EA
* @ConQAT.Rating GREEN Hash: B0BDB66957F0952332543C419C83D83A
*/
public abstract class PropertySectionBase extends AbstractPropertySection {
......
......@@ -33,7 +33,7 @@ import org.fortiss.tooling.kernel.ui.internal.ContextMenuService;
* @author hoelzl
* @author $Author$
* @version $Rev$
* @ConQAT.Rating YELLOW Hash: FBC3C9C124471A334B753871F8C7C25B
* @ConQAT.Rating GREEN Hash: 22F4A31AAC7569A155D31BD110DB6849
*/
public interface ContextMenuContextProvider {
......
......@@ -41,7 +41,7 @@ import org.fortiss.tooling.kernel.ui.util.EObjectSelectionUtils;
* @author hoelzlf
* @author $Author$
* @version $Rev$
* @ConQAT.Rating YELLOW Hash: 329EC88BD38752F5F1BBA3DCE57B32B2
* @ConQAT.Rating GREEN Hash: 712C0561435C4CC99112DBBCEB5E8FAD
*/
public class ActionService implements IActionService,
IPersistencyServiceListener, CommandStackListener {
......
......@@ -43,7 +43,7 @@ import org.osgi.framework.Bundle;
* @author hoelzl
* @author $Author$
* @version $Rev$
* @ConQAT.Rating YELLOW Hash: D70B79C16761E3D0398CE26B0F56D9EF
* @ConQAT.Rating GREEN Hash: 8B48B88514C68D10B58255829A50B188
*/
public class ContextMenuService implements IContextMenuService {
......
......@@ -51,6 +51,8 @@ public class ModelElementHandlerService extends
@Override
public IModelElementHandler<EObject> getModelElementHandler(
EObject modelElement) {
// TODO: Class<? extends EObject> is equivalent to Class<?> -- please
// use the shorter version
Class<? extends EObject> clazz = modelElement.getClass();
List<IModelElementHandler<EObject>> handlerList = getRegisteredHandlers(clazz);
if (handlerList == null || handlerList.isEmpty()) {
......
......@@ -47,7 +47,7 @@ import org.fortiss.tooling.kernel.ui.util.EObjectSelectionUtils;
* @author hoelzl
* @author $Author$
* @version $Rev$
* @ConQAT.Rating YELLOW Hash: 10615C5F91C539B5021A54DC0DAC1AB6
* @ConQAT.Rating RED Hash: 64B888719B1AB85A0929FDB73798A97D
*/
public class NavigatorService implements INavigatorService,
IPersistencyServiceListener, CommandStackListener {
......@@ -110,7 +110,8 @@ public class NavigatorService implements INavigatorService,
/** {@inheritDoc} */
@Override
public void topLevelElementChanged(ITopLevelElement element) {
// ignore this, MarkerService will call refresh()
// ignore this, {@link MarkerService} will call refresh()
// TODO: does {@link MarkerService} call refresh? which method?
}
/** {@inheritDoc} */
......
......@@ -25,7 +25,7 @@ import org.fortiss.tooling.kernel.ui.service.IPropertiesService;
* @author hoelzl
* @author $Author$
* @version $Rev$
* @ConQAT.Rating YELLOW Hash: 92B0DF1AD44755A2887040BB639164DE
* @ConQAT.Rating RED Hash: 94B90137442EBBDF8F76FF04C1E89F67
*
*/
public class PropertiesService implements IPropertiesService {
......
<!--
$Id$
@version $Rev$
@ConQAT.Rating YELLOW Hash: DEE82E65C55976C18489848C51FF6CCB
@ConQAT.Rating GREEN Hash: F83081A294B439073D0B6C695C634349
-->
<body>
Implementations of the user-interface kernel services defined in the <code>kernel.ui.services</code> package.
......
......@@ -29,7 +29,7 @@ import org.eclipse.swt.dnd.DragSourceEvent;
* @author eder
* @author $Author: hoelzl $
* @version $Rev: 18709 $
* @ConQAT.Rating YELLOW Hash: 7274445CF4D8976F98D2261373206375
* @ConQAT.Rating GREEN Hash: E21E2799DA5A521B7B102FCF933556F5
*/
public class EObjectDragSourceListener extends DragSourceAdapter {
......
......@@ -53,7 +53,7 @@ import org.fortiss.tooling.kernel.ui.service.IModelElementHandlerService;
* @author eder
* @author $Author: hoelzl $
* @version $Rev: 18709 $
* @ConQAT.Rating YELLOW Hash: 92F80D3F6619406729FAF681F459C9F1
* @ConQAT.Rating GREEN Hash: 583950BDF6A74E307DD7AFE6FE49C98D
*/
public class LibraryView extends ViewPart {
......
......@@ -31,7 +31,7 @@ import org.fortiss.tooling.kernel.ui.service.INavigatorService;
* @author hoelzl
* @author $Author$
* @version $Rev$
* @ConQAT.Rating YELLOW Hash: 4D718D32000E7A02F1567CB87E44EA97
* @ConQAT.Rating GREEN Hash: DAC72CF91E6304A5F42B494740241F43
*/
final class LinkWithEditorPartListener implements IPartListener2 {
......
......@@ -35,7 +35,7 @@ import org.fortiss.tooling.kernel.ui.service.IModelElementHandlerService;
* @author hoelzlf
* @author $Author$
* @version $Rev$
* @ConQAT.Rating YELLOW Hash: 5391C0EF42406CBD9C5C9B51AA9933E4
* @ConQAT.Rating GREEN Hash: D0A13ABCEB4123B743F9E7124B1E6BA4
*/
public class NavigatorTreeContentProvider implements ITreeContentProvider {
......
......@@ -30,7 +30,7 @@ import org.fortiss.tooling.kernel.ui.service.IModelElementHandlerService;
* @author hoelzlf
* @author $Author$
* @version $Rev$
* @ConQAT.Rating YELLOW Hash: 4A21A388F86E1827C600C6F141F95D4F
* @ConQAT.Rating GREEN Hash: FFAE22D5782B4A3DB33744FDE430B00D
*/
public final class NavigatorTreeLabelProvider extends BaseLabelProvider
implements ILabelProvider {
......
......@@ -35,6 +35,8 @@ import org.fortiss.tooling.kernel.ui.service.IModelElementHandlerService;
import org.fortiss.tooling.kernel.ui.service.INavigatorService;
/**
* TODO: why is this class in the "views" package?
*
* The contributor for the dynamic new menu based on composition.
*
* @author hoelzlf
......
<!--
$Id$
@version $Rev$
@ConQAT.Rating YELLOW Hash: 527D9BF51495443E95F62CF8C27B4AA8
@ConQAT.Rating GREEN Hash: 198A5F9B0AFF625D7F74C572F760E0B0
-->
<body>
Implementations of the navigator and model element library view.
......
......@@ -45,7 +45,7 @@ import org.fortiss.tooling.kernel.ui.internal.ContextMenuService;
* @author hoelzl
* @author $Author$
* @version $Rev$
* @ConQAT.Rating YELLOW Hash: D8550C3C8DF97FAC802F2F02068318B6
* @ConQAT.Rating GREEN Hash: E54F244C93FDBB64DE4D105EA848B936
*/
public interface IContextMenuService {
......
......@@ -40,7 +40,7 @@ import org.fortiss.tooling.kernel.ui.internal.NavigatorService;
* @author hoelzl
* @author $Author$
* @version $Rev$
* @ConQAT.Rating YELLOW Hash: BCEF298D7704D4ECC20EA5A33E380794
* @ConQAT.Rating GREEN Hash: 3280D803F41D98359C9F6B73EBAB5B46
*/
public interface INavigatorService {
/** Returns the singleton instance of the service. */
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment