YELLOW

Issue-ref: 4265
Issue-URL: af3#4265



Signed-off-by: Sebastian Bergemann <bergemann@fortiss.org>

org.fortiss.tooling.ext.reuse.ui/src/org/fortiss/tooling/ext/reuse/ui/utils/.ratings

-ReuseLibraryUIUtils.java ab458ab3fa3c2a8a5367ca57b4ad025e95e60647 RED
+ReuseLibraryUIUtils.java fed62784975bf8e6fc1625505636e247dfb6c86e YELLOW
 ReuseLibraryViewUtils.java 34a852dc692ec56cb3e9fd8dcea99d64f31503b3 GREEN

org.fortiss.tooling.ext.reuse.ui/src/org/fortiss/tooling/ext/reuse/ui/utils/ReuseLibraryUIUtils.java

@@ -54,13 +54,11 @@ import javafx.stage.Stage;
  */
 public class ReuseLibraryUIUtils {
 
-	// FIXME (AB): Constants like these two should be named ALL_CAPITAL_LETTERS like ISO_DATE_TIME, too.
 	/** Standard width preference for dialog windows used in the reuse context. */
-	private final static Double dialogWindowWidthPref = 700.0;
+	private final static Double DIALOG_WINDOW_WIDTH_PREF = 700.0;
 
-	// FIXME (AB): Constants like these two should be named ALL_CAPITAL_LETTERS like ISO_DATE_TIME, too.
 	/** Standard height preference for dialog windows used in the reuse context. */
-	private final static Double dialogWindowHeightPref = 500.0;
+	private final static Double DIALOG_WINDOW_HEIGHT_PREF = 500.0;
 
 	/**
 	 * Returns the selected {@link ReuseElementSpec} by user from all
@@ -276,8 +274,8 @@ public class ReuseLibraryUIUtils {
 	 */
 	public static void showBasicScrollableInformation(String windowTitle, String headerText, String bodyText) {
 		boolean showSymbol = true;
-		showCustomScrollableAlert(INFORMATION, windowTitle, headerText, bodyText, showSymbol, dialogWindowWidthPref,
-				dialogWindowHeightPref);
+		showCustomScrollableAlert(INFORMATION, windowTitle, headerText, bodyText, showSymbol, DIALOG_WINDOW_WIDTH_PREF,
+				DIALOG_WINDOW_HEIGHT_PREF);
 	}
 
 	/**

org.fortiss.tooling.ext.reuse/src/org/fortiss/tooling/ext/reuse/utils/.ratings

 ReuseLibraryModelElementFactory.java 4ee3eb7449e212643992a3dec6cfb8f4278efb70 GREEN
-ReuseLibraryUtilsBasics.java fe69a92d1405b33bbdf178cd6d0a5c25020681a3 RED
+ReuseLibraryUtilsBasics.java b651b31f6d94ff98a8f965440d662bfc4655c31b YELLOW
 ReuseLibraryUtilsManipulation.java 77a646db5a63ba7c61664dbcaf34a9036003fde5 GREEN

org.fortiss.tooling.ext.reuse/src/org/fortiss/tooling/ext/reuse/utils/ReuseLibraryUtilsBasics.java

@@ -44,12 +44,11 @@ import org.fortiss.tooling.kernel.model.INamedElement;
  */
 public class ReuseLibraryUtilsBasics {
 
-	//FIXME (AB): Constants like these two should be named ALL_CAPITAL_LETTERS like ISO_DATE_TIME, too. 
 	/** Standard internal date format used for reuse (e.g. for hash dates) */
-	public final static DateTimeFormatter internalReuseDateFormatter = ISO_DATE_TIME;
-	// FIXME (AB): Constants like these two should be named ALL_CAPITAL_LETTERS like ISO_DATE_TIME, too.
+	public final static DateTimeFormatter INTERNAL_REUSE_DATE_FORMATTER = ISO_DATE_TIME;
+
 	/** Standard date format used for reuse (easier readable) */
-	public final static DateTimeFormatter displayReuseDateFormatter = RFC_1123_DATE_TIME;
+	public final static DateTimeFormatter DISPLAY_REUSE_DATE_FORMATTER = RFC_1123_DATE_TIME;
 
 	/**
 	 * Returns whether the given element can be used as reuse element.
@@ -344,9 +343,9 @@ public class ReuseLibraryUtilsBasics {
 	public static String getDateAsString(ZonedDateTime date, boolean forDisplay) {
 		if (date != null) {
 			if (forDisplay) {
-				return displayReuseDateFormatter.format(date);
+				return DISPLAY_REUSE_DATE_FORMATTER.format(date);
 			} else {
-				return internalReuseDateFormatter.format(date);
+				return INTERNAL_REUSE_DATE_FORMATTER.format(date);
 			}
 		}
 		return "";