Skip to content
Snippets Groups Projects
Commit 95843d8a authored by Alexander Diewald's avatar Alexander Diewald
Browse files

CR: RED


Issue-Ref: 3437
Signed-off-by: default avatarAlexander Diewald <diewald@fortiss.org>
parent 39546a03
No related branches found
No related tags found
1 merge request!823437
DynamicTreeContentProviderBase.java dff437afeaf7486af05460fa54eca4fa61d7eae6 GREEN
DynamicTreeItem.java afc105cf5acf3d2506d89e0892555100c234ce5b GREEN
DynamicTreeTableUIProviderBase.java fd9fce19a65eb1006ceacb0d869bbe90a8c578b3 GREEN
DynamicTreeTableViewer.java 7c7b767fac8a3b4450a04f01176d1142911dc199 YELLOW
DynamicTreeTableViewer.java b06182c30665f54942703a5e9986822a4d8dd59a RED
DynamicTreeUIProviderBase.java 56fe4df4577b35f1e5e6e4c4be189b706c852d52 GREEN
DynamicTreeViewer.java da5e24ae57777a482d8e12c8262513d8143bfa93 GREEN
DynamicTreeViewerBase.java 47124c847de322a0ae26eb7a114f85ce4bd02d7e GREEN
......
......@@ -111,6 +111,7 @@ public final class DynamicTreeTableViewer<T> extends DynamicTreeViewerBase<T> {
* Adds a non-editable column to the table part of the view. The labels, context menus and icons
* are shown as defined in the {@link DynamicTreeTableUIProviderBase}.
*/
// TODO(AD): Please add a flag to make the column read-only or read-writable.
public void addColumn(String headerLabel, int prefWidth) {
TreeTableColumn<T, String> column = createColumn(headerLabel, prefWidth);
......@@ -141,6 +142,9 @@ public final class DynamicTreeTableViewer<T> extends DynamicTreeViewerBase<T> {
* {@link DynamicTreeTableUIProviderBase} are used as predefined values. The
* {@link EventHandler} is executed after a cell has been successfully edited.
*/
// TODO(AD): This method is redundant and oversimplified (due to the limitation to a text field
// editor). It would be better to change the method "addColumn(...)" to return the created
// column. The client code would be pretty much the same with that change.
public void addColumn(String headerLabel, int prefWidth,
EventHandler<CellEditEvent<T, String>> eventHandler) {
TreeTableColumn<T, String> column = createColumn(headerLabel, prefWidth);
......
FXMLUtils.java c788d21167e06365296c4527dba891dde54393cf YELLOW
FXMLUtils.java 4f62cc98d504b978cc8480432c1f53d0fa6fefcf RED
SceneGraphUtils.java f54304c2eb604934de9afdf9d2a8ca88a762398a GREEN
......@@ -26,6 +26,7 @@ import javafx.fxml.FXMLLoader;
*
* @author munaro
*/
// TODO(AD): Please rename to JFXUtils or JavaFXUtils. Please unify with SceneGraphUtils.
public class FXMLUtils {
/**
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment