Skip to content
Snippets Groups Projects
Commit 96e6b7c7 authored by Simon Barner's avatar Simon Barner
Browse files

- Shorten very long class names (motivated by TODO in...

- Shorten very long class names (motivated by TODO in AbstractDecoratedStyledTextCellDatabindingEditingSupport)
  - TextCellEditorWithTextStyledTextActionHandler -> StyledTextCellEditor
  - AbstractDecoratedTextCellWithTextStyledTextActionHandlerDatabindingEditingSupport -> AbstractDecoratedStyledTextCellDatabindingEditingSupport
  - AbstractTextCellWithTextStyledTextActionHandlerDatabindingEditingSupport -> AbstractStyledTextCellDatabindingEditingSupport

- Update rating of affected classes
  - Resolve minor issues (many documentation)
  - Try to keep current rating where appropriate since the changes are pure renamings
refs 2983
parent e5f46018
No related branches found
No related tags found
No related merge requests found
...@@ -42,20 +42,20 @@ import org.fortiss.tooling.kernel.ui.util.DataBindingUtils; ...@@ -42,20 +42,20 @@ import org.fortiss.tooling.kernel.ui.util.DataBindingUtils;
* abstract methods. * abstract methods.
* </p> * </p>
* <P> * <P>
* Decoration is in effect if either {@link #getTextValidator(Object)} returns a non-null * Decoration is in effect if either {@link #getTextValidator(Object)} returns a non-{@code null}
* {@link IValidator}. * {@link IValidator}.
* </p> * </p>
* *
* @author hoelzl * @author hoelzl
* @author $Author$ * @author $Author$
* @version $Rev$ * @version $Rev$
* @ConQAT.Rating GREEN Hash: BC0D36A060AE96F7784E11F4E02E16E6 * @ConQAT.Rating YELLOW Hash: 0836F73B8DA170C80B3C15AA185F58FE
*/ */
public abstract class AbstractDecoratedTextCellWithTextStyledTextActionHandlerDatabindingEditingSupport public abstract class AbstractDecoratedStyledTextCellDatabindingEditingSupport extends
extends AbstractTextCellWithTextStyledTextActionHandlerDatabindingEditingSupport { AbstractStyledTextCellDatabindingEditingSupport {
/** Constructor. */ /** Constructor. */
public AbstractDecoratedTextCellWithTextStyledTextActionHandlerDatabindingEditingSupport( public AbstractDecoratedStyledTextCellDatabindingEditingSupport(
EditorBase<? extends EObject> editor, ColumnViewer viewer, EditorBase<? extends EObject> editor, ColumnViewer viewer,
DataBindingContext bindingContext) { DataBindingContext bindingContext) {
super(editor, viewer, bindingContext); super(editor, viewer, bindingContext);
......
...@@ -22,27 +22,26 @@ import org.eclipse.emf.ecore.EObject; ...@@ -22,27 +22,26 @@ import org.eclipse.emf.ecore.EObject;
import org.eclipse.jface.viewers.CellEditor; import org.eclipse.jface.viewers.CellEditor;
import org.eclipse.jface.viewers.ColumnViewer; import org.eclipse.jface.viewers.ColumnViewer;
import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Composite;
import org.fortiss.tooling.base.ui.editor.TextCellEditorWithTextStyledTextActionHandler; import org.fortiss.tooling.base.ui.editor.StyledTextCellEditor;
import org.fortiss.tooling.kernel.ui.extension.base.EditorBase; import org.fortiss.tooling.kernel.ui.extension.base.EditorBase;
/** /**
* Abstract base class for inline text cell, with copy-pasting. * Abstract base class for inline text cell, with copy-paste support.
* *
* @author hoelzl * @author hoelzl
* @author $Author$ * @author $Author$
* @version $Rev$ * @version $Rev$
* @ConQAT.Rating GREEN Hash: 129A3738C36A26DB5CC5ACCE0BD08D28 * @ConQAT.Rating YELLOW Hash: 10E8790FF4A5261438CD789743CCD020
*/ */
public abstract class AbstractTextCellWithTextStyledTextActionHandlerDatabindingEditingSupport public abstract class AbstractStyledTextCellDatabindingEditingSupport extends
extends AbstractTextCellDatabindingEditingSupport { AbstractTextCellDatabindingEditingSupport {
/** Editor, which contains this EditingSupport} */ /** Editor, which contains this EditingSupport}. */
protected EditorBase<? extends EObject> editor; protected EditorBase<? extends EObject> editor;
/** Constructor. */ /** Constructor. */
public AbstractTextCellWithTextStyledTextActionHandlerDatabindingEditingSupport( public AbstractStyledTextCellDatabindingEditingSupport(EditorBase<? extends EObject> editor,
EditorBase<? extends EObject> editor, ColumnViewer viewer, ColumnViewer viewer, DataBindingContext bindingContext) {
DataBindingContext bindingContext) {
super(viewer, bindingContext); super(viewer, bindingContext);
this.editor = editor; this.editor = editor;
} }
...@@ -51,9 +50,8 @@ public abstract class AbstractTextCellWithTextStyledTextActionHandlerDatabinding ...@@ -51,9 +50,8 @@ public abstract class AbstractTextCellWithTextStyledTextActionHandlerDatabinding
@Override @Override
protected CellEditor createCellEditor(ColumnViewer viewer) { protected CellEditor createCellEditor(ColumnViewer viewer) {
CellEditor cellEditor = CellEditor cellEditor =
new TextCellEditorWithTextStyledTextActionHandler( new StyledTextCellEditor(editor.getTextStyledTextActionHandler(),
editor.getTextStyledTextActionHandler(), (Composite)getViewer() (Composite)getViewer().getControl());
.getControl());
setupCellEditor(cellEditor); setupCellEditor(cellEditor);
return cellEditor; return cellEditor;
} }
......
...@@ -23,19 +23,16 @@ import org.eclipse.swt.widgets.Control; ...@@ -23,19 +23,16 @@ import org.eclipse.swt.widgets.Control;
import org.eclipse.ui.actions.TextStyledTextActionHandler; import org.eclipse.ui.actions.TextStyledTextActionHandler;
/** /**
* A specific {@link TextCellEditor} with copy-paste key function * A {@link TextCellEditor} with styled text fileds and copy-paste keyboard shortcut support.
*
* TODO(VA) this class should not be called "handler" IMHO, it brings confusion with all the things
* we call handler already.
* *
* @author wenwenchen * @author wenwenchen
* @author $Author$ * @author $Author$
* @version $Rev$ * @version $Rev$
* @ConQAT.Rating GREEN Hash: 792912BF97001631339E59902BE890A2 * @ConQAT.Rating YELLOW Hash: CB25ED6030D8C8BCE63C66C0B639A7C9
*/ */
public class TextCellEditorWithTextStyledTextActionHandler extends TextCellEditor { public class StyledTextCellEditor extends TextCellEditor {
/** text action handler for text fields and styled text fields with copy-paste key function */ /** Text action handler for text fields and styled text fields with copy-paste key function. */
private TextStyledTextActionHandler textStyledTextActionHandler; private TextStyledTextActionHandler textStyledTextActionHandler;
/** /**
...@@ -46,8 +43,8 @@ public class TextCellEditorWithTextStyledTextActionHandler extends TextCellEdito ...@@ -46,8 +43,8 @@ public class TextCellEditorWithTextStyledTextActionHandler extends TextCellEdito
* @param parent * @param parent
* parent composite * parent composite
*/ */
public TextCellEditorWithTextStyledTextActionHandler( public StyledTextCellEditor(TextStyledTextActionHandler textStyledTextActionHandler,
TextStyledTextActionHandler textStyledTextActionHandler, Composite parent) { Composite parent) {
super(); super();
this.textStyledTextActionHandler = textStyledTextActionHandler; this.textStyledTextActionHandler = textStyledTextActionHandler;
create(parent); create(parent);
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment