GREEN (corrected minor flaws)

Issue-ref: 4273
Issue-URL: af3#4273



Signed-off-by: Sebastian Bergemann <bergemann@fortiss.org>

org.fortiss.tooling.ext.variability/src/org/fortiss/tooling/ext/variability/util/.ratings

-VariabilityUtils.java 3a10f28d57ca4da70b6236b74bd682fa8b03582a YELLOW
+VariabilityUtils.java 6f2ffd231c27f5f7ab8c62d05350c0a92392eaf8 GREEN

org.fortiss.tooling.ext.variability/src/org/fortiss/tooling/ext/variability/util/VariabilityUtils.java

@@ -174,17 +174,17 @@ public class VariabilityUtils {
 					() -> elem.addSpecification(finalSpec));
 		}
 
-		final OptionalVariationPointSpecification finalSpec = spec;
-		// Change model only, if the new presence condition is different from the old one
-		PresenceCondition oldPC = spec.getPresenceCondition();
+		// Change model only if the new presence condition is different from the old one
+		PresenceCondition oldPc = spec.getPresenceCondition();
 
 		// If both pc are null, there is nothing to change
-		if(oldPC == null && pc == null) {
+		if(oldPc == null && pc == null) {
 			return true;
 		}
-		// Check whether the old and new are different (i.e. one being null or different value)
-		if(oldPC == null || pc == null ||
-				!oldPC.getStringRepresentation().equals(pc.getStringRepresentation())) {
+		// Check whether the old and new are different (i.e., one being null or different value)
+		if(oldPc == null || pc == null ||
+				!oldPc.getStringRepresentation().equals(pc.getStringRepresentation())) {
+			final OptionalVariationPointSpecification finalSpec = spec;
 			ICommandStackService.getInstance().runAsCommand(elem,
 					() -> finalSpec.setPresenceCondition(pc));
 		}