CR: RED

Issue-Ref: 3437
Signed-off-by: Alexander Diewald <diewald@fortiss.org>

org.fortiss.tooling.common.ui/src/org/fortiss/tooling/common/ui/javafx/layout/.ratings

-CompositeFXControllerBase.java 7434e6a8e5c32207c4ffdcac07e0d3ea0cc1125a YELLOW
-ICompositeFXController.java 16eebea906607ced29506abf00a4c859fa763269 YELLOW
+CompositeFXControllerBase.java a5f872b5e3a1ebd4c8160318bde5f7f99019b99d RED
+ICompositeFXController.java ef49c62dfeefbf996089d0cb36979acda979a98e RED

org.fortiss.tooling.common.ui/src/org/fortiss/tooling/common/ui/javafx/layout/CompositeFXControllerBase.java

@@ -51,11 +51,15 @@ public abstract class CompositeFXControllerBase implements ICompositeFXControlle
 	/** Constructor. */
 	public CompositeFXControllerBase(ICompositeFXController... containments) {
 		this.containments = containments;
+		// TODO(AD): The null assignment is unneeded.
 		this.layout = null;
 	}
 
 	/** {@inheritDoc} */
 	@Override
+	// TODO(AD): Is this method required for each controller, or would it be sufficient to apply the
+	// FXML style in the AF3FXViewPart? Note that in this case, we could define a separate getter
+	// for the layout.
 	public Node getOrLoadLayout() {
 		if(layout == null) {
 			URL fxmlResource = getClass().getResource(getFXMLLocation());

org.fortiss.tooling.common.ui/src/org/fortiss/tooling/common/ui/javafx/layout/ICompositeFXController.java

@@ -25,9 +25,8 @@ import javafx.scene.Node;
  */
 public interface ICompositeFXController {
 
-	/**
-	 * Loads the a JavaFX {@link Node} from the specified {@link FXML} resource.
-	 */
+	/** Loads the a JavaFX {@link Node} from the specified {@link FXML} resource. */
+	// TODO(AD): See base class impl.
 	public Node getOrLoadLayout();
 
 	/** Returns the location of the {@link FXML} resource with the view's layout. */