Skip to content
Snippets Groups Projects
Commit b329ee04 authored by Simon Barner's avatar Simon Barner
Browse files

checkIDs(): Stop generation of error messages after 100 lines

* Works around performance problems with large models that have
  missing/erroneous IDs
* Note that still all deteced problems will be fixed

Issue-Ref: 4180
Issue-Url: af3#4180



Signed-off-by: default avatarSimon Barner <barner@fortiss.org>
parent 3d37d773
No related branches found
No related tags found
1 merge request!1624180: ModelContext.checkIDs(): Stop generation of error messages after 100 lines
Pipeline #32170 passed
Pipeline: maven-releng

#32171

    AutoUndoCommandStack.java fc326adf66c6cea2354884cdc240da5f2f82689a GREEN
    EMFTransactionalCommand.java ba4b5bead9768b6ce6c955b9238cd96cb722533c GREEN
    EclipseResourceStorageService.java 5e60ef7628ea2ad4113cfebde939341e1b1f6cf2 GREEN
    ModelContext.java 484298fe527a4b83a6dceaef5dd459f874f8b737 GREEN
    ModelContext.java 54e38337ad607ae2aa9a6d96e2365debf1bd507b YELLOW
    NonDirtyingEMFTransactionalCommand.java d288ebe35d22442c603496b0c917fb99a8febeea GREEN
    ......@@ -251,6 +251,8 @@ class ModelContext implements ITopLevelElement, CommandStackListener {
    msg += resource.getURI().lastSegment() + "\".\n";
    msg += "Please report this incident since it indicates a programming error ";
    msg += "that could result in corrupted model files.\n";
    int count = 0;
    final int maxErrorMessages = 100;
    for(Entry<String, Integer> entry : objWithIdProblem.entrySet()) {
    Integer id = entry.getValue();
    if(id == null) {
    ......@@ -260,6 +262,11 @@ class ModelContext implements ITopLevelElement, CommandStackListener {
    }
    String name = entry.getKey();
    msg += "element \"" + name + "\"\n";
    if(count++ >= maxErrorMessages) {
    msg += "\n\n*** More than " + maxErrorMessages +
    " IDs have been fixed. Stopping report. Note that all detected problems have been fixed. ***";
    break;
    }
    }
    error(ToolingKernelActivator.getDefault(), msg);
    ......
    0% Loading or .
    You are about to add 0 people to the discussion. Proceed with caution.
    Finish editing this message first!
    Please register or to comment